Closed
Bug 1259023
Opened 8 years ago
Closed 8 years ago
make more of nsIAccessible work with proxied accessibles
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: tbsaunde, Assigned: tbsaunde)
References
Details
Attachments
(6 files, 1 obsolete file)
5.85 KB,
patch
|
yzen
:
review+
|
Details | Diff | Splinter Review |
1.01 KB,
patch
|
yzen
:
review+
|
Details | Diff | Splinter Review |
1.90 KB,
patch
|
yzen
:
review+
|
Details | Diff | Splinter Review |
3.00 KB,
patch
|
tbsaunde
:
review+
|
Details | Diff | Splinter Review |
1.15 KB,
patch
|
tbsaunde
:
review+
|
Details | Diff | Splinter Review |
2.17 KB,
patch
|
tbsaunde
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8733850 -
Flags: review?(amarchesini)
Assignee | ||
Comment 2•8 years ago
|
||
Attachment #8733851 -
Flags: review?(amarchesini)
Assignee | ||
Comment 3•8 years ago
|
||
Attachment #8733853 -
Flags: review?(amarchesini)
https://hg.mozilla.org/integration/mozilla-inbound/rev/800306e9c573 https://hg.mozilla.org/integration/mozilla-inbound/rev/358d513417fb https://hg.mozilla.org/integration/mozilla-inbound/rev/b92ce093fe65
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/6378e50f68ff for crashes in various tests: https://treeherder.mozilla.org/logviewer.html#?job_id=24751020&repo=mozilla-inbound https://treeherder.mozilla.org/logviewer.html#?job_id=24751025&repo=mozilla-inbound https://treeherder.mozilla.org/logviewer.html#?job_id=24751097&repo=mozilla-inbound
Flags: needinfo?(tbsaunde+mozbugs)
Comment 6•8 years ago
|
||
Attachment #8737320 -
Flags: review?(tbsaunde+mozbugs)
Assignee | ||
Comment 7•8 years ago
|
||
Comment on attachment 8737320 [details] [diff] [review] 1259023 patch >- mBits(reinterpret_cast<uintptr_t>(aProxy) | IS_PROXY) {} >+ mBits(aProxy == nullptr ? 0 : (reinterpret_cast<uintptr_t>(aProxy) | IS_PROXY)) {} aProxy ? reinterpret_cast<>() : 0 seems more normal. > NS_IMETHODIMP > xpcAccessible::GetNextSibling(nsIAccessible** aNextSibling) > { > NS_ENSURE_ARG_POINTER(aNextSibling); > *aNextSibling = nullptr; >+ if (IntlGeneric().IsNull()) >+ return NS_ERROR_FAILURE; > > if (IntlGeneric().IsAccessible()) { given these conditions you can change the check proxy is not null to an assert here and below, but I guess its not really important.
Flags: needinfo?(tbsaunde+mozbugs)
Attachment #8737320 -
Flags: review?(tbsaunde+mozbugs) → review+
Comment 8•8 years ago
|
||
Attachment #8737336 -
Flags: review?(tbsaunde+mozbugs)
Assignee | ||
Updated•8 years ago
|
Attachment #8737336 -
Flags: review?(tbsaunde+mozbugs) → review+
Comment 9•8 years ago
|
||
Comment on attachment 8733850 [details] [diff] [review] make nsIAccessible.parent work with proxies Review of attachment 8733850 [details] [diff] [review]: ----------------------------------------------------------------- Sealing review as per Trevor's request. ::: accessible/atk/AccessibleWrap.cpp @@ +1089,5 @@ > +AtkObject* > +GetWrapperFor(AccessibleOrProxy aObj) > +{ > + if (aObj.IsProxy()) { > + return GetWrapperFor(aObj.AsProxy()); nit: indentation here and below.
Attachment #8733850 -
Flags: review?(amarchesini) → review+
Comment 10•8 years ago
|
||
Comment on attachment 8733851 [details] [diff] [review] make nsIAccessible.indexInParent work on proxied accessibles Review of attachment 8733851 [details] [diff] [review]: ----------------------------------------------------------------- Looks good with my follow up accounting for nullptr.
Attachment #8733851 -
Flags: review?(amarchesini) → review+
Comment 11•8 years ago
|
||
Comment on attachment 8733853 [details] [diff] [review] make nsIAccessible.{Next,Prev}Sibling work with proxied accessibles Review of attachment 8733853 [details] [diff] [review]: ----------------------------------------------------------------- Looks good with my follow up handling nullptr
Attachment #8733853 -
Flags: review?(amarchesini) → review+
Comment 12•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/b45ffb5760bc https://hg.mozilla.org/integration/mozilla-inbound/rev/e8c276c75965
Comment 13•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b45ffb5760bc https://hg.mozilla.org/mozilla-central/rev/e8c276c75965
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Comment 14•8 years ago
|
||
I believe there are 3 more patches to land, I should've added leave-open for this bug.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 15•8 years ago
|
||
Don't check for Intl() since we have a check for isNull and isAccessible in next/previous sibling and index in parent methods.
Attachment #8738204 -
Flags: review?(tbsaunde+mozbugs)
Comment 16•8 years ago
|
||
Note: without the change in accessible/tests/mochitest/selectable/a11y.ini the mochitests do not run locally after bug 1242051
Comment 17•8 years ago
|
||
(In reply to Yura Zenevich [:yzen] from comment #16) > Note: without the change in accessible/tests/mochitest/selectable/a11y.ini > the mochitests do not run locally after bug 1242051 Actually ignore the a11y.ini when reviewing, a follow up from the person updating the *.ini files is already in inbound.
Comment 18•8 years ago
|
||
cleaned up version with not a11y.ini changes
Attachment #8738204 -
Attachment is obsolete: true
Attachment #8738204 -
Flags: review?(tbsaunde+mozbugs)
Attachment #8739015 -
Flags: review?(tbsaunde+mozbugs)
Assignee | ||
Comment 19•8 years ago
|
||
Comment on attachment 8739015 [details] [diff] [review] 1259023 patch 3 it'd really make more sense to squash this into the commits this effects.
Attachment #8739015 -
Flags: review?(tbsaunde+mozbugs) → review+
Comment 20•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ce4af341b03e https://hg.mozilla.org/integration/mozilla-inbound/rev/f917fee48b33 https://hg.mozilla.org/integration/mozilla-inbound/rev/18de7e204735
Comment 21•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ce4af341b03e https://hg.mozilla.org/mozilla-central/rev/f917fee48b33 https://hg.mozilla.org/mozilla-central/rev/18de7e204735
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Assignee: nobody → tbsaunde+mozbugs
You need to log in
before you can comment on or make changes to this bug.
Description
•