Closed Bug 1259041 Opened 9 years ago Closed 9 years ago

12.55 - 13.86% installer size (linux32, linux64) regression on push 254e87129b91 (Thu Mar 17 2016)

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox48 affected)

Status:
RESOLVED WORKSFORME
Tracking Flags:
Tracking Status
firefox48 --- affected

People

(Reporter: jmaher, Unassigned)

References

Details

now that we upload stats to perfherder we get alerts on things like build times and installer sizes. In this case the linux debug installer size increased: https://treeherder.mozilla.org/perf.html#/alerts?id=467 here is the pushlog: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=ea94d9e53c7a&tochange=254e87129b91 we should ensure this is intentional.
The before build has no symbol table, the after does. This exposed a (possible) ordering problem in old-configure here: https://hg.mozilla.org/integration/mozilla-inbound/file/6172dce22b56/old-configure.in#l1245 MOZ_DMD set MOZ_PROFILING, but only after MOZ_PROFILING was used to set STRIP_FLAGS="--strip-debug". Now --enable-dmd is implying --enable-profiling in Python configure. It looks a bit like we were intending to keep the symbol table for --enable-dmd builds all along.
Flags: needinfo?(mh+mozilla)
Joel: thanks for noticing and filing the bug! Chris: thanks for tracking it down! It looks like this is actually fixing intended behavior that was previously broken because writing anything in autoconf is terrible.
I guess we can call this the first success story of the switch away from autoconf.
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: needinfo?(mh+mozilla)
Resolution: --- → WORKSFORME
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.