Closed
Bug 1259057
Opened 8 years ago
Closed 8 years ago
Remove ifdef'ed out s_mp_clamp() call at the end of s_mp_rshd()
Categories
(NSS :: Libraries, defect)
NSS
Libraries
Tracking
(firefox48 affected)
RESOLVED
FIXED
3.25
| Tracking | Status | |
|---|---|---|
| firefox48 | --- | affected |
People
(Reporter: ttaubert, Assigned: ttaubert)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
879 bytes,
patch
|
franziskus
:
review+
|
Details | Diff | Splinter Review |
s_mp_rshd(a, p) shifts an mp_int |a| by |p| digits to the right. It zeroes all now unused digits to maintain the invariant that digits above the precision are all zero. We don't need to call s_mp_clamp() at the end here, assuming the above invariant. That's why it's wrapped in #ifdef 0 - #endif. Let's just remove those lines.
|
Assignee | |
Comment 1•8 years ago
|
||
Assignee: nobody → ttaubert
Status: NEW → ASSIGNED
Attachment #8746003 -
Flags: review?(franziskuskiefer)
|
||
Updated•8 years ago
|
Attachment #8746003 -
Flags: review?(franziskuskiefer) → review+
|
|
Assignee | |
Comment 2•8 years ago
|
||
https://hg.mozilla.org/projects/nss/rev/9cd91651df9a
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•8 years ago
|
Target Milestone: --- → 3.25
You need to log in
before you can comment on or make changes to this bug.
Description
•