1259062 - Create a node screenshot popup to choose between clipboard/save as

Status: NEW

(DevTools :: Inspector, enhancement, P2)

Description

[Julian Descottes [:jdescottes]]

Attachment: ubuntu_screenshot_popup.png

The current node screenshot tool saves the screenshot as a file (sometimes hard to notice due to lack of visual feedback). In Bug 1257913, we plan to add a copy to clipboard feature.

Another suggestion is to have a popup displayed when doing a node screenshot, similar to the popup displayed on Ubuntu when doing a screen capture (see attachment).

The popup would display a preview of the screenshot, and propose either to save as file or copy to clipboard. Additionally, the user gets some feedback and can check if the preview matches the expectations.

Comment 1

[Julian Descottes [:jdescottes]]

Helen: hi! Saw this screenshot popup Ubuntu and thought it might be appropriate for the node screenshot feature. What do you think?

Comment 2

[Helen V. Holmes (:helenvholmes) (:✨)]

One of the nice things about screenshotting tools is how quickly they work (that they automatically save, that is). While I don't dislike this feature, I think that adding extra steps to something that currently is as easy as a click could be contrived as annoying.

As for differentiating between screenshot node/copy node to clipboard, I feel like these could be two options in the right-click panel right underneath each other pretty elegantly.

Comment 3

[Julian Descottes [:jdescottes]]

(In reply to Helen V. Holmes (:helenvholmes) (:✨)(pls ni?)) from comment #2)
> One of the nice things about screenshotting tools is how quickly they work
> (that they automatically save, that is). While I don't dislike this feature,
> I think that adding extra steps to something that currently is as easy as a
> click could be contrived as annoying.
> 
> As for differentiating between screenshot node/copy node to clipboard, I
> feel like these could be two options in the right-click panel right
> underneath each other pretty elegantly.

Good point, for the "node screenshot" the context menu can just display the two options. 
Or maybe a sub-menu "Node screenshot" with two options such as "Copy node screenshot to clipboard" and "Save node screenshot as file" ?

Helen: is Bug 1257913 only about "fullpage screenshot" or will it also cover the "node screenshot"? 
If yes, happy to close this one as duplicate. If not, we can repurpose this bug.

Comment 4

[Helen V. Holmes (:helenvholmes) (:✨)]

(In reply to Julian Descottes [:jdescottes] from comment #3)
> Good point, for the "node screenshot" the context menu can just display the
> two options. 
> Or maybe a sub-menu "Node screenshot" with two options such as "Copy node
> screenshot to clipboard" and "Save node screenshot as file" ?
Let's keep them top level with the two options—I think a submenu with only two things in it is excessive. I'll add it to Bug 1211613.

> Helen: is Bug 1257913 only about "fullpage screenshot" or will it also cover
> the "node screenshot"? 
> If yes, happy to close this one as duplicate. If not, we can repurpose this
> bug.
I don't think this is a duplicate because that one originally only captured the fullpage screenshot UX—however, it would be great is the UX notes in that bug got applied to this bug as well!

Comment 5

[Patrick Brosset <:pbro>]

Triaging (filter on CLIMBING SHOWS).

Comment 6

[Sebastian Zartner [:sebo]]

Another way to choose between those options is outlined in bug 1449537.

Sebastian