1259099 - Consider enabling LeakCanary in Nightly

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect, P5)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

We have LeakCanary in local builds (bug 1238066) and we would like to enable it in Nightly too.

I think we did this only for local builds in the beginning because it's easier to do this in gradle. Now we need to pick a different dependency when building Nightly (LeakCanary vs. LeakCanary-NoOp).

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

We could make this depend on using gradle for builds. Nick is moving towards this, right?

Comment 2

[Nick Alexander :nalexander [he/him]]

(In reply to Mark Finkle (:mfinkle) from comment #1)
> We could make this depend on using gradle for builds. Nick is moving towards
> this, right?

Yep, Bug 1254353 and https://mail.mozilla.org/pipermail/mobile-firefox-dev/2016-March/001861.html.  Don't want to commit to 48, though.

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Hopefully this will also make this random "LeakCanary classes missing" crash go away (local builds): bug 1255580.

Comment 4

[Richard Newman [:rnewman]]

Can we run a pass in Nightly before 57 ships? I wonder if our #2 crash, Bug 760394, is provoked by leaks…

Comment 5

[Nevin Chen(Not active on Bugzilla)]

NI Joe and Wesly to help prioritize this

Comment 6

[Wesly Huang (EPM)]

considering the user base of Nightly and the benifit it gains, set P3 first.

Comment 7

[Jan Henning [:JanH]]

One thing I found annoying when Leakcanary was first enabled was that it would periodically freeze Firefox in order to get a memory dump (?), which I'd guess normal users would find even more irritating. So we should check whether this is still a thing [1] before letting this loose on our Nightly population (although bug 760394 might temporarily warrant even that).

[1] Admittedly I eventually turned Leakcanary off on my local builds, because a) the constant hangs were too annoying and b) at least on my old phone the reports weren't really useful because instead of displaying actual leaks, Leakcanary itself ran out of memory. I guess I should give it a try again now...

Comment 8

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 9

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.