1259127 - Content notifications: Consider adding "Read" action to notification

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

This is how content notifications look like currently:
https://bugzilla.mozilla.org/attachment.cgi?id=8723718

For me it looks like "Notifications Setting" is the primary action and I want to click it.

Maybe we should add a "Read" or "Open" action as primary action that just does the same as clicking the notification: Open the updated sites.

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: Screenshot_20160408-194550.png

This is a screenshot from YouTube for reference.

From IRC: 
16:37:56 <•mfinkle> sebastian: "read" would be a nice action approach
16:38:13 <•mfinkle> "read" lets the user know an action is available
16:38:30 <•mfinkle> instead of just thinking "thanks for telling me" and swiping it away

@antlam: What do you think? Adding the option and then looking at telemetry should be quite simple.

Comment 2

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

I think this is a good idea. We should measure this and compare it with our current design (no action button).

How does this look? 

[ ] READ NOW   | [ ] SETTINGS

We can use the same icon for our notifications SETTINGS button (https://design.google.com/icons/#ic_notifications_off) and the "open in browser" icon for our READ NOW button (https://design.google.com/icons/#ic_open_in_browser)

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Sounds good. I'll create a patch and flag you for feedback.

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: content-notification-actions.png

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1259127 - Content notifications: Add "Read now" action. r=grisha

Review commit: https://reviewboard.mozilla.org/r/48983/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/48983/

Comment 6

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Comment on attachment 8745334 [details]
content-notification-actions.png

Nice! let's see how this affects things

Comment 7

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8745336 [details]
MozReview Request: Bug 1259127 - Content notifications: Add "Read now" action. r=grisha

I need to add telemetry for the "Read Now" button. I'll reflag you as soon as I have a new patch ready.

Comment 8

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8745336 [details]
MozReview Request: Bug 1259127 - Content notifications: Add "Read now" action. r=grisha

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/48983/diff/1-2/

Comment 9

[Sebastian Kaspari (:sebastian; :pocmo)]

(Build on top of the patches from bug 1267639)

Comment 10

[:Grisha Kruglov]

Comment on attachment 8745336 [details]
MozReview Request: Bug 1259127 - Content notifications: Add "Read now" action. r=grisha

https://reviewboard.mozilla.org/r/48983/#review46857

::: mobile/android/base/java/org/mozilla/gecko/feeds/ContentNotificationsDelegate.java:10
(Diff revision 2)
>  
>  package org.mozilla.gecko.feeds;
>  
>  import android.content.Intent;
>  import android.os.Bundle;
> +import android.support.v4.app.NotificationCompat;

Unused import

::: mobile/android/base/java/org/mozilla/gecko/feeds/ContentNotificationsDelegate.java:66
(Diff revision 2)
> -        Telemetry.sendUIEvent(TelemetryContract.Event.ACTION, TelemetryContract.Method.NOTIFICATION, "content_update");
>          Telemetry.sendUIEvent(TelemetryContract.Event.LOAD_URL, TelemetryContract.Method.INTENT, "content_update");
>  
> +        if (intent.getBooleanExtra(EXTRA_READ_BUTTON, false)) {
> +            // "READ NOW" button in notification was clicked
> +            Telemetry.sendUIEvent(TelemetryContract.Event.ACTION, TelemetryContract.Method.NOTIFICATION, "content_update_read_now");

Can we move "content_update_read_now" and "content_update" into constants? They're starting to be sprinkled all over the place.

Comment 11

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8745336 [details]
MozReview Request: Bug 1259127 - Content notifications: Add "Read now" action. r=grisha

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/48983/diff/2-3/

Comment 12

[Sebastian Kaspari (:sebastian; :pocmo)]

https://hg.mozilla.org/integration/fx-team/rev/3fc88e045b865c3a9c1deb1f90f7c0c92b167d9c
Bug 1259127 - Content notifications: Add "Read now" action. r=grisha

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3fc88e045b86

Comment 14

[Sorina Florean [:sflorean]]

Attachment: Screenshot_20160523-175116.png

Verified as fixed in build 49.0a1 (2016-05-23);
Device: Nexus 5 (Android 6.0.1).