Closed Bug 1259139 Opened 4 years ago Closed 3 years ago

record in telemetry the validity of the current engine's loadPathHash

Categories

(Firefox :: Search, defect, P2, major)

defect

Tracking

()

RESOLVED FIXED
Firefox 48
Tracking Status
firefox48 --- fixed

People

(Reporter: florian, Assigned: florian)

References

Details

(Whiteboard: hijacking, metrics [fxsearch])

Attachments

(2 files, 2 obsolete files)

In order to better understand how many users will see the search reset page implemented in bug 1203168, we would like to record data about whether the engines used as default engine have valid loadPathHash values. This should land at least one cycle before we land or pref-on the search reset page. This data will also help us to measure the impact of the search reset page after it has been shipped/enabled.
Attached patch WIP1 (obsolete) — Splinter Review
Not requesting review yet because I want to have a look at covering this with our tests.
Attached patch Patch v2 (obsolete) — Splinter Review
Try is green, requesting review. Requesting review for the code from Drew, and the data review from Benjamin (feel free to redirect).
Attachment #8734800 - Flags: review?(benjamin)
Attachment #8734800 - Flags: review?(adw)
Attachment #8733981 - Attachment is obsolete: true
Attachment #8734800 - Flags: review?(adw) → review+
Severity: normal → major
Priority: -- → P2
Whiteboard: hijacking, metrics [fxsearch]
Comment on attachment 8734800 [details] [diff] [review]
Patch v2

I don't see any changes to the docs or histograms.json. If you're making a data collection change it needs to be reflected in the docs.
Attachment #8734800 - Flags: review?(benjamin) → review-
Attached patch Patch v3Splinter Review
Updated environment.rst.
Attachment #8737777 - Flags: review?(benjamin)
Attachment #8734800 - Attachment is obsolete: true
Comment on attachment 8737777 [details] [diff] [review]
Patch v3

data-review=me

This will require a change to the main ping schema: please coordinate that with Georg.
Attachment #8737777 - Flags: review?(benjamin) → feedback+
(In reply to Benjamin Smedberg  [:bsmedberg] from comment #6)

> This will require a change to the main ping schema: please coordinate that
> with Georg.

I'm not exactly sure what "a change to the main ping schema" means, but I'm confident Georg will know what the next step is here.
Flags: needinfo?(gfritzsche)
Comment on attachment 8737777 [details] [diff] [review]
Patch v3

Review of attachment 8737777 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/docs/environment.rst
@@ +280,5 @@
>   [profile]/searchplugins/engine.xml
>   [distribution]/searchplugins/common/engine.xml
>   [other]/engine.xml
>  
> +- an ``origin`` property: the value will be ``default`` for engines that are built-in or from distribution partners, ``verified`` for user-installed engines with valid verification hashes, ``unverified`` for non-default engines without verification hash, and ``invalid`` for engines with broken verification hashes.

Please also add that property to the structure example above.
(In reply to Florian Quèze [:florian] [:flo] from comment #7)
> (In reply to Benjamin Smedberg  [:bsmedberg] from comment #6)
> 
> > This will require a change to the main ping schema: please coordinate that
> > with Georg.
> 
> I'm not exactly sure what "a change to the main ping schema" means, but I'm
> confident Georg will know what the next step is here.

I've added this to the schema in this PR:
https://github.com/mozilla-services/mozilla-pipeline-schemas/pull/6
Flags: needinfo?(gfritzsche)
https://hg.mozilla.org/mozilla-central/rev/419922c1f15f
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
You need to log in before you can comment on or make changes to this bug.