1259139 - record in telemetry the validity of the current engine's loadPathHash

Status: RESOLVED FIXED

(Firefox :: Search, defect, P2)

Description

[Florian Quèze [:florian]]

In order to better understand how many users will see the search reset page implemented in bug 1203168, we would like to record data about whether the engines used as default engine have valid loadPathHash values. This should land at least one cycle before we land or pref-on the search reset page. This data will also help us to measure the impact of the search reset page after it has been shipped/enabled.

Comment 1

[Florian Quèze [:florian]]

Attachment: WIP1

Not requesting review yet because I want to have a look at covering this with our tests.

Comment 2

[Florian Quèze [:florian]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f0935e5b1aea

Comment 3

[Florian Quèze [:florian]]

Attachment: Patch v2

Try is green, requesting review. Requesting review for the code from Drew, and the data review from Benjamin (feel free to redirect).

Comment 4

[Benjamin Smedberg]

Comment on attachment 8734800 [details] [diff] [review]
Patch v2

I don't see any changes to the docs or histograms.json. If you're making a data collection change it needs to be reflected in the docs.

Comment 5

[Florian Quèze [:florian]]

Attachment: Patch v3

Updated environment.rst.

Comment 6

[Benjamin Smedberg]

Comment on attachment 8737777 [details] [diff] [review]
Patch v3

data-review=me

This will require a change to the main ping schema: please coordinate that with Georg.

Comment 7

[Florian Quèze [:florian]]

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #6)

> This will require a change to the main ping schema: please coordinate that
> with Georg.

I'm not exactly sure what "a change to the main ping schema" means, but I'm confident Georg will know what the next step is here.

Comment 8

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8737777 [details] [diff] [review]
Patch v3

Review of attachment 8737777 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/docs/environment.rst
@@ +280,5 @@
>   [profile]/searchplugins/engine.xml
>   [distribution]/searchplugins/common/engine.xml
>   [other]/engine.xml
>  
> +- an ``origin`` property: the value will be ``default`` for engines that are built-in or from distribution partners, ``verified`` for user-installed engines with valid verification hashes, ``unverified`` for non-default engines without verification hash, and ``invalid`` for engines with broken verification hashes.

Please also add that property to the structure example above.

Comment 9

[Florian Quèze [:florian]]

Attachment: Patch v3.1

Comment 10

[Georg Fritzsche [:gfritzsche]]

(In reply to Florian Quèze [:florian] [:flo] from comment #7)
> (In reply to Benjamin Smedberg  [:bsmedberg] from comment #6)
> 
> > This will require a change to the main ping schema: please coordinate that
> > with Georg.
> 
> I'm not exactly sure what "a change to the main ping schema" means, but I'm
> confident Georg will know what the next step is here.

I've added this to the schema in this PR:
https://github.com/mozilla-services/mozilla-pipeline-schemas/pull/6

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/419922c1f15f

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/419922c1f15f