1259151 - When edit is blocked as spam, save the draft content

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Editing, enhancement)

Description

[John Whitlock [:jwhitlock]]

What problem would this feature solve?
======================================
When a valid contribution is blocked as spam, a staff member can submit it as ham, and the same content may now pass. If the content is stored as a draft, the original contributor may be able to successfully resubmit.

Who has this problem?
=====================
All contributors to MDN

How do you know that the users identified above have this problem?
==================================================================
There are currently many false positives, so many legitimate contributions are being rejected.

How are the users identified above solving this problem now?
============================================================
Some may be saving the content in a local file.

Do you have any suggestions for solving the problem? Please explain in detail.
==============================================================================
The existing draft-saving functionality should be triggered by the "blocked as spam" check, so that the edit is saved to local storage (or however draft edits are saved). When bug 1255609 ships, staff can submit these false positives as ham, and instruct the contributor to try again.

Is there anything else we should know?
======================================
Although bug 1255609 will make this useful, the work is not blocked by closing that bug.

Comment 1

[Stephanie Hobson [:shobson]]

I've got a PR in to give the user control over whether or not an edit identified as spam can be manually saved as a draft. I think explicit user control is useful here while this still solves gives them a tool to avoid losing work.

Comment 2

[MDN Team (:mdn-dev)]

Commit pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/2daa26e47a7f0d5c99ae90e084629aeb325f103c
Save draft improvements.

Fix Bug 1259151 - When edit is blocked as spam, save the draft content
Fix Bug 1259197 - Draft save notification does not appear on translation pages.
Fix Bug 1123616 - Allow to manually store a draft

- renamed page_buttons to support addition of draft button so no confusion over "save"
- moved localStorage checks around and abstracted a bit
- moved draft notifications to all be in one place above editor (and supporting HTML and CSS changes)
- added draft notification changes to translation pages

Testing:
- edit button (6x one each for en-US edit and new, non en-US edit and new, and a template edit and new)
- edit page title and properties still there
- no recovered draft, save draft button present but disabled
- type and click save button (in less than 3 seconds)
- local storage has correct content and save button disabled
- type and wait 3 seconds for auto save
- local storage has correct content
- hard refresh page
- report draft to restore and no save button
- restore draft
- restored correctly
- hard refresh
- draft to restore
- discard draft
- hard refresh
- no draft
- make new draft
- press discard button next to preview button
- return to edit page
- no draft
- create spam edit
- submit spam and be rejected
- no draft
- click draft save
- hard refresh
- restore draft sucessfully

Comment 3

[John Whitlock [:jwhitlock]]

Some issues were discovered in staging, and this didn't get all the way to production. Reopening until it is deployed.

Comment 4

[MDN Team (:mdn-dev)]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/93df785d167b61bdafbb909fd8ed8f762b48a90a
Bug 1259151: Restore draft regression fix

When a draft was detected the code was still autosaving over top of it. This fixes that and exposes the autosave process to the user in the UI.

https://github.com/mozilla/kuma/commit/bcb665f67ed689092c617e220f1d2dcb1959367a
Merge pull request #3832 from mozilla/1259151-save-spam-draft

Bug 1259151: Restore draft regression fix

Comment 5

[Stephanie Hobson [:shobson]]

Fixes made it to production.