Compact arenas containing scripts

RESOLVED FIXED in Firefox 48

Status

()

Core
JavaScript: GC
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jonco, Assigned: jonco)

Tracking

(Depends on: 1 bug, Blocks: 1 bug)

unspecified
mozilla48
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed)

Details

Attachments

(1 attachment)

Created attachment 8734035 [details] [diff] [review]
compact-scripts

Patch to compact scripts.

I changed the way BindingIter worked.  Previously this had a Handle<Bindings> embedded in it, which doesn't work when this is constructed for a script's bindings with fromMarkedLocation.  I made it copy the relevant parts of the binding, which don't change when we move the Bindings object.  Bindings::initTrivial also needed to take a handle to a script in case the call to getInitialShape moved the script.

I added fixup for the compartment's tables related to scripts and debugging, and tracing and table fixup to the SPS profiler.
Attachment #8734035 - Flags: review?(terrence)
Keywords: leave-open
Woops, wrong bug!
Keywords: leave-open
Attachment #8734035 - Flags: review?(terrence) → review+

Comment 3

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/002224165269
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Depends on: 1264635
Depends on: 1268083
Depends on: 1296649
Depends on: 1264980
You need to log in before you can comment on or make changes to this bug.