Closed
Bug 1259180
Opened 8 years ago
Closed 8 years ago
Compact arenas containing scripts
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
References
(Depends on 1 open bug, Blocks 1 open bug)
Details
Attachments
(1 file)
23.40 KB,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
Patch to compact scripts. I changed the way BindingIter worked. Previously this had a Handle<Bindings> embedded in it, which doesn't work when this is constructed for a script's bindings with fromMarkedLocation. I made it copy the relevant parts of the binding, which don't change when we move the Bindings object. Bindings::initTrivial also needed to take a handle to a script in case the call to getInitialShape moved the script. I added fixup for the compartment's tables related to scripts and debugging, and tracing and table fixup to the SPS profiler.
Attachment #8734035 -
Flags: review?(terrence)
Updated•8 years ago
|
Keywords: leave-open
Updated•8 years ago
|
Attachment #8734035 -
Flags: review?(terrence) → review+
Comment 3•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/002224165269
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•