If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Shouldn't have column picker in "Form Manager" dialogs (Forms Never Previewed/Forms Never Saved)

RESOLVED WORKSFORME

Status

()

Toolkit
Form Manager
P4
minor
RESOLVED WORKSFORME
16 years ago
9 years ago

People

(Reporter: Henrik Gemal, Assigned: dveditz)

Tracking

Trunk
x86
Windows 2000
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

16 years ago
We shouldn't have the column picker in "Form Manager" dialogs (Forms Never 
Previewed/Forms Never Saved). It's the dialog that gets shown when you select 
Tasks -> Privacy & Security -> Form Manager -> Manage Sites.

It makes no sense to have a column picker since there's only one column.

For a fix please see bug 120257 which was a bug about the same thing.
Basicly just add hidecolumnpicker="true"

the same goes for the Manage Sites dialogs in the Image Manager and Cookie 
Manager. Should I file seperate bugs about that?

20020213

Comment 1

16 years ago
Good suggestion.  And thanks for the reference of how to fix it up.

This is the same problem in the other dialogs you mention as well.  Since I 
own all of them, I'll handle them all at the same time so don't bother filling 
separate bugs.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.1

Updated

16 years ago
Priority: -- → P4
Target Milestone: mozilla1.1alpha → mozilla1.2beta

Updated

15 years ago
Target Milestone: mozilla1.2beta → mozilla1.3beta
This is a trivial thing to fix, please see this patch for sample:
http://bugzilla.mozilla.org/attachment.cgi?id=65514&action=view
Assignee: morse → dveditz
Severity: normal → minor
Status: ASSIGNED → NEW
Target Milestone: mozilla1.3beta → ---

Comment 3

14 years ago
Created attachment 139672 [details] [diff] [review]
patch

Does the same that was done in the preferences dialog at some point of time:
move the "Category" description from the column header to above the column.

Comment 4

14 years ago
Comment on attachment 139672 [details] [diff] [review]
patch

Requesting review from mvl.

I'm not 100% sure if you are an appropriate reviewer for this, but trying
doesn't cost a thing...
Attachment #139672 - Flags: review?(mvl)

Comment 5

14 years ago
Ha! I misread this bug! I'll extend the patch to that other dialog ("Manage
Sites")...
Or is that one a WONTFIX because you can click on the header and sort the list
this way?
I don't see a columnpicker in the dialogs, so i guess this is worksforme :)
morphing into another problem isn't a great idea in general, so if you really
don't want the header, file another bug. (but imho, there should be one. It is a
normal list, like the other managers, so should have a header. prefs was
somewhat special)

Comment 7

14 years ago
Comment on attachment 139672 [details] [diff] [review]
patch

Damn, I didn't misread this bug, I misread it TOTALLY!
Attachment #139672 - Flags: review?(mvl)

Comment 8

14 years ago
WFM
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → WORKSFORME

Updated

9 years ago
Component: Form Manager → Form Manager
Product: Core → Toolkit
QA Contact: tpreston → form.manager
You need to log in before you can comment on or make changes to this bug.