pulse_actions - Fix edge case bug

RESOLVED WONTFIX

Status

Testing
General
RESOLVED WONTFIX
2 years ago
11 months ago

People

(Reporter: armenzg, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
botond thanks for letting me know. The bug you hit needed the right timing to be hit. After a year since I wrote mozci I have now found good data to help me fix it!
-------

botond tried twice to add new jobs to this push [1]
Unfortunately they did not get scheduled.

From looking into pulse_actions logs, the first time it seems that the build job was still running (known problem that we can't fix atm) [2].

The second request hit a bug in mozci which is a new issue.
We try to catch a known issue by handling an exception, however, it is handled incorrectly [3][4]

This
> except buildjson.BuildjsonException:
should be this:
> except BuildjsonError:

Have to love dynamic languages.

Screnshot of currently running jobs:
http://people.mozilla.org/~armenzg/sattap/3bd708d3.png

Nit: fix also this silly bug [5]

There's also this long standing bug which I now have enough data to fix it.
The code was looking for request id 103057110, however, it should have been looking for build id 104183080.

In other words, this:
https://secure.pub.build.mozilla.org/buildapi/self-serve/try/build/104183080
or this:
https://secure.pub.build.mozilla.org/buildapi/self-serve/try/request/103057110
versus this:
https://secure.pub.build.mozilla.org/buildapi/self-serve/try/build/103057110 (404)

The request id 103057110 shows up as metadata of build 104183080.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=539ce0c92fc6&group_state=expanded
[2] https://github.com/mozilla/mozilla_ci_tools/blob/64ead7825e11ffbe14a22cecfbf12ee5188dca42/mozci/mozci.py#L182
[3] https://github.com/mozilla/mozilla_ci_tools/blob/64ead7825e11ffbe14a22cecfbf12ee5188dca42/mozci/mozci.py#L176
[4] https://github.com/mozilla/mozilla_ci_tools/blob/master/mozci/errors.py#L13
[5] https://github.com/mozilla/mozilla_ci_tools/blob/850bead7ba0323bb50a1833e50534e7e01956dfc/mozci/sources/buildjson.py#L169
(Reporter)

Comment 1

2 years ago
Created attachment 8734076 [details]
logs
Assignee: nobody → armenzg
Status: NEW → ASSIGNED
(Reporter)

Comment 2

2 years ago
I don't have the time to work on this now, however, we have the pieces to solve it when there's time.
Assignee: armenzg → nobody
Status: ASSIGNED → NEW
(Reporter)

Updated

2 years ago
Summary: pulse_actions fails to schedule jobs → pulse_actions - Fix edge case bug
(Reporter)

Comment 3

11 months ago
Shutting pulse_actions off (see bug 1379172).
Status: NEW → RESOLVED
Last Resolved: 11 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.