Closed
Bug 1259241
Opened 8 years ago
Closed 8 years ago
Update cxx_demangle library to 1.0.1
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect)
DevTools
Performance Tools (Profiler/Timeline)
Tracking
(firefox48 fixed)
RESOLVED
FIXED
Firefox 48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: jsantell, Assigned: jsantell)
Details
Attachments
(1 file)
1.15 KB,
patch
|
fitzgen
:
review+
|
Details | Diff | Splinter Review |
Latest change fixes a memory leak: https://github.com/kripken/cxx_demangle/pull/3
Assignee | ||
Comment 1•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=891fe5538aec
Attachment #8734116 -
Flags: review?(nfitzgerald)
Comment 2•8 years ago
|
||
Comment on attachment 8734116 [details] [diff] [review] 1259241-demangle-leak.patch Review of attachment 8734116 [details] [diff] [review]: ----------------------------------------------------------------- Aside: does the Frame component automatically use this? If not, can we make it do that?
Attachment #8734116 -
Flags: review?(nfitzgerald) → review+
Assignee | ||
Comment 3•8 years ago
|
||
Good call, that should be implemented. Bug 1259259
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/369022e5feeb
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•