1259248 - Add an ArrayView class

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

Attachment: array-view

This is a quick and dirty implementation so that we have something to iterate on.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: array-view

Comment 2

[Botond Ballo [:botond]]

Comment on attachment 8734132 [details] [diff] [review]
array-view

Review of attachment 8734132 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM as a first pass at a utility that we can start using right away. We should iterate on this (preferably matching the interface of one of the array_view-like classes being proposed for standardization) and move it to MFBT as a follow-up.

::: gfx/src/ArrayView.h
@@ +12,5 @@
> +
> +template<typename T>
> +class ArrayView
> +{
> +    public:

nits: use two-space identation, and access-specifiers don't get indented by an extra level

@@ +17,5 @@
> +        ArrayView(nsTArray<T>& aData) :
> +            mData(aData.Elements()), mLength(aData.Length())
> +        {
> +        }
> +        ArrayView(const T* aData, const size_t aLength) :

No need for the toplevel const on the second parameter

@@ +23,5 @@
> +        {
> +        }
> +        const T& operator[](const size_t aIdx) const
> +        {
> +            return mData[aIdx];

MOZ_ASSERT() that the index is in range

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d95bbecda3af

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5ed70dba80c6

Comment 5

[Nicolas Silva [:nical]]

Comment on attachment 8734132 [details] [diff] [review]
array-view

Review of attachment 8734132 [details] [diff] [review]:
-----------------------------------------------------------------

Isn't this more or less the same as mfbt's Range class? https://dxr.mozilla.org/mozilla-central/source/mfbt/Range.h

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d95bbecda3af
https://hg.mozilla.org/mozilla-central/rev/5ed70dba80c6

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/165538409c04

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/165538409c04