Add "Synced Tabs" feature to history panel

RESOLVED FIXED

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: bmunar, Assigned: bmunar)

Tracking

unspecified
Other
iOS
Dependency tree / graph

Firefox Tracking Flags

(fxios5.0+)

Details

Attachments

(1 attachment)

PR
48 bytes, text/x-github-pull-request
sleroux
: review+
bmunar
: ui-review?
tecgirl
sleroux
: feedback+
tecgirl
: feedback+
Details | Review | Splinter Review
(Assignee)

Description

2 years ago
1. Add "Synced Tabs" cell to history panel
2. Display the Remote Tabs panel data in this new page
(Assignee)

Updated

2 years ago
Blocks: 1250749
(Assignee)

Updated

2 years ago
Assignee: nobody → bmunar
(Assignee)

Updated

2 years ago
Status: NEW → ASSIGNED
tracking-fxios: --- → ?
(Assignee)

Comment 1

2 years ago
Created attachment 8745073 [details] [review]
PR

definitely not perfect, but did what I could. Whoever gets to it first (like always!), but also would like two eyes on it!
Attachment #8745073 - Flags: ui-review?(randersen)
Attachment #8745073 - Flags: review?(sleroux)
Attachment #8745073 - Flags: review?(bnicholson)
Comment on attachment 8745073 [details] [review]
PR

It's close! see http://c.tecgirl.com/fnl9

The Synced devices icon should center with the favicons, as well as the text labels, they should line up with the cells below. 

The default favicon letters are showing up fuzzy for me, how are these rendered?

On a 6s+, the top and left borders of the favicons appears to be 2px instead of 1.

The caret. It appears vertically stretched and is a different asset than used on Bookmarks. It looks close to what's in the mock, but is stretched. http://c.tecgirl.com/fneb
We need to unify this asset.
Comment on attachment 8745073 [details] [review]
PR

Left feedback on the PR. Good start!
Attachment #8745073 - Flags: feedback+
tracking-fxios: ? → 5.0+
Attachment #8745073 - Flags: feedback+
(Assignee)

Comment 4

2 years ago
Comment on attachment 8745073 [details] [review]
PR

round 2
Attachment #8745073 - Flags: review?(sleroux)
Attachment #8745073 - Flags: review?(sleroux)
Left more feedback on the PR.
Comment on attachment 8745073 [details] [review]
PR

Final round of nits but good to go!
Attachment #8745073 - Flags: review?(sleroux) → review+
(Assignee)

Comment 7

2 years ago
https://github.com/mozilla/firefox-ios/pull/1738/commits/82a90c988444d35916ab973d645adeea93d20535
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Attachment #8745073 - Flags: review?(bnicholson)

Updated

2 years ago
Depends on: 1272056
You need to log in before you can comment on or make changes to this bug.