Closed Bug 1259288 Opened 4 years ago Closed 4 years ago
Safe Browsing should be fully disabled in our test suites
58 bytes, text/x-review-board-request
I found that while the basic Safe Browsing functionality is disabled in these places, some of the new additions (tracking protection, forbidden sites) are missing: https://hg.mozilla.org/mozilla-central/file/6606ab35633b/testing/talos/talos/config.py#l110 https://dxr.mozilla.org/mozilla-central/rev/6202ade0e6d688ffb67932398e56cfc6fa04ceb3/layout/tools/reftest/reftest-preferences.js#83 https://dxr.mozilla.org/mozilla-central/rev/6202ade0e6d688ffb67932398e56cfc6fa04ceb3/js/src/tests/user.js#26-27 https://dxr.mozilla.org/mozilla-central/source/testing/marionette/client/marionette_driver/geckoinstance.py#205 This means that list updates could actually happen during theses tests.
Review commit: https://reviewboard.mozilla.org/r/42133/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/42133/
Attachment #8734201 - Flags: review?(gpascutto)
Comment on attachment 8734201 [details] MozReview Request: Bug 1259288 - Safe Browsing should be fully disabled in our test suites. r?gcp https://reviewboard.mozilla.org/r/42133/#review38703 I suppose some of those may be disabled anyway due to not setting the proper URLs.
Attachment #8734201 - Flags: review?(gpascutto) → review+
You need to log in before you can comment on or make changes to this bug.