1259288 - Safe Browsing should be fully disabled in our test suites

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[François Marier [:francois]]

I found that while the basic Safe Browsing functionality is disabled in these places, some of the new additions (tracking protection, forbidden sites) are missing:

https://hg.mozilla.org/mozilla-central/file/6606ab35633b/testing/talos/talos/config.py#l110
https://dxr.mozilla.org/mozilla-central/rev/6202ade0e6d688ffb67932398e56cfc6fa04ceb3/layout/tools/reftest/reftest-preferences.js#83
https://dxr.mozilla.org/mozilla-central/rev/6202ade0e6d688ffb67932398e56cfc6fa04ceb3/js/src/tests/user.js#26-27
https://dxr.mozilla.org/mozilla-central/source/testing/marionette/client/marionette_driver/geckoinstance.py#205

This means that list updates could actually happen during theses tests.

Comment 1

[François Marier [:francois]]

Attachment: MozReview Request: Bug 1259288 - Safe Browsing should be fully disabled in our test suites. r?gcp

Review commit: https://reviewboard.mozilla.org/r/42133/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/42133/

Comment 2

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 8734201 [details]
MozReview Request: Bug 1259288 - Safe Browsing should be fully disabled in our test suites. r?gcp

https://reviewboard.mozilla.org/r/42133/#review38703

I suppose some of those may be disabled anyway due to not setting the proper URLs.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9edb10202fd2

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9edb10202fd2