Closed Bug 1259294 Opened 8 years ago Closed 8 years ago

Add MOZ_ALWAYS_SUCCEEDS(rv)

Categories

(Core :: XPCOM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: khuey, Assigned: khuey)

Details

Attachments

(2 files)

Attached patch Part 1: Add itSplinter Review
Because who wants to type MOZ_ALWAYS_TRUE(NS_SUCCEEDED(rv))?
Attachment #8734202 - Flags: review?(nfroyd)
Attached patch Part 2: Use itSplinter Review
This is all trivial replacement.
Attachment #8734203 - Flags: review?(nfroyd)
Comment on attachment 8734202 [details] [diff] [review]
Part 1: Add it

Review of attachment 8734202 [details] [diff] [review]:
-----------------------------------------------------------------

I kinda feel like this should be NS_ALWAYS_SUCCEEDS, given that it's all about nsresult and whatnot, but meh.
Attachment #8734202 - Flags: review?(nfroyd) → review+
And ignore the bit where I somehow blew up nsILoadInfo.idl, that's fixed locally.
Comment on attachment 8734203 [details] [diff] [review]
Part 2: Use it

Review of attachment 8734203 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nsILoadInfo.idl restored to some semblance of working.

::: netwerk/base/nsILoadInfo.idl
@@ -1,5 @@
> -/* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*-
> - * vim: ft=cpp tw=78 sw=2 et ts=2 sts=2 cin
> - * This Source Code Form is subject to the terms of the Mozilla Public
> - * License, v. 2.0. If a copy of the MPL was not distributed with this
> - * file, You can obtain one at http://mozilla.org/MPL/2.0/. */

I feel like you did not mean to delete all this.
Attachment #8734203 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/mozilla-central/rev/932e732dedfe
https://hg.mozilla.org/mozilla-central/rev/af8611a7b88c
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.