Closed Bug 1259299 Opened 4 years ago Closed 4 years ago
waterfall-breakdown is not displayed after recordings are cleared and recording performance again
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:48.0) Gecko/20100101 Firefox/48.0 Build ID: 20160323030400 Steps to reproduce: 1. Start Nightly 2. Go to any sites (e.g. about:home) 3. Open Devtools > Performance 4. Start recording performance, and stop recording when something markers appear (waterfall-breakdown is displayed) 5. Click the Clear button 6. Start recording performance, and stop recording when something markers appear (waterfall-breakdown is not displayed) Actual results: waterfall-breakdown is not displayed even if marker is in recording. Regression range: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f14898695ee0dd14615914f3e1401f17df57fdd7&tochange=3587b25bae302c1eed72968dbd7cef883e715948 Expected results: waterfall-breakdown should display if marker is in recording.
I am a waiting reply.
This definitely looks strange -- thanks for the report and regression range! Pinging Greg on this, he's the point person on performance tools
Flags: needinfo?(jsantell) → needinfo?(gtatum)
Thanks magicp, I'll check this out.
Assignee: nobody → gtatum
The issue is that the markers are being cached in a weakmap, and that cache is set any time the WaterfallView.render() method is being called. This can cause incomplete lists of markers to be cached. This bug can also happen during a resize of the panel during a recording. I added a check to see if the recording is actively recording.
Victor, jsantell suggested I hit you up on this for review. He said: > 14:51 <jsantell> i think it has something to do with this patch https://hg.mozilla.org/integration/fx-team/rev/3810206dc61f > 14:51 <jsantell> i think your patch may fix the issue but could break an assumption somewhere else > 14:51 <jsantell> maybe victor would be a better reviewer :\
Attachment #8741087 - Flags: review?(vporof) → review+
Updating the reviewer on the patch.
Attachment #8741087 - Attachment is obsolete: true
I have reproduced this bug with Nightly 48.0a1 (2016-03-23) on Windows 7, 64 Bit! The Bug's fix is verified on Latest Beta 48.0b9. Build ID 20160718142219 User Agent Mozilla/5.0 (Windows NT 6.1; WOW64; rv:48.0) Gecko/20100101 Firefox/48.0
QA Whiteboard: [testday-20160722]
You need to log in before you can comment on or make changes to this bug.