Closed
Bug 1259299
Opened 8 years ago
Closed 8 years ago
waterfall-breakdown is not displayed after recordings are cleared and recording performance again
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect, P1)
DevTools
Performance Tools (Profiler/Timeline)
Tracking
(firefox47 unaffected, firefox48 fixed)
RESOLVED
FIXED
Firefox 48
Tracking | Status | |
---|---|---|
firefox47 | --- | unaffected |
firefox48 | --- | fixed |
People
(Reporter: magicp.jp, Assigned: gregtatum)
Details
Attachments
(2 files, 1 obsolete file)
642.46 KB,
video/mp4
|
Details | |
1.15 KB,
patch
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:48.0) Gecko/20100101 Firefox/48.0 Build ID: 20160323030400 Steps to reproduce: 1. Start Nightly 2. Go to any sites (e.g. about:home) 3. Open Devtools > Performance 4. Start recording performance, and stop recording when something markers appear (waterfall-breakdown is displayed) 5. Click the Clear button 6. Start recording performance, and stop recording when something markers appear (waterfall-breakdown is not displayed) Actual results: waterfall-breakdown is not displayed even if marker is in recording. Regression range: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f14898695ee0dd14615914f3e1401f17df57fdd7&tochange=3587b25bae302c1eed72968dbd7cef883e715948 Expected results: waterfall-breakdown should display if marker is in recording.
Has Regression Range: --- → yes
Has STR: --- → yes
status-firefox47:
--- → unaffected
status-firefox48:
--- → affected
Component: Untriaged → Developer Tools: Performance Tools (Profiler/Timeline)
Flags: needinfo?(vporof)
OS: Unspecified → All
Hardware: Unspecified → All
Regression range: https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=ae45c837f71ff925e848bb7f44353681a581207f&tochange=8bcc1369627e4017fc5adcd3284ecf330909ffa1
Comment 3•8 years ago
|
||
This definitely looks strange -- thanks for the report and regression range! Pinging Greg on this, he's the point person on performance tools
Flags: needinfo?(jsantell) → needinfo?(gtatum)
Assignee | ||
Comment 4•8 years ago
|
||
Thanks magicp, I'll check this out.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → gtatum
Flags: needinfo?(gtatum)
Assignee | ||
Updated•8 years ago
|
Priority: -- → P1
Assignee | ||
Comment 5•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fcbe21781474
Assignee | ||
Comment 6•8 years ago
|
||
The issue is that the markers are being cached in a weakmap, and that cache is set any time the WaterfallView.render() method is being called. This can cause incomplete lists of markers to be cached. This bug can also happen during a resize of the panel during a recording. I added a check to see if the recording is actively recording.
Assignee | ||
Updated•8 years ago
|
Attachment #8741087 -
Flags: review?(vporof)
Assignee | ||
Comment 7•8 years ago
|
||
Victor, jsantell suggested I hit you up on this for review. He said:
> 14:51 <jsantell> i think it has something to do with this patch https://hg.mozilla.org/integration/fx-team/rev/3810206dc61f
> 14:51 <jsantell> i think your patch may fix the issue but could break an assumption somewhere else
> 14:51 <jsantell> maybe victor would be a better reviewer :\
Updated•8 years ago
|
Attachment #8741087 -
Flags: review?(vporof) → review+
Assignee | ||
Comment 8•8 years ago
|
||
Updating the reviewer on the patch.
Assignee | ||
Updated•8 years ago
|
Attachment #8741087 -
Attachment is obsolete: true
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 10•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/95970ed646ea
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Comment 11•8 years ago
|
||
I have reproduced this bug with Nightly 48.0a1 (2016-03-23) on Windows 7, 64 Bit! The Bug's fix is verified on Latest Beta 48.0b9. Build ID 20160718142219 User Agent Mozilla/5.0 (Windows NT 6.1; WOW64; rv:48.0) Gecko/20100101 Firefox/48.0
QA Whiteboard: [testday-20160722]
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•