Closed
Bug 1259301
Opened 8 years ago
Closed 8 years ago
Remove GeckoContentController::RequestFlingSnap
Categories
(Core :: Panning and Zooming, defect)
Core
Panning and Zooming
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: botond, Assigned: botond)
References
Details
(Keywords: arch, Whiteboard: [gfx-noted])
Attachments
(1 file)
This is no longer used now that we ship snap points to the compositor (bug 1219296).
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → botond
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/43359/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/43359/
Attachment #8736536 -
Flags: review?(bugmail.mozilla)
Assignee | ||
Comment 2•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=208fda7538d1
Comment 3•8 years ago
|
||
Comment on attachment 8736536 [details] MozReview Request: Bug 1259301 - Remove GeckoContentController::RequestFlingSnap(). r=kats https://reviewboard.mozilla.org/r/43359/#review40063 We should be also able to remove the code that I added in bug 1141884 part 2 (IsScrollFrameWithSnapping and friends).
Attachment #8736536 -
Flags: review?(bugmail.mozilla) → review+
Assignee | ||
Comment 4•8 years ago
|
||
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #3) > We should be also able to remove the code that I added in bug 1141884 part 2 > (IsScrollFrameWithSnapping and friends). I think we need bug 1259296 to be fixed first; I can remove it as part of that bug.
Comment 5•8 years ago
|
||
Ah, true. Thanks!
Assignee | ||
Comment 6•8 years ago
|
||
Comment on attachment 8736536 [details] MozReview Request: Bug 1259301 - Remove GeckoContentController::RequestFlingSnap(). r=kats Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43359/diff/1-2/
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/23b389d50a0b
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•