Closed Bug 1259321 Opened 4 years ago Closed 4 years ago

Remove AnimationNode test from web platform tests.

Categories

(Core :: DOM: Animation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: mantaroh, Assigned: mantaroh)

Details

Attachments

(1 file, 3 obsolete files)

There are AnimationNode test in web platform test in spite of there are not exist on w3c specification.
The animation node has been changed in the previous revision[1].

[1] https://www.w3.org/TR/2015/WD-web-animations-1-20150707/#changes-since-last-publication
Removed from web platform tests.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4e4bd5cf25a3
Assignee: nobody → mantaroh
Status: NEW → ASSIGNED
Comment on attachment 8734234 [details] [diff] [review]
Remove animation node test from web platform tests.

Hi brian.

Could you please confirm this patch?
Attachment #8734234 - Flags: review?(bbirtles)
Comment on attachment 8734234 [details] [diff] [review]
Remove animation node test from web platform tests.

Review of attachment 8734234 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Can we also get rid of the following from testcommon.js that are no longer used:

* KEYFRAMES
* ANIMATION_TOP_*
* newAnimation()
* type()

r=me with those extra parts removed
Attachment #8734234 - Flags: review?(bbirtles) → review+
Attachment #8734234 - Attachment is obsolete: true
Sorry, Previous patch was wrong attachment file.
I removed the unnecessary function.

Could you please confirm it?
Attachment #8735271 - Attachment is obsolete: true
Attachment #8735326 - Flags: review?(bbirtles)
Attachment #8735326 - Flags: review?(bbirtles) → review+
Keywords: checkin-needed
hi, this fails to apply:

applying bug1259321.patch
patching file testing/web-platform/meta/MANIFEST.json
Hunk #1 FAILED at 28404
1 out of 1 hunks FAILED -- saving rejects to file testing/web-platform/meta/MANIFEST.json.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh bug1259321.patch
Flags: needinfo?(mantaroh)
Thanks Tomcat.

(In reply to Carsten Book [:Tomcat] from comment #6)
> hi, this fails to apply:
> 
> applying bug1259321.patch
> patching file testing/web-platform/meta/MANIFEST.json
> Hunk #1 FAILED at 28404
> 1 out of 1 hunks FAILED -- saving rejects to file
> testing/web-platform/meta/MANIFEST.json.rej
> patch failed, unable to continue (try -v)
> patch failed, rejects left in working directory
> errors during apply, please fix and qrefresh bug1259321.patch
Sorry, I rebased the patch.
Carrying forward r+ from birtles.
Attachment #8735326 - Attachment is obsolete: true
Flags: needinfo?(mantaroh)
Attachment #8736062 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/202e3131cadb
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.