Open
Bug 1259355
Opened 8 years ago
Updated 2 years ago
Practice MozReview for the first time use.
Categories
(Core :: General, defect)
Tracking
()
NEW
People
(Reporter: daoshengmu, Unassigned)
Details
Attachments
(16 files, 28 obsolete files)
58 bytes,
text/x-review-board-request
|
daoshengmu
:
review+
kikuo
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
kikuo
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
Details | |
58 bytes,
text/x-review-board-request
|
Details | |
58 bytes,
text/x-review-board-request
|
kechen
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
kikuo
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
Details | |
58 bytes,
text/x-review-board-request
|
Details | |
4.34 KB,
patch
|
Details | Diff | Splinter Review | |
58 bytes,
text/x-review-board-request
|
daoshengmu
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
kikuo
:
review-
|
Details |
58 bytes,
text/x-review-board-request
|
Details | |
58 bytes,
text/x-review-board-request
|
Details | |
58 bytes,
text/x-review-board-request
|
Details | |
59 bytes,
text/x-review-board-request
|
kechen
:
review+
kechen
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
chunmin
:
review+
|
Details |
Practice MozReview
Reporter | ||
Comment 1•8 years ago
|
||
Just practice it. Don't land!; r?JamesCheng Review commit: https://reviewboard.mozilla.org/r/42153/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/42153/
Comment 2•8 years ago
|
||
Good bug! Please add lots of comments to help others trying to learn MozReview.
Comment 3•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/42157/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/42157/
Attachment #8734297 -
Flags: review?(dmu)
Reporter | ||
Comment 4•8 years ago
|
||
Comment on attachment 8734297 [details] MozReview Request: Bug 1259355 - add god's name; r?kikuo https://reviewboard.mozilla.org/r/42157/#review38719 OK!
Attachment #8734297 -
Flags: review?(dmu)
Reporter | ||
Comment 5•8 years ago
|
||
Comment on attachment 8734297 [details] MozReview Request: Bug 1259355 - add god's name; r?kikuo https://reviewboard.mozilla.org/r/42157/#review38721
Attachment #8734297 -
Flags: review+
Reporter | ||
Updated•8 years ago
|
Attachment #8734267 -
Attachment description: MozReview Request: Bug 1259355 - Practice MozReview for the first time use. → MozReview Request: Bug 1259355 - Practice! Don't load it; r?JamesCheng
Attachment #8734267 -
Flags: review?(jacheng)
Reporter | ||
Comment 6•8 years ago
|
||
Comment on attachment 8734267 [details] Bug 1259355 - Try to commit single patch-2; Review request updated; see interdiff: https://reviewboard.mozilla.org/r/42153/diff/1-2/
Reporter | ||
Comment 7•8 years ago
|
||
Comment on attachment 8734267 [details] Bug 1259355 - Try to commit single patch-2; Review request updated; see interdiff: https://reviewboard.mozilla.org/r/42153/diff/2-3/
Attachment #8734267 -
Attachment description: MozReview Request: Bug 1259355 - Practice! Don't load it; r?JamesCheng → MozReview Request: Bug 1259355 - Practice! Don't load it#01; r?JamesCheng
Reporter | ||
Comment 8•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/42163/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/42163/
Attachment #8734308 -
Flags: review?(jacheng)
Reporter | ||
Comment 9•8 years ago
|
||
Comment on attachment 8734308 [details] MozReview Request: Bug 1259355 - Practice! Don't load it#02-1; r?JamesCheng Review request updated; see interdiff: https://reviewboard.mozilla.org/r/42163/diff/1-2/
Reporter | ||
Comment 10•8 years ago
|
||
Comment on attachment 8734308 [details] MozReview Request: Bug 1259355 - Practice! Don't load it#02-1; r?JamesCheng Review request updated; see interdiff: https://reviewboard.mozilla.org/r/42163/diff/2-3/
Attachment #8734308 -
Attachment description: MozReview Request: Bug 1259355 - Practice! Don't load it#02; r?JamesCheng → MozReview Request: Bug 1259355 - Practice! Don't load it#02-1; r?JamesCheng
Comment 11•8 years ago
|
||
Comment on attachment 8734297 [details] MozReview Request: Bug 1259355 - add god's name; r?kikuo Review request updated; see interdiff: https://reviewboard.mozilla.org/r/42157/diff/1-2/
Comment 12•8 years ago
|
||
Add dummy html Review commit: https://reviewboard.mozilla.org/r/42167/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/42167/
Comment 13•8 years ago
|
||
(In reply to Kilik Kuo [:kikuo][:kilikkuo] from comment #12) > Created attachment 8734315 [details] > MozReview Request: Bug 1259355 - Practice MozReview for the first time use; > r=?dmu although I tried to re-push with |r?dmu|, but the system still said "unrecognized reviewer". Should be "daoshengmu" I don't know why ? how to find the correct reviewer's name ? Is it configured in ./hgrc ? > > Add dummy html > > Review commit: https://reviewboard.mozilla.org/r/42167/diff/#index_header > See other reviews: https://reviewboard.mozilla.org/r/42167/
Flags: needinfo?(dmu)
Comment 14•8 years ago
|
||
(In reply to Kilik Kuo [:kikuo][:kilikkuo] from comment #13) > (In reply to Kilik Kuo [:kikuo][:kilikkuo] from comment #12) > > Created attachment 8734315 [details] > > MozReview Request: Bug 1259355 - Practice MozReview for the first time use; > > r=?dmu > > although I tried to re-push with |r?dmu|, but the system still said > "unrecognized reviewer". > Should be "daoshengmu" 1 clue is the read [1], which indicates that the name of reviewer should be the his name on bugizlla. [1] http://mozilla-version-control-tools.readthedocs.org/en/latest/mozreview/bugzilla.html#shared-user-database-and-authentication > I don't know why ? how to find the correct reviewer's name ? Is it > configured in ./hgrc ? > > > > > > Add dummy html > > > > Review commit: https://reviewboard.mozilla.org/r/42167/diff/#index_header > > See other reviews: https://reviewboard.mozilla.org/r/42167/
Flags: needinfo?(dmu)
Updated•8 years ago
|
Attachment #8734315 -
Attachment is obsolete: true
Comment 15•8 years ago
|
||
Add dummy html Review commit: https://reviewboard.mozilla.org/r/42171/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/42171/
Attachment #8734326 -
Flags: review?(dmu)
Reporter | ||
Comment 16•8 years ago
|
||
(In reply to Daosheng Mu[:daoshengmu] from comment #1) > Created attachment 8734267 [details] > MozReview Request: Bug 1259355 - Practice! Don't load it#01; r?JamesCheng > > Just practice it. Don't land!; r?JamesCheng > > Review commit: https://reviewboard.mozilla.org/r/42153/diff/#index_header > See other reviews: https://reviewboard.mozilla.org/r/42153/ The commit message for mozreview needs to follow this format, "Bug ID - xxxxx your message xxxxx; r?reviewer". Notice: don't put a new line between your message and the reviewer. Otherwise, mozreview could not catch the reviewer id.
Updated•8 years ago
|
Attachment #8734267 -
Flags: review?(jacheng) → review+
Comment 17•8 years ago
|
||
Comment on attachment 8734267 [details] Bug 1259355 - Try to commit single patch-2; https://reviewboard.mozilla.org/r/42153/#review38765 how to use r-?
Comment 18•8 years ago
|
||
Comment on attachment 8734308 [details] MozReview Request: Bug 1259355 - Practice! Don't load it#02-1; r?JamesCheng https://reviewboard.mozilla.org/r/42163/#review38767
Attachment #8734308 -
Flags: review?(jacheng)
Comment 19•8 years ago
|
||
Comment on attachment 8734308 [details] MozReview Request: Bug 1259355 - Practice! Don't load it#02-1; r?JamesCheng https://reviewboard.mozilla.org/r/42163/#review38769
Attachment #8734308 -
Flags: review+
Reporter | ||
Comment 20•8 years ago
|
||
(In reply to Kilik Kuo [:kikuo] from comment #13) > (In reply to Kilik Kuo [:kikuo][:kilikkuo] from comment #12) > > Created attachment 8734315 [details] > > MozReview Request: Bug 1259355 - Practice MozReview for the first time use; > > r=?dmu > > although I tried to re-push with |r?dmu|, but the system still said > "unrecognized reviewer". > Should be "daoshengmu" > I don't know why ? how to find the correct reviewer's name ? Is it > configured in ./hgrc ? > > > > > > Add dummy html > > > > Review commit: https://reviewboard.mozilla.org/r/42167/diff/#index_header > > See other reviews: https://reviewboard.mozilla.org/r/42167/ My bugzilla id is daoshengmu. It might be an inconvenient point for someone who doesn't know the reviewer's id.
Reporter | ||
Updated•8 years ago
|
Attachment #8734326 -
Flags: review?(dmu)
Reporter | ||
Comment 22•8 years ago
|
||
Comment on attachment 8734326 [details] MozReview Request: Bug 1259355 - Practice MozReview for the first time use.; r=daoshengmu https://reviewboard.mozilla.org/r/42171/#review38915 Try to know how to make r-
Reporter | ||
Comment 23•8 years ago
|
||
(In reply to James Cheng[:JamesCheng] from comment #17) > Comment on attachment 8734267 [details] > MozReview Request: Bug 1259355 - Practice! Don't load it#01; r?JamesCheng > > https://reviewboard.mozilla.org/r/42153/#review38765 > > how to use r-? I don't know as well. It seems to just can cancel the review?
Comment 24•8 years ago
|
||
(In reply to Daosheng Mu[:daoshengmu] from comment #23) > (In reply to James Cheng[:JamesCheng] from comment #17) > > Comment on attachment 8734267 [details] > > MozReview Request: Bug 1259355 - Practice! Don't load it#01; r?JamesCheng > > > > https://reviewboard.mozilla.org/r/42153/#review38765 > > > > how to use r-? > > I don't know as well. It seems to just can cancel the review? S.C said he do r- manually by bugzilla.
Reporter | ||
Comment 25•8 years ago
|
||
Comment on attachment 8734326 [details] MozReview Request: Bug 1259355 - Practice MozReview for the first time use.; r=daoshengmu Understand how to make r-
Attachment #8734326 -
Flags: review-
Comment 26•8 years ago
|
||
Comment on attachment 8734267 [details] Bug 1259355 - Try to commit single patch-2; test r-
Attachment #8734267 -
Flags: review+ → review-
Comment 27•8 years ago
|
||
https://reviewboard.mozilla.org/r/42171/#review38915 [r-'ing is still something that we're attempting to support with MozReview.](https://bugzilla.mozilla.org/show_bug.cgi?id=1197879) Hopefully not long now!
Comment 28•8 years ago
|
||
Comment on attachment 8734326 [details] MozReview Request: Bug 1259355 - Practice MozReview for the first time use.; r=daoshengmu Review request updated; see interdiff: https://reviewboard.mozilla.org/r/42171/diff/1-2/
Attachment #8734326 -
Flags: review- → review?(dmu)
Reporter | ||
Comment 29•8 years ago
|
||
https://reviewboard.mozilla.org/r/42171/#review38915 Thanks for your info
Reporter | ||
Comment 30•8 years ago
|
||
Comment on attachment 8734326 [details] MozReview Request: Bug 1259355 - Practice MozReview for the first time use.; r=daoshengmu https://reviewboard.mozilla.org/r/42171/#review39173
Attachment #8734326 -
Flags: review?(dmu) → review+
Comment 31•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/42769/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/42769/
Attachment #8735410 -
Flags: review?(kuoe0)
Comment 32•8 years ago
|
||
Comment on attachment 8735410 [details] MozReview Request: Bug 1259355 - Practice MozReview; r?KuoE0 https://reviewboard.mozilla.org/r/42769/#review39189 >< ::: browser/base/content/content.js:26 (Diff revision 1) > XPCOMUtils.defineLazyModuleGetter(this, "ContentLinkHandler", > "resource:///modules/ContentLinkHandler.jsm"); > XPCOMUtils.defineLazyModuleGetter(this, "LoginManagerContent", > "resource://gre/modules/LoginManagerContent.jsm"); > +XPCOMUtils.defineLazyModuleGetter(this, "FormLikeFactory", > + "resource://gre/modules/LoginManagerContent.jsm"); LGTM
Attachment #8735410 -
Flags: review?(kuoe0)
Comment 33•8 years ago
|
||
Comment on attachment 8734326 [details] MozReview Request: Bug 1259355 - Practice MozReview for the first time use.; r=daoshengmu Review request updated; see interdiff: https://reviewboard.mozilla.org/r/42171/diff/2-3/
Attachment #8734326 -
Attachment description: MozReview Request: Bug 1259355 - Practice MozReview for the first time use.; r?daoshengmu → MozReview Request: Bug 1259355 - Practice MozReview for the first time use.; r=daoshengmu
Reporter | ||
Comment 34•8 years ago
|
||
Comment on attachment 8734326 [details] MozReview Request: Bug 1259355 - Practice MozReview for the first time use.; r=daoshengmu https://reviewboard.mozilla.org/r/42171/#review40267
Attachment #8734326 -
Flags: review+
Comment 35•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/43775/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/43775/
Comment 36•8 years ago
|
||
Comment on attachment 8734326 [details] MozReview Request: Bug 1259355 - Practice MozReview for the first time use.; r=daoshengmu https://reviewboard.mozilla.org/r/42171/#review40581 r+ won't be carried by setting r? to r=. Check "Ship It" by myself in FinishReview tab.
Attachment #8734326 -
Flags: review+
Comment 37•8 years ago
|
||
https://reviewboard.mozilla.org/r/42171/#review39173 Don't know why there's not a r+ after you checked ship it @@ ?
Comment 38•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/44483/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/44483/
Attachment #8738388 -
Flags: review?(dmu)
Updated•8 years ago
|
Attachment #8738388 -
Attachment is obsolete: true
Attachment #8738388 -
Flags: review?(dmu)
Comment 39•8 years ago
|
||
Comment on attachment 8734297 [details] MozReview Request: Bug 1259355 - add god's name; r?kikuo Review request updated; see interdiff: https://reviewboard.mozilla.org/r/42157/diff/2-3/
Attachment #8734297 -
Attachment description: MozReview Request: Bug 1259355 - Add name; r?daoshengmu → MozReview Request: Bug 1259355 - add god's name; r?kikuo
Attachment #8734297 -
Flags: review?(kikuo)
Comment 40•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/44975/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/44975/
Attachment #8738951 -
Flags: review?(jacheng)
Comment 41•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/44987/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/44987/
Attachment #8738953 -
Flags: review?(kechen)
Attachment #8738953 -
Flags: review?(dmu)
Comment 42•8 years ago
|
||
Comment on attachment 8738953 [details]
Bug-1259355 Test
Forward to yourself.
Attachment #8738953 -
Flags: review?(jacheng)
Comment 43•8 years ago
|
||
Comment on attachment 8738953 [details] Bug-1259355 Test https://reviewboard.mozilla.org/r/44987/#review41513 Test for not shipping it
Attachment #8738953 -
Flags: review?(kechen)
Comment 44•8 years ago
|
||
Comment on attachment 8738951 [details] Bug 1259355 - Test22; Review request updated; see interdiff: https://reviewboard.mozilla.org/r/44975/diff/1-2/
Attachment #8738951 -
Attachment description: MozReview Request: Bug 1259355 - Practice MozReview for the first time use. r?JamesCheng → MozReview Request: Bug 1259355 - Practice MozReview for the first time use. r?kechen
Attachment #8738951 -
Flags: review?(jacheng) → review?(kechen)
Reporter | ||
Updated•8 years ago
|
Attachment #8738953 -
Flags: review?(dmu) → review+
Reporter | ||
Comment 45•8 years ago
|
||
Comment on attachment 8738953 [details] Bug-1259355 Test https://reviewboard.mozilla.org/r/44987/#review41647 Good but don't ship it
Comment 46•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/45177/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/45177/
Comment 47•8 years ago
|
||
Comment on attachment 8739288 [details] MozReview Request: Bug 1259355 - Test push again. r?kechen Review request updated; see interdiff: https://reviewboard.mozilla.org/r/45177/diff/1-2/
Attachment #8738953 -
Attachment description: MozReview Request: Bug 1259355 - Test mozreview. r?kechen, daoshengmu → MozReview Request: Bug 1259355 - Test mozreview. r?kechen, kikuo
Attachment #8738953 -
Flags: review?(kikuo)
Attachment #8738953 -
Flags: review?(kechen)
Attachment #8738953 -
Flags: review?(jacheng)
Comment 48•8 years ago
|
||
Comment on attachment 8738953 [details] Bug-1259355 Test Review request updated; see interdiff: https://reviewboard.mozilla.org/r/44987/diff/1-2/
Comment 49•8 years ago
|
||
Comment on attachment 8739288 [details] MozReview Request: Bug 1259355 - Test push again. r?kechen Review request updated; see interdiff: https://reviewboard.mozilla.org/r/45177/diff/2-3/
Attachment #8739288 -
Attachment description: MozReview Request: no related commit → MozReview Request: Bug 1259355 - Test push again. r?kechen
Attachment #8738953 -
Attachment description: MozReview Request: Bug 1259355 - Test mozreview. r?kechen, kikuo → MozReview Request: dummy
Attachment #8739288 -
Flags: review?(kechen)
Comment 50•8 years ago
|
||
Comment on attachment 8738953 [details] Bug-1259355 Test Review request updated; see interdiff: https://reviewboard.mozilla.org/r/44987/diff/2-3/
Updated•8 years ago
|
Attachment #8739288 -
Flags: review?(kechen)
Updated•8 years ago
|
Attachment #8738953 -
Flags: review?(kikuo)
Attachment #8738953 -
Flags: review?(kechen)
Attachment #8738953 -
Flags: review+
Updated•8 years ago
|
Attachment #8738953 -
Attachment is obsolete: true
Updated•8 years ago
|
Attachment #8739288 -
Attachment is obsolete: true
Comment 51•8 years ago
|
||
Comment on attachment 8739288 [details] MozReview Request: Bug 1259355 - Test push again. r?kechen https://reviewboard.mozilla.org/r/45177/#review41653
Attachment #8739288 -
Flags: review+
Comment 52•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/45179/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/45179/
Attachment #8738953 -
Attachment description: MozReview Request: dummy → MozReview Request: Bug 1259355 - Dummy 1. r?kechen
Attachment #8738953 -
Attachment is obsolete: false
Attachment #8739293 -
Flags: review?(kechen)
Attachment #8738953 -
Flags: review?(kechen)
Comment 53•8 years ago
|
||
Comment on attachment 8738953 [details] Bug-1259355 Test Review request updated; see interdiff: https://reviewboard.mozilla.org/r/44987/diff/3-4/
Comment 54•8 years ago
|
||
Comment on attachment 8738953 [details] Bug-1259355 Test Review request updated; see interdiff: https://reviewboard.mozilla.org/r/44987/diff/4-5/
Updated•8 years ago
|
Attachment #8739293 -
Attachment is obsolete: true
Attachment #8739293 -
Flags: review?(kechen)
Comment 55•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/45181/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/45181/
Attachment #8739295 -
Flags: review?(kechen)
Comment 56•8 years ago
|
||
Comment on attachment 8738953 [details] Bug-1259355 Test Review request updated; see interdiff: https://reviewboard.mozilla.org/r/44987/diff/5-6/
Updated•8 years ago
|
Attachment #8739295 -
Attachment is obsolete: true
Attachment #8739295 -
Flags: review?(kechen)
Comment 57•8 years ago
|
||
Comment on attachment 8738953 [details] Bug-1259355 Test Review request updated; see interdiff: https://reviewboard.mozilla.org/r/44987/diff/6-7/
Attachment #8738953 -
Attachment description: MozReview Request: Bug 1259355 - Dummy 1. r?kechen → MozReview Request: Bug 1259355 - Test. r=?kechen
Updated•8 years ago
|
Attachment #8738953 -
Flags: review?(kechen)
Comment 58•8 years ago
|
||
Comment on attachment 8738953 [details] Bug-1259355 Test https://reviewboard.mozilla.org/r/44987/#review41665 Fix it ::: xpcom/glue/ezlogger.h:26 (Diff revision 7) > + ToVector(const Type* aData, LengthType aLength) -> std::vector<Type> > + { > + std::vector<Type> vec; > + std::copy(aData, aData + aLength, std::back_inserter(vec)); > + return vec; > + } cool ::: xpcom/glue/ezlogger.h:53 (Diff revision 7) > + oss << std::setfill('0') << std::setw(2) << std::hex << static_cast<unsigned int>(bin[i]); > + } > + return oss.str(); > + } > + > + std::string bin2hex(const char *bin, size_t len) { fix it!
Comment 59•8 years ago
|
||
Comment on attachment 8738953 [details] Bug-1259355 Test Review request updated; see interdiff: https://reviewboard.mozilla.org/r/44987/diff/7-8/
Attachment #8738953 -
Flags: review?(kechen)
Comment 60•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/45191/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/45191/
Attachment #8739316 -
Flags: review?(cchang)
Comment 61•8 years ago
|
||
Comment on attachment 8739316 [details] MozReview Request: Bug 1259355 - Practice MozReview; r?chunmin https://reviewboard.mozilla.org/r/45191/#review41669 Hi ::: dom/inputmethod/mochitest/bug1110030_helper.js:5 (Diff revision 1) > +// *********************************** > +// * Global variables > +// *********************************** > +const kIsWin = navigator.platform.indexOf("Win") == 0; > + How are you?
Attachment #8739316 -
Flags: review?(cchang)
Comment 62•8 years ago
|
||
Comment on attachment 8739316 [details] MozReview Request: Bug 1259355 - Practice MozReview; r?chunmin Review request updated; see interdiff: https://reviewboard.mozilla.org/r/45191/diff/1-2/
Attachment #8739316 -
Flags: review?(cchang)
Updated•8 years ago
|
Attachment #8734297 -
Flags: review?(kikuo) → review+
Comment 63•8 years ago
|
||
Comment on attachment 8734297 [details] MozReview Request: Bug 1259355 - add god's name; r?kikuo https://reviewboard.mozilla.org/r/42157/#review41849 lgtm
Comment 64•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/45409/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/45409/
Attachment #8739848 -
Flags: review?(selee)
Comment 65•8 years ago
|
||
Comment on attachment 8739848 [details] MozReview Request: Bug 1259355 - Practice MozReview; r?seanlee Review request updated; see interdiff: https://reviewboard.mozilla.org/r/45409/diff/1-2/
Comment 66•8 years ago
|
||
Comment on attachment 8739848 [details] MozReview Request: Bug 1259355 - Practice MozReview; r?seanlee https://reviewboard.mozilla.org/r/45409/#review41947 Great! Although it's a practice review, I leave a r- here. ::: AUTHORS:557 (Diff revision 2) > Jon Herron <leftturnsolutions@yahoo.com> > Jono DiCarlo <jdicarlo@mozilla.com> > Joonas Pihlaja <jpihlaja@cc.helsinki.fi> > Jorge Villalobos <jorge@mozilla.com> > Jory A. Pratt <geekypenguin@gmail.com> > +Joseph Yeh <jyeh@mozilla.com> Great! Although it's a practice review, I leave a r- here.
Attachment #8739848 -
Flags: review?(selee)
Updated•8 years ago
|
Attachment #8739316 -
Attachment is obsolete: true
Attachment #8739316 -
Flags: review?(cchang)
Comment 67•8 years ago
|
||
https://reviewboard.mozilla.org/r/45409/#review41953 ::: AUTHORS:557 (Diff revision 2) > Jon Herron <leftturnsolutions@yahoo.com> > Jono DiCarlo <jdicarlo@mozilla.com> > Joonas Pihlaja <jpihlaja@cc.helsinki.fi> > Jorge Villalobos <jorge@mozilla.com> > Jory A. Pratt <geekypenguin@gmail.com> > +Joseph Yeh <jyeh@mozilla.com> Thanks!
Updated•8 years ago
|
Attachment #8738951 -
Flags: review?(kechen)
Comment 68•8 years ago
|
||
Comment on attachment 8738951 [details] Bug 1259355 - Test22; https://reviewboard.mozilla.org/r/44975/#review41519 ::: dom/tv/moz.build:1 (Diff revision 2) > +sdsfsds:wq test ::: dom/tv/moz.build:4 (Diff revision 2) > +sdsfsds:wq > # -*- Mode: python; c-basic-offset: 4; indent-tabs-mode: nil; tab-width: 40 -*- > # vim: set filetype=python: > # This Source Code Form is subject to the terms of the Mozilla Public lgtm
Comment 69•8 years ago
|
||
Comment on attachment 8738953 [details] Bug-1259355 Test https://reviewboard.mozilla.org/r/44987/#review42539 ::: xpcom/glue/ezlogger.h:13 (Diff revision 8) > +#include <vector> > +#include <sstream> > +#include <iomanip> > +#include <map> > +#include <unordered_map> > +#include <functional> lgtm
Attachment #8738953 -
Flags: review?(kechen)
Comment 70•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/46055/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/46055/
Comment 71•8 years ago
|
||
Comment on attachment 8740867 [details] MozReview Request: Bug 1259355 - MozReview practice; r?scottwu Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46055/diff/1-2/
Attachment #8740867 -
Attachment description: MozReview Request: Bug 1259355 - MozReview practice; r?scwwu → MozReview Request: Bug 1259355 - MozReview practice; r?scottwu
Attachment #8740867 -
Flags: review?(scwwu)
Comment 72•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/46343/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/46343/
Attachment #8741262 -
Flags: review?(cchang)
Updated•8 years ago
|
Attachment #8740867 -
Flags: review?(scwwu)
Comment 73•8 years ago
|
||
Comment on attachment 8738953 [details] Bug-1259355 Test Review request updated; see interdiff: https://reviewboard.mozilla.org/r/44987/diff/8-9/
Attachment #8738953 -
Attachment description: MozReview Request: Bug 1259355 - Test. r=?kechen → MozReview Request: Bug 1259355 - Test Push. r?kechen
Attachment #8738953 -
Flags: review?(kechen)
Comment 74•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/48403/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/48403/
Attachment #8744208 -
Flags: review?(jacheng)
Updated•8 years ago
|
Attachment #8744208 -
Flags: review?(jacheng) → review+
Comment 75•8 years ago
|
||
Comment on attachment 8744208 [details] Bug 1259355 - List sites using quota storage or appcache in Settings of Site Data, https://reviewboard.mozilla.org/r/48403/#review45127 test chines "強"
Comment 76•8 years ago
|
||
https://reviewboard.mozilla.org/r/46341/#review45429 ::: mobile/android/components/PresentationDevicePrompt.js:116 (Diff revision 1) > + if (deviceIndex < 0) { // Cancel request if no selected device > + aRequest.cancel(); > + } > + > + aRequest.select(devices[deviceIndex]); > + }, Please add UITelemetry.addEvent("show.1", "dialog", null, "prompt_device_selection");
Comment 77•8 years ago
|
||
Comment on attachment 8738953 [details] Bug-1259355 Test https://reviewboard.mozilla.org/r/44987/#review45465
Attachment #8738953 -
Flags: review?(kechen) → review+
Comment 78•8 years ago
|
||
Comment on attachment 8738953 [details] Bug-1259355 Test Review request updated; see interdiff: https://reviewboard.mozilla.org/r/44987/diff/9-10/
Attachment #8738953 -
Attachment description: MozReview Request: Bug 1259355 - Test Push. r?kechen → MozReview Request: Bug 1259355 - Practice MozReview; r?schien
Attachment #8738953 -
Flags: review?(schien)
Comment 79•8 years ago
|
||
Comment on attachment 8738953 [details] Bug-1259355 Test https://reviewboard.mozilla.org/r/44987/#review45481
Attachment #8738953 -
Flags: review?(schien) → review+
Comment 80•8 years ago
|
||
Comment on attachment 8738953 [details] Bug-1259355 Test Review request updated; see interdiff: https://reviewboard.mozilla.org/r/44987/diff/10-11/
Attachment #8738953 -
Attachment description: MozReview Request: Bug 1259355 - Practice MozReview; r?schien → MozReview Request: Bug 1259355 - Test L1 r+. r?kechen
Updated•8 years ago
|
Attachment #8741262 -
Flags: review?(cchang)
Comment 81•8 years ago
|
||
Comment on attachment 8741262 [details] Bug 1259355 - God bless me; https://reviewboard.mozilla.org/r/46343/#review46403 Test
Comment 82•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/49669/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/49669/
Attachment #8747008 -
Flags: review?(rchien)
Comment 83•8 years ago
|
||
Comment on attachment 8747008 [details] MozReview Request: Bug 1259355 - Fix Private Browsing start-page overflows off the window bottom r?rickychien https://reviewboard.mozilla.org/r/49669/#review46427 Good!
Attachment #8747008 -
Flags: review?(rchien) → review+
Comment 84•8 years ago
|
||
Reporter | ||
Comment 85•8 years ago
|
||
Comment on attachment 8734267 [details] Bug 1259355 - Try to commit single patch-2; Review request updated; see interdiff: https://reviewboard.mozilla.org/r/42153/diff/3-4/
Attachment #8734267 -
Attachment description: MozReview Request: Bug 1259355 - Practice! Don't load it#01; r?JamesCheng → MozReview Request: Bug 1259355 - test for windows mozreview.; r?JamesCheng
Attachment #8734267 -
Flags: review-
Reporter | ||
Updated•8 years ago
|
Attachment #8734308 -
Attachment is obsolete: true
Reporter | ||
Comment 86•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/54764/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/54764/
Attachment #8755736 -
Flags: review?(jacheng)
Comment 87•8 years ago
|
||
Comment on attachment 8755736 [details] Bug 1259355 - Try to commit single patch-1; https://reviewboard.mozilla.org/r/54764/#review51664
Attachment #8755736 -
Flags: review?(jacheng) → review+
Comment 88•8 years ago
|
||
Attachment #8757814 -
Flags: feedback?(fliu)
Updated•8 years ago
|
Attachment #8757814 -
Flags: feedback?(fliu)
Comment 89•8 years ago
|
||
Attachment #8757814 -
Attachment is obsolete: true
Attachment #8757820 -
Flags: feedback?(fliu)
Updated•8 years ago
|
Attachment #8757820 -
Flags: feedback?(fliu)
Comment 90•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/57738/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/57738/
Comment 91•8 years ago
|
||
Comment on attachment 8759923 [details] bug 1259355 - test by astley https://reviewboard.mozilla.org/r/57738/#review54586
Attachment #8759923 -
Flags: review+
Comment 92•8 years ago
|
||
Comment on attachment 8759923 [details] bug 1259355 - test by astley Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57738/diff/1-2/
Comment 93•8 years ago
|
||
Comment on attachment 8759923 [details] bug 1259355 - test by astley Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57738/diff/2-3/
Updated•8 years ago
|
Attachment #8740867 -
Attachment is obsolete: true
Reporter | ||
Comment 94•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/58158/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/58158/
Attachment #8734267 -
Attachment description: MozReview Request: Bug 1259355 - test for windows mozreview.; r?JamesCheng → Bug 1259355 - Try to commit single patch;
Attachment #8755736 -
Attachment description: MozReview Request: Bug 1259355 - test for update windows mozreview; r?JamesCheng → Bug 1259355 - Try to commit single patch-1;
Attachment #8760618 -
Flags: review?(dmu)
Attachment #8734267 -
Flags: review?(dmu)
Attachment #8755736 -
Flags: review?(dmu)
Reporter | ||
Comment 95•8 years ago
|
||
Comment on attachment 8734267 [details] Bug 1259355 - Try to commit single patch-2; Review request updated; see interdiff: https://reviewboard.mozilla.org/r/42153/diff/4-5/
Reporter | ||
Comment 96•8 years ago
|
||
Comment on attachment 8755736 [details] Bug 1259355 - Try to commit single patch-1; Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54764/diff/1-2/
Reporter | ||
Updated•8 years ago
|
Attachment #8755736 -
Attachment is obsolete: true
Attachment #8755736 -
Flags: review?(dmu)
Reporter | ||
Updated•8 years ago
|
Attachment #8760618 -
Attachment is obsolete: true
Attachment #8760618 -
Flags: review?(dmu)
Reporter | ||
Comment 97•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/58160/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/58160/
Attachment #8734267 -
Attachment description: Bug 1259355 - Try to commit single patch; → Bug 1259355 - Try to commit single patch-2;
Attachment #8760621 -
Flags: review?(dmu)
Attachment #8760622 -
Flags: review?(dmu)
Reporter | ||
Comment 98•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/58162/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/58162/
Reporter | ||
Comment 99•8 years ago
|
||
Comment on attachment 8734267 [details] Bug 1259355 - Try to commit single patch-2; Review request updated; see interdiff: https://reviewboard.mozilla.org/r/42153/diff/5-6/
Reporter | ||
Updated•8 years ago
|
Attachment #8734267 -
Attachment is obsolete: true
Attachment #8734267 -
Flags: review?(dmu)
Reporter | ||
Updated•8 years ago
|
Attachment #8760622 -
Attachment is obsolete: true
Attachment #8760622 -
Flags: review?(dmu)
Reporter | ||
Comment 100•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/58164/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/58164/
Attachment #8760623 -
Flags: review?(dmu)
Attachment #8760624 -
Flags: review?(dmu)
Reporter | ||
Comment 101•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/58166/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/58166/
Reporter | ||
Updated•8 years ago
|
Attachment #8760623 -
Attachment is obsolete: true
Attachment #8760623 -
Flags: review?(dmu)
Reporter | ||
Updated•8 years ago
|
Attachment #8760624 -
Attachment is obsolete: true
Attachment #8760624 -
Flags: review?(dmu)
Comment 102•8 years ago
|
||
Comment on attachment 8744208 [details] Bug 1259355 - List sites using quota storage or appcache in Settings of Site Data, Review request updated; see interdiff: https://reviewboard.mozilla.org/r/48403/diff/1-2/
Attachment #8744208 -
Attachment description: MozReview Request: Bug 1259355 - Just try to push to mozreview; r?JamesCheng → Bug 1259355 - Practice MozReview for the first time use.
Comment 103•8 years ago
|
||
Comment on attachment 8744208 [details] Bug 1259355 - List sites using quota storage or appcache in Settings of Site Data, Review request updated; see interdiff: https://reviewboard.mozilla.org/r/48403/diff/2-3/
Attachment #8744208 -
Flags: review?(fliu)
Comment 104•8 years ago
|
||
Comment on attachment 8744208 [details] Bug 1259355 - List sites using quota storage or appcache in Settings of Site Data, Review request updated; see interdiff: https://reviewboard.mozilla.org/r/48403/diff/3-4/
Attachment #8744208 -
Attachment description: Bug 1259355 - Practice MozReview for the first time use. → Bug 1259355 - Practice MozReview for the second time use.
Comment 105•8 years ago
|
||
Comment on attachment 8744208 [details] Bug 1259355 - List sites using quota storage or appcache in Settings of Site Data, Review request updated; see interdiff: https://reviewboard.mozilla.org/r/48403/diff/4-5/
Attachment #8744208 -
Attachment description: Bug 1259355 - Practice MozReview for the second time use. → Bug 1259355 - Practice MozReview for the 3rd time use.
Updated•8 years ago
|
Attachment #8744208 -
Flags: review?(fliu) → review+
Reporter | ||
Updated•8 years ago
|
Attachment #8760621 -
Flags: review?(dmu) → review+
Reporter | ||
Comment 106•8 years ago
|
||
Comment on attachment 8760621 [details] Bug 1259355 - Try to commit single patch-1; https://reviewboard.mozilla.org/r/58160/#review55242
Comment 107•8 years ago
|
||
Comment on attachment 8741262 [details] Bug 1259355 - God bless me; Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46343/diff/1-2/
Attachment #8741262 -
Attachment description: MozReview Request: Bug 1259355 - MozReview practice; r?chunmin → Bug 1259355 - Try after upgrading dotfiles;
Attachment #8741262 -
Flags: review?(cchang)
Updated•8 years ago
|
Attachment #8747008 -
Attachment is obsolete: true
Updated•8 years ago
|
Attachment #8759923 -
Attachment is obsolete: true
Comment 108•8 years ago
|
||
Comment on attachment 8738953 [details] Bug-1259355 Test Review request updated; see interdiff: https://reviewboard.mozilla.org/r/44987/diff/11-12/
Attachment #8738953 -
Attachment description: MozReview Request: Bug 1259355 - Test L1 r+. r?kechen → Bug 1259355 - git mv and cp back and modified both.
Attachment #8738953 -
Flags: review+
Comment 109•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/62692/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/62692/
Comment 110•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/62694/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/62694/
Comment 111•8 years ago
|
||
Comment on attachment 8768455 [details] Bug 1259355 - rename first. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62692/diff/1-2/
Attachment #8768455 -
Attachment description: rename first → Bug 1259355 - rename first.
Attachment #8768456 -
Attachment description: no use → Bug 1259355 - no use.
Attachment #8768455 -
Flags: review?(kechen)
Attachment #8768456 -
Flags: review?(kechen)
Comment 112•8 years ago
|
||
Comment on attachment 8768456 [details] Bug 1259355 - no use. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62694/diff/1-2/
Comment 114•8 years ago
|
||
Comment on attachment 8768455 [details] Bug 1259355 - rename first. https://reviewboard.mozilla.org/r/62692/#review60250
Attachment #8768455 -
Flags: review?(kechen) → review+
Updated•8 years ago
|
Attachment #8768456 -
Flags: review?(kechen) → review+
Comment 115•8 years ago
|
||
Comment on attachment 8768456 [details] Bug 1259355 - no use. https://reviewboard.mozilla.org/r/62694/#review60252
Updated•8 years ago
|
Attachment #8741262 -
Flags: review?(cchang) → review+
Comment 116•8 years ago
|
||
Comment on attachment 8741262 [details] Bug 1259355 - God bless me; https://reviewboard.mozilla.org/r/46343/#review60284 yo
Comment 117•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/65472/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/65472/
Attachment #8772710 -
Flags: review?(kikuo)
Comment 118•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/65474/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/65474/
Comment 119•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/65476/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/65476/
Comment 120•8 years ago
|
||
Comment on attachment 8772710 [details] Bug 1259355 - hahaha https://reviewboard.mozilla.org/r/65472/#review62452 r+ with the following issue addressed ::: README.txt:29 (Diff revision 1) > > https://archive.mozilla.org/pub/firefox/nightly/latest-mozilla-central/ > - or - > http://nightly.mozilla.org/ > + > +Haha HaHa for what ? I suppose there's a joke here, please write it done.
Attachment #8772710 -
Flags: review?(kikuo) → review-
Comment 121•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/65482/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/65482/
Comment 122•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/65910/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/65910/
Updated•8 years ago
|
Attachment #8773171 -
Attachment is obsolete: true
Comment 123•8 years ago
|
||
Comment on attachment 8738951 [details] Bug 1259355 - Test22; Review request updated; see interdiff: https://reviewboard.mozilla.org/r/44975/diff/2-3/
Attachment #8738951 -
Attachment description: MozReview Request: Bug 1259355 - Practice MozReview for the first time use. r?kechen → Bug 1259355 - test.
Attachment #8738951 -
Flags: review?(kechen)
Comment 124•8 years ago
|
||
Comment on attachment 8738953 [details] Bug-1259355 Test Review request updated; see interdiff: https://reviewboard.mozilla.org/r/44987/diff/12-13/
Attachment #8738953 -
Attachment description: Bug 1259355 - git mv and cp back and modified both. → Bug 1259355 - Add Kevin to AUTHORS list.
Updated•8 years ago
|
Attachment #8768455 -
Attachment is obsolete: true
Updated•8 years ago
|
Attachment #8768456 -
Attachment is obsolete: true
Updated•8 years ago
|
Attachment #8738951 -
Flags: review?(kechen) → review+
Comment 125•8 years ago
|
||
Comment on attachment 8738951 [details] Bug 1259355 - Test22; https://reviewboard.mozilla.org/r/44975/#review65626
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 128•8 years ago
|
||
mozreview-review |
Comment on attachment 8741262 [details] Bug 1259355 - God bless me; https://reviewboard.mozilla.org/r/46343/#review78970
Comment 129•8 years ago
|
||
mozreview-review |
Comment on attachment 8738953 [details] Bug-1259355 Test https://reviewboard.mozilla.org/r/44987/#review89958 hi kilik, plz review it part1
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 132•8 years ago
|
||
mozreview-review |
Comment on attachment 8807033 [details] Bug1259355 - Part2 god like author added. https://reviewboard.mozilla.org/r/90314/#review89960 hi kilik, plz review it part2
Comment hidden (mozreview-request) |
Updated•8 years ago
|
Attachment #8807035 -
Flags: review?(kikuo)
Comment 134•8 years ago
|
||
mozreview-review |
Comment on attachment 8738953 [details] Bug-1259355 Test https://reviewboard.mozilla.org/r/44987/#review89970
Attachment #8738953 -
Flags: review?(kikuo) → review+
Comment 135•8 years ago
|
||
mozreview-review |
Comment on attachment 8807033 [details] Bug1259355 - Part2 god like author added. https://reviewboard.mozilla.org/r/90314/#review89972
Attachment #8807033 -
Flags: review?(kikuo) → review+
Comment 136•8 years ago
|
||
mozreview-review |
Comment on attachment 8807035 [details] Bug1259355 - Part3 no r ? test https://reviewboard.mozilla.org/r/90320/#review89974
Attachment #8807035 -
Flags: review?(kikuo)
Comment hidden (mozreview-request) |
Comment 138•8 years ago
|
||
mozreview-review |
Comment on attachment 8807035 [details] Bug1259355 - Part3 no r ? test https://reviewboard.mozilla.org/r/90320/#review89988
Attachment #8807035 -
Flags: review?(kikuo) → review+
Comment 139•8 years ago
|
||
mozreview-review |
Comment on attachment 8738953 [details] Bug-1259355 Test https://reviewboard.mozilla.org/r/44987/#review89992
Attachment #8738953 -
Flags: review+ → review-
Comment 140•8 years ago
|
||
mozreview-review |
Comment on attachment 8807033 [details] Bug1259355 - Part2 god like author added. https://reviewboard.mozilla.org/r/90314/#review89994
Attachment #8807033 -
Flags: review+ → review?(kikuo)
Comment 141•8 years ago
|
||
mozreview-review |
Comment on attachment 8807033 [details] Bug1259355 - Part2 god like author added. https://reviewboard.mozilla.org/r/90314/#review89996
Attachment #8807033 -
Flags: review?(kikuo)
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 145•8 years ago
|
||
mozreview-review |
Comment on attachment 8738953 [details] Bug-1259355 Test https://reviewboard.mozilla.org/r/44987/#review90746
Attachment #8738953 -
Flags: review?(kikuo) → review+
Comment 146•8 years ago
|
||
mozreview-review |
Comment on attachment 8807033 [details] Bug1259355 - Part2 god like author added. https://reviewboard.mozilla.org/r/90314/#review90748
Attachment #8807033 -
Flags: review?(kikuo) → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Updated•7 years ago
|
Attachment #8819775 -
Flags: review?(walkingice0204)
Comment 149•7 years ago
|
||
mozreview-review |
Comment on attachment 8819775 [details] Bug 1259355 - mozreview 3 https://reviewboard.mozilla.org/r/99450/#review99726 ::: mobile/android/base/java/org/mozilla/gecko/BrowserApp.java:3931 (Diff revision 1) > } finally { > StrictMode.setThreadPolicy(savedPolicy); > } > } > > - public void openUrls(List<String> urls) { > + public void openUrls(List<String> urls){ get whitespace back
Attachment #8819775 -
Flags: review?(walkingice0204) → review-
Comment hidden (mozreview-request) |
Updated•7 years ago
|
Attachment #8819776 -
Attachment is obsolete: true
Comment 151•7 years ago
|
||
mozreview-review |
Comment on attachment 8819775 [details] Bug 1259355 - mozreview 3 https://reviewboard.mozilla.org/r/99450/#review99736 ::: mobile/android/base/java/org/mozilla/gecko/BrowserApp.java:204 (Diff revision 2) > OnUrlOpenInBackgroundListener, > AnchoredPopup.OnVisibilityChangeListener, > ActionModeCompat.Presenter, > LayoutInflater.Factory { > private static final String LOGTAG = "GeckoBrowserApp"; > + private int uselessInt = 0; try to remove this line
Attachment #8819775 -
Flags: review?(walkingice0204) → review-
Comment hidden (mozreview-request) |
Comment 153•7 years ago
|
||
mozreview-review |
Comment on attachment 8819775 [details] Bug 1259355 - mozreview 3 https://reviewboard.mozilla.org/r/99448/#review99738 Mozreview practice.
Comment 154•7 years ago
|
||
mozreview-review |
Comment on attachment 8819775 [details] Bug 1259355 - mozreview 3 https://reviewboard.mozilla.org/r/99450/#review99744 Just a parctice. Don't land this commit.
Attachment #8819775 -
Flags: review?(walkingice0204) → review+
Updated•7 years ago
|
Attachment #8819775 -
Attachment is obsolete: true
Comment hidden (mozreview-request) |
Comment 156•7 years ago
|
||
mozreview-review |
Comment on attachment 8820522 [details] Bug 1259355 - mozreview 4 https://reviewboard.mozilla.org/r/100010/#review100500 ::: mobile/android/base/java/org/mozilla/gecko/BrowserApp.java:203 (Diff revision 1) > OnUrlOpenListener, > OnUrlOpenInBackgroundListener, > AnchoredPopup.OnVisibilityChangeListener, > ActionModeCompat.Presenter, > LayoutInflater.Factory { > - private static final String LOGTAG = "GeckoBrowserApp"; > + private static final String LOGTAG = "MozReview"; Just test
Attachment #8820522 -
Flags: review?(walkingice0204) → review+
Comment hidden (mozreview-request) |
Comment 158•7 years ago
|
||
mozreview-review |
Comment on attachment 8820522 [details] Bug 1259355 - mozreview 4 https://reviewboard.mozilla.org/r/100010/#review100502 update review flag
Attachment #8820522 -
Flags: review+
Updated•7 years ago
|
Attachment #8820522 -
Attachment is obsolete: true
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Updated•7 years ago
|
Attachment #8821987 -
Attachment is obsolete: true
Comment hidden (mozreview-request) |
Updated•7 years ago
|
Attachment #8807033 -
Attachment is obsolete: true
Updated•7 years ago
|
Attachment #8807035 -
Attachment is obsolete: true
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 164•7 years ago
|
||
mozreview-review |
Comment on attachment 8838449 [details] Bug 1259355 - d. https://reviewboard.mozilla.org/r/113386/#review120798
Attachment #8838449 -
Flags: review?(kechen) → review-
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Updated•7 years ago
|
Attachment #8838449 -
Attachment is obsolete: true
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Updated•7 years ago
|
Attachment #8858237 -
Flags: review?(kechen)
Attachment #8858237 -
Flags: review+
Comment 171•7 years ago
|
||
mozreview-review |
Comment on attachment 8858237 [details] Bug 1259355 - Test23; https://reviewboard.mozilla.org/r/130216/#review132880
Comment hidden (mozreview-request) |
Updated•7 years ago
|
Attachment #8744208 -
Flags: review?(fliu)
Comment 173•7 years ago
|
||
mozreview-review |
Comment on attachment 8744208 [details] Bug 1259355 - List sites using quota storage or appcache in Settings of Site Data, https://reviewboard.mozilla.org/r/48403/#review140414 ::: browser/components/preferences/SiteDataManager.jsm:6 (Diff revision 6) > "use strict"; > > const { classes: Cc, interfaces: Ci, utils: Cu } = Components; > > Cu.import("resource://gre/modules/XPCOMUtils.jsm"); > Cu.import("resource://gre/modules/Services.jsm"); OK
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Updated•6 years ago
|
Attachment #8741262 -
Attachment is obsolete: true
Comment 176•6 years ago
|
||
mozreview-review |
Comment on attachment 8989471 [details] Bug 1259355 - Try mozreview via git. https://reviewboard.mozilla.org/r/254520/#review261346
Attachment #8989471 -
Flags: review?(cchang) → review+
Comment 177•6 years ago
|
||
(In reply to Chun-Min Chang[:chunmin] from comment #176) > Comment on attachment 8989471 [details] > Bug 1259355 - mozreview test. > > https://reviewboard.mozilla.org/r/254520/#review261346 Is mozreview still being used ? Are they trying to build a new one ?
Comment 178•6 years ago
|
||
(In reply to Kilik Kuo [:kikuo] (inactive) from comment #177) > (In reply to Chun-Min Chang[:chunmin] from comment #176) > > Comment on attachment 8989471 [details] > > Bug 1259355 - mozreview test. > > > > https://reviewboard.mozilla.org/r/254520/#review261346 > > Is mozreview still being used ? Are they trying to build a new one ? Yes, there is a new tool but it's still under development. Just want to make sure the old way still works.
Comment hidden (mozreview-request) |
Updated•2 years ago
|
Severity: trivial → S4
You need to log in
before you can comment on or make changes to this bug.
Description
•