Closed Bug 1259389 Opened 4 years ago Closed 4 years ago

"Restore closed windows" items without url have additional indent at the left

Categories

(Firefox :: Theme, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 48
Tracking Status
firefox48 --- fixed

People

(Reporter: arni2033, Assigned: rakhisharma)

Details

Attachments

(2 files)

>>>   My Info:   Win7_64, Nightly 48, 32bit, ID 20160323030400
STR_1:
1. Open new window. Open this bug in a new tab in that window
2. Ctrl+MiddleClick the link http://briangrinstead.com/files/sleepy.php in that tab
   to open a new selected tab
3. While URL is page loading (e.g. immediately) press Escape to cancel loading
4. Close the window opened in Step 2
5. Click History toolbarbutton, scroll to "Restore closed windows" block

AR:  "Restore closed windows" items without url have additional indent at the left (16px)
ER:  No additional indent
Correction in Step 4:
4. Close the window opened in STEP_1
Attachment #8740832 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8740832 [details]
MozReview Request: Bug 1259389 - "Restore closed windows" items without url have additional indent at the left, r=Gijs.

https://reviewboard.mozilla.org/r/46041/#review42545

Clearing review per IRC discussion.
Comment on attachment 8740832 [details]
MozReview Request: Bug 1259389 - "Restore closed windows" items without url have additional indent at the left, r=Gijs.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46041/diff/1-2/
Attachment #8740832 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8740832 [details]
MozReview Request: Bug 1259389 - "Restore closed windows" items without url have additional indent at the left, r=Gijs.

https://reviewboard.mozilla.org/r/46041/#review42549

::: browser/components/customizableui/CustomizableWidgets.jsm:267
(Diff revision 2)
>        separator = doc.getElementById("PanelUI-recentlyClosedWindows-separator");
>        elementCount = windowsFragment.childElementCount;
>        separator.hidden = !elementCount;
>        while (--elementCount >= 0) {
>          windowsFragment.children[elementCount].classList.add("subviewbutton");
> +        windowsFragment.children[elementCount].classList.add("cui-withicon");

You can modify the previous line instead:

....  .add("subviewbutton", "cui-withicon");

Please also do this for the tabsFragment classes, 10 lines up.
Attachment #8740832 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8740832 [details]
MozReview Request: Bug 1259389 - "Restore closed windows" items without url have additional indent at the left, r=Gijs.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46041/diff/2-3/
Attachment #8740832 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8740832 [details]
MozReview Request: Bug 1259389 - "Restore closed windows" items without url have additional indent at the left, r=Gijs.

https://reviewboard.mozilla.org/r/46041/#review42553

Nice, thanks!
Attachment #8740832 - Flags: review?(gijskruitbosch+bugs) → review+
Assignee: nobody → Rakhish1994
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/8606adea8d2e
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
You need to log in before you can comment on or make changes to this bug.