125949 - compiler warning at nsStaticNameTable.cpp:88

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Brian Ryner (not reading)]

nsStaticNameTable.cpp: In method `PRBool nsStaticCaseInsensitiveNameTable::Init
(const char **, int)':
nsStaticNameTable.cpp:88: warning: unused variable `nsDependentCString *str'


alec, I don't think we need to assign the result of the placement-new into a
variable here.  Suggested fix:

--- nsStaticNameTable.cpp	17 Dec 2001 07:06:36 -0000	1.8
+++ nsStaticNameTable.cpp	17 Feb 2002 01:32:57 -0000
@@ -84,9 +84,8 @@
        NS_ASSERTION(temp1.Equals(temp2), "upper case char in table");
        }
 #endif
-       // use placement-new to initialize the string object
-       nsDependentCString *str =
-         new (&mNameArray[index]) nsDependentCString(raw);
+        // use placement-new to initialize the string object
+        new (&mNameArray[index]) nsDependentCString(raw);
         nsCStringKey key(raw, len, nsCStringKey::NEVER_OWN);
         mNameTable->Put(&key, (void*)(index+1)); // to make 0 != nsnull
     }

Comment 1

[Boris Zbarsky [:bzbarsky]]

r=bzbarsky

Comment 2

[Alec Flett]

ah, you're right. sr=alecf if you feel like checking that in

Comment 3

[Brian Ryner (not reading)]

checked in.