Closed Bug 1259518 Opened 4 years ago Closed 4 years ago

Toolkit loading throbber: new icon and new file name

Categories

(Thunderbird :: Theme, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 48.0

People

(Reporter: stefanh, Assigned: Paenglab)

References

()

Details

Attachments

(2 files)

Bug 750054 changed the throbber icon and also the file name. I see that some files in mail/themes reference to toolkit's loading_16.png. See bug 1259202 for how it was fixed in SeaMonkey.
Attached patch throbber.patchSplinter Review
For /im I rename from loading_16.png to loading.png. For /mail I use the mail throbbers which are the same (okay the Windows throbbers where green and I change them now to blue like global) but now we are independent from global.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8734510 - Flags: review?(aleth)
Comment on attachment 8734510 [details] [diff] [review]
throbber.patch

Review of attachment 8734510 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8734510 - Flags: review?(aleth) → review+
Keywords: checkin-needed
http://hg.mozilla.org/comm-central/rev/0b7165c46f6c
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 48.0
This doesn't seem to be working in the Thunderbird account manager on OS X. I don't see any throbber while the account is connecting.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
But probably bug 1256432 will fix this automagically for you ;)
(In reply to aleth [:aleth] from comment #5)
> But probably bug 1256432 will fix this automagically for you ;)

Hmm, no it won't. Doesn't touch that CSS.
Attached patch 1259518.patchSplinter Review
I missed the loading_16.png in imAccounts.css.
Attachment #8734988 - Flags: review?(aleth)
Comment on attachment 8734988 [details] [diff] [review]
1259518.patch

Review of attachment 8734988 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/components/im/themes/imAccounts.css
@@ +227,3 @@
>  }
>  richlistitem[error="true"] .accountStateIcon {
>    list-style-image: url("chrome://global/skin/icons/warning-16.png");

This one still exists?
Attachment #8734988 - Flags: review?(aleth) → review+
Note that toolkit/mozapps stuff (like update.xul) use the new icon, which we can't fix without jar.mn overrides (or using % style).
(In reply to aleth [:aleth] from comment #8)
> Comment on attachment 8734988 [details] [diff] [review]
> 1259518.patch
> 
> Review of attachment 8734988 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: mail/components/im/themes/imAccounts.css
> @@ +227,3 @@
> >  }
> >  richlistitem[error="true"] .accountStateIcon {
> >    list-style-image: url("chrome://global/skin/icons/warning-16.png");
> 
> This one still exists?

Yes, checked it when I made the first patch. I was also not sure it still exists.
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/98a45f92debf94600d606318da42ab77a3681733
Bug 1259518 - Rename the missed loading_16.png in imAccounts.css. r=aleth
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.