1259518 - Toolkit loading throbber: new icon and new file name

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Stefan [:stefanh]]

Bug 750054 changed the throbber icon and also the file name. I see that some files in mail/themes reference to toolkit's loading_16.png. See bug 1259202 for how it was fixed in SeaMonkey.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: throbber.patch

For /im I rename from loading_16.png to loading.png. For /mail I use the mail throbbers which are the same (okay the Windows throbbers where green and I change them now to blue like global) but now we are independent from global.

Comment 2

[aleth [:aleth]]

Comment on attachment 8734510 [details] [diff] [review]
throbber.patch

Review of attachment 8734510 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 3

[Richard Marti (:Paenglab)]

http://hg.mozilla.org/comm-central/rev/0b7165c46f6c

Comment 4

[aleth [:aleth]]

This doesn't seem to be working in the Thunderbird account manager on OS X. I don't see any throbber while the account is connecting.

Comment 5

[aleth [:aleth]]

But probably bug 1256432 will fix this automagically for you ;)

Comment 6

[aleth [:aleth]]

(In reply to aleth [:aleth] from comment #5)
> But probably bug 1256432 will fix this automagically for you ;)

Hmm, no it won't. Doesn't touch that CSS.

Comment 7

[Richard Marti (:Paenglab)]

Attachment: 1259518.patch

I missed the loading_16.png in imAccounts.css.

Comment 8

[aleth [:aleth]]

Comment on attachment 8734988 [details] [diff] [review]
1259518.patch

Review of attachment 8734988 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/components/im/themes/imAccounts.css
@@ +227,3 @@
>  }
>  richlistitem[error="true"] .accountStateIcon {
>    list-style-image: url("chrome://global/skin/icons/warning-16.png");

This one still exists?

Comment 9

[Stefan [:stefanh]]

Note that toolkit/mozapps stuff (like update.xul) use the new icon, which we can't fix without jar.mn overrides (or using % style).

Comment 10

[Richard Marti (:Paenglab)]

(In reply to aleth [:aleth] from comment #8)
> Comment on attachment 8734988 [details] [diff] [review]
> 1259518.patch
> 
> Review of attachment 8734988 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: mail/components/im/themes/imAccounts.css
> @@ +227,3 @@
> >  }
> >  richlistitem[error="true"] .accountStateIcon {
> >    list-style-image: url("chrome://global/skin/icons/warning-16.png");
> 
> This one still exists?

Yes, checked it when I made the first patch. I was also not sure it still exists.

Comment 11

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/98a45f92debf94600d606318da42ab77a3681733
Bug 1259518 - Rename the missed loading_16.png in imAccounts.css. r=aleth