Closed Bug 1259545 Opened 4 years ago Closed 4 years ago

Remove the JS_SaveFrameChain bits in CallbackObject error reporting

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Details

Attachments

(1 file, 1 obsolete file)

The reason that stuff is there, as far as I can tell from archeology, is because once upon a time (c.f. <http://hg.mozilla.org/mozilla-central/annotate/a71886cfb2e4/dom/base/nsJSEnvironment.cpp#l428>) our error reporter skipped reporting things based on what was or wasn't on the stack.  So all the places that wanted to "really, report, really" saved/restored the frame chain and this got cargo-culted forwards.

I think we can rip this stuff out.
The code this is working around no longer exists.
Attachment #8734493 - Flags: review?(bobbyholley)
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Comment on attachment 8734493 [details] [diff] [review]
Remove the JS_SaveFrameChain bits in CallbackObject error reporting, since they are no longer needed

Review of attachment 8734493 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bindings/CallbackObject.cpp
@@ +140,5 @@
>        // be safe here, so that nobody has to waste a day debugging gaia-ui tests.
>        if (!incumbent->GetGlobalJSObject()) {
>          return;
>        }
> +      //      mAutoIncumbentScript.emplace(incumbent);

Looks wrong.
Attachment #8734493 - Flags: review?(bobbyholley) → review-
Attachment #8734495 - Flags: review?(bobbyholley)
Attachment #8734493 - Attachment is obsolete: true
Comment on attachment 8734495 [details] [diff] [review]
Without the obviously bogus bit

Review of attachment 8734495 [details] [diff] [review]:
-----------------------------------------------------------------

So happy to see this go.
Attachment #8734495 - Flags: review?(bobbyholley) → review+
https://hg.mozilla.org/mozilla-central/rev/4907a0296ff9
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.