Closed
Bug 1259545
Opened 8 years ago
Closed 8 years ago
Remove the JS_SaveFrameChain bits in CallbackObject error reporting
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Details
Attachments
(1 file, 1 obsolete file)
2.48 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
The reason that stuff is there, as far as I can tell from archeology, is because once upon a time (c.f. <http://hg.mozilla.org/mozilla-central/annotate/a71886cfb2e4/dom/base/nsJSEnvironment.cpp#l428>) our error reporter skipped reporting things based on what was or wasn't on the stack. So all the places that wanted to "really, report, really" saved/restored the frame chain and this got cargo-culted forwards. I think we can rip this stuff out.
Assignee | ||
Comment 1•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fbc4a5a315cf
Assignee | ||
Comment 2•8 years ago
|
||
The code this is working around no longer exists.
Attachment #8734493 -
Flags: review?(bobbyholley)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Comment 3•8 years ago
|
||
Comment on attachment 8734493 [details] [diff] [review] Remove the JS_SaveFrameChain bits in CallbackObject error reporting, since they are no longer needed Review of attachment 8734493 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/bindings/CallbackObject.cpp @@ +140,5 @@ > // be safe here, so that nobody has to waste a day debugging gaia-ui tests. > if (!incumbent->GetGlobalJSObject()) { > return; > } > + // mAutoIncumbentScript.emplace(incumbent); Looks wrong.
Attachment #8734493 -
Flags: review?(bobbyholley) → review-
Assignee | ||
Comment 4•8 years ago
|
||
Attachment #8734495 -
Flags: review?(bobbyholley)
Assignee | ||
Updated•8 years ago
|
Attachment #8734493 -
Attachment is obsolete: true
Assignee | ||
Comment 5•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=989238b9b136
Comment 6•8 years ago
|
||
Comment on attachment 8734495 [details] [diff] [review] Without the obviously bogus bit Review of attachment 8734495 [details] [diff] [review]: ----------------------------------------------------------------- So happy to see this go.
Attachment #8734495 -
Flags: review?(bobbyholley) → review+
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4907a0296ff9
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•