Closed Bug 1259567 Opened 10 years ago Closed 10 years ago

Add a title and UI improvements for the Tier menu

Categories

(Tree Management :: Treeherder, defect, P5)

defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: jfrench, Assigned: jfrench)

Details

Attachments

(1 external file)

I noticed the new Tier menu and thought I might be able to improve the layout and consistency a tiny bit. Feel free to ignore my PR though if you guys prefer the current appearance. Specifically: o adding a title property "Show/hide job tiers" o making 'Tier' lowercase 'tier' for improved association with the 'tier' labels in the job tables (I know it's not bootstrap convention to not have Sentence case or Title Case, but perhaps worthwhile in this menu?) o removing 'Show" which is repeated in each of the menus o adjusting the menu padding a bit
Assignee: nobody → tojonmz
Status: NEW → ASSIGNED
Attachment #8734515 - Flags: review?(cdawson)
Comment on attachment 8734515 [details] [review] [treeherder] tojon:tier-navbar-title > mozilla:master Hey Jon! Yeah, these changes look great! Thanks for doing this. Good to see you, too. :)
Attachment #8734515 - Flags: review?(cdawson) → review+
Cool :) btw. I noticed Autolander didn't land yet; I'm not sure if the Reviewable check in the PR needs to be signed off, or if it's something else. Let me know if you want me to do anything on my end.
:camd I think the Reviewable check just needs the files marked as reviewed on your end and I think Autolander should be ok.
You just need to add the autoland keyword to the bug for autolander to do its thing. Normally it would be the reviewer who does this, but I'll take care of it in this case. :)
Keywords: autoland
Keywords: autoland
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Ah cool, thanks Will!
Verified fixed on production.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: