Closed
Bug 1259567
Opened 10 years ago
Closed 10 years ago
Add a title and UI improvements for the Tier menu
Categories
(Tree Management :: Treeherder, defect, P5)
Tree Management
Treeherder
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: jfrench, Assigned: jfrench)
Details
Attachments
(1 external file)
I noticed the new Tier menu and thought I might be able to improve the layout and consistency a tiny bit. Feel free to ignore my PR though if you guys prefer the current appearance.
Specifically:
o adding a title property "Show/hide job tiers"
o making 'Tier' lowercase 'tier' for improved association with the 'tier' labels in the job tables (I know it's not bootstrap convention to not have Sentence case or Title Case, but perhaps worthwhile in this menu?)
o removing 'Show" which is repeated in each of the menus
o adjusting the menu padding a bit
| Assignee | ||
Updated•10 years ago
|
Assignee: nobody → tojonmz
| Assignee | ||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Comment 1•10 years ago
|
||
| Assignee | ||
Updated•10 years ago
|
Attachment #8734515 -
Flags: review?(cdawson)
Comment 2•10 years ago
|
||
Comment on attachment 8734515 [details] [review]
[treeherder] tojon:tier-navbar-title > mozilla:master
Hey Jon! Yeah, these changes look great! Thanks for doing this. Good to see you, too. :)
Attachment #8734515 -
Flags: review?(cdawson) → review+
| Assignee | ||
Comment 3•10 years ago
|
||
Cool :) btw. I noticed Autolander didn't land yet; I'm not sure if the Reviewable check in the PR needs to be signed off, or if it's something else. Let me know if you want me to do anything on my end.
| Assignee | ||
Comment 4•10 years ago
|
||
:camd I think the Reviewable check just needs the files marked as reviewed on your end and I think Autolander should be ok.
Comment 5•10 years ago
|
||
You just need to add the autoland keyword to the bug for autolander to do its thing. Normally it would be the reviewer who does this, but I'll take care of it in this case. :)
Keywords: autoland
Comment 6•10 years ago
|
||
Pull request has landed in master: https://github.com/mozilla/treeherder/commit/645886634f7920588df8b383c0a6d215122f0baa
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
| Assignee | ||
Comment 7•10 years ago
|
||
Ah cool, thanks Will!
You need to log in
before you can comment on or make changes to this bug.
Description
•