1259583 - Please deploy loop standalone 1.1.15 to STAGE

Status: RESOLVED WONTFIX

(Cloud Services :: Operations: Deployment Requests - DEPRECATED, task)

Description

[David Critchley (:dcritch)]

------------------
RELEASE NOTES
------------------
https://github.com/mozilla/loop/blob/v1.1.15/CHANGELOG.md

COMPARISONS
https://github.com/mozilla/loop/compare/v1.1.10...v1.1.15

TAGS
https://github.com/mozilla/loop/releases/tag/v1.1.15
https://github.com/mozilla/loop/commit/70e848e2c2b67bb98afb1b87b56cd9305155d4e6

Timescales: We'd like this to be deployed to PRODuction next week please, assuming no blocking issues are found.

Comment 1

[Chris Hartjes [:grumpy][:chartjes]]

Assigning to :jp for deployment

Comment 2

[Chris Hartjes [:grumpy][:chartjes]]

==========
PRE-DEPLOYMENT
==========

Current version on staging of loop server is 0.20.1

With loop.server values set to https://loop.stage.mozaws.net/v0

end-2-end test calls (shared URL) - OK
Video/audio mute/unmute - OK
messaging - OK 
Tab & window-sharing - OK
privacy & ToS links - OK
Feedback screens - OK
push notifications - OK

Automated tests with following values pass assertions:

[stage]
location =  https://www.mozilla.org/firefox/hello/
root = https://call.stage.mozaws.net
loop_server = https://loop.stage.mozaws.net
loop_server_version = 0.20.1
loop_server_push_server_config = https://loop.stage.mozaws.net/push-server-config
loop_server_push_server_uri = wss://autopush.stage.mozaws.net
loop_fxos_app_name = Hello Stage
feedbackProductName = Loop
privacyWebsiteUrl = https://www.mozilla.org/privacy/firefox-hello/
legalWebsiteUrl = https://www.mozilla.org/about/legal/terms/firefox-hello/
roomsSupportUrl = https://support.mozilla.org/kb/group-conversations-firefox-hello-webrtc
guestSupportUrl = https://support.mozilla.org/kb/respond-firefox-hello-invitation-guest-mode
unsupportedPlatformUrl = https://support.mozilla.org/kb/which-browsers-will-work-firefox-hello-video-chat
learnMoreUrl = https://www.mozilla.org/hello/
homePage = https://github.com/mozilla-services/loop-server/
fakeTokBox = False
fxaOAuth = True
name = mozilla-loop-server
version = 0.20.1

**********
collected 4 items

deployment_tests/test_deployment.py::test_header PASSED
deployment_tests/test_deployment.py::test_server_config PASSED
deployment_tests/test_deployment.py::test_server_response PASSED
deployment_tests/test_deployment.py::test_push_server_config PASSED
**********

Comment 3

[Daniel Maher [:phrawzty]]

The package build step is failing:

```
# Now create a version file.
fatal: Not a git repository (or any of the parent directories): .git
make: *** [dist_standalone] Error 128
```

It would appear that this is the line that causes the failure: https://github.com/mozilla/loop/blob/v1.1.15/Makefile#L360

I commented out the two git command references and was able to build the package manually.

Comment 4

[Mark Banner (:standard8)]

phrawzty: So that's the line that generates the new VERSION.txt... I thought I'd based it on the code we had previously.

For the build, are we checking out a tag without the git repository? If so, we're not going to be able to generate a sane VERSION.txt and your build automation is going to have to do that for us.

We can probably skip the VERSION.txt file for this release. There's an obvious change that we can test manually to check the update (I'll give Chris more info in email if we do).

Comment 5

[Daniel Maher [:phrawzty]]

(In reply to Mark Banner (:standard8) from comment #4)
> phrawzty: So that's the line that generates the new VERSION.txt... I thought
> I'd based it on the code we had previously.
> 
> For the build, are we checking out a tag without the git repository? If so,
> we're not going to be able to generate a sane VERSION.txt and your build
> automation is going to have to do that for us.

The checkout and tag are present and query-able, and the exec is exactly what you want - the problem is that at that stage in the make process, you're no longer in the checked-out directory.

There are some environment variables set my Jenkins that might be interesting (GIT_COMMIT and GIT_BRANCH come to mind), but so far I haven't found a way to ensure that they make it all the way down the rabbit hole to the make stage.

I'll continue to poke at it.

Comment 6

[Mark Banner (:standard8)]

Due to the VERSION.txt issues, we're won't fixing this, and we've removed those changes for now in 1.2.5 that we're releasing in bug 1261815.