Clean up WidgetEventTime

RESOLVED FIXED in Firefox 48

Status

()

Core
Widget
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: masayuki, Assigned: Arata, Mentored)

Tracking

(Blocks: 1 bug)

Trunk
mozilla48
Points:
---

Firefox Tracking Flags

(firefox48 fixed)

Details

(Whiteboard: [good first bug][for Gecko Inside #7 in Mozilla Japan])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(4 attachments)

See bug 1259654 comment 0 for the detail.
Mentor: masayuki@d-toybox.com
(Assignee)

Comment 1

2 years ago
Created attachment 8735082 [details]
MozReview Request: Bug 1259655 - part 1 Rename WidgetEventTime::time to WidgetEventTime::mTime r?masayuki

Review commit: https://reviewboard.mozilla.org/r/42609/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/42609/
Attachment #8735082 - Flags: review?(masayuki)
Attachment #8735083 - Flags: review?(masayuki)
(Assignee)

Comment 2

2 years ago
Created attachment 8735083 [details]
MozReview Request: Bug 1259655 - part 2 Rename WidgetEventTime::timeStamp to WidgetEventTime::mTimeStamp r?masayuki

Review commit: https://reviewboard.mozilla.org/r/42611/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/42611/
Comment on attachment 8735082 [details]
MozReview Request: Bug 1259655 - part 1 Rename WidgetEventTime::time to WidgetEventTime::mTime r?masayuki

https://reviewboard.mozilla.org/r/42609/#review39089

Thank you for your great work! I'll land them if there is no problem on tryserver.
Attachment #8735082 - Flags: review?(masayuki) → review+
Attachment #8735083 - Flags: review?(masayuki) → review+
Comment on attachment 8735083 [details]
MozReview Request: Bug 1259655 - part 2 Rename WidgetEventTime::timeStamp to WidgetEventTime::mTimeStamp r?masayuki

https://reviewboard.mozilla.org/r/42611/#review39091
Comment on attachment 8735082 [details]
MozReview Request: Bug 1259655 - part 1 Rename WidgetEventTime::time to WidgetEventTime::mTime r?masayuki

https://reviewboard.mozilla.org/r/42609/#review39095

Unfortunately, bustage on Windows. I'll fix them, anyway, thank you for your work!
Attachment #8735082 - Flags: review+
Comment on attachment 8735083 [details]
MozReview Request: Bug 1259655 - part 2 Rename WidgetEventTime::timeStamp to WidgetEventTime::mTimeStamp r?masayuki

https://reviewboard.mozilla.org/r/42611/#review39097
Attachment #8735083 - Flags: review+
Assignee: nobody → old.river.new
Created attachment 8735367 [details]
MozReview Request: Bug 1259655 - part 1 Rename WidgetEventTime::time to WidgetEventTime::mTime r?masayuki

Review commit: https://reviewboard.mozilla.org/r/42747/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/42747/
Attachment #8735367 - Flags: review?(masayuki)
Attachment #8735368 - Flags: review?(masayuki)
Created attachment 8735368 [details]
MozReview Request: Bug 1259655 - part 2 Rename WidgetEventTime::timeStamp to WidgetEventTime::mTimeStamp r?masayuki

Review commit: https://reviewboard.mozilla.org/r/42749/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/42749/
Comment on attachment 8735367 [details]
MozReview Request: Bug 1259655 - part 1 Rename WidgetEventTime::time to WidgetEventTime::mTime r?masayuki

https://reviewboard.mozilla.org/r/42747/#review39177
Attachment #8735367 - Flags: review?(masayuki) → review+
Attachment #8735368 - Flags: review?(masayuki) → review+
Comment on attachment 8735368 [details]
MozReview Request: Bug 1259655 - part 2 Rename WidgetEventTime::timeStamp to WidgetEventTime::mTimeStamp r?masayuki

https://reviewboard.mozilla.org/r/42749/#review39179
https://hg.mozilla.org/integration/mozilla-inbound/rev/b7d97d1311d71903b6421c7083a3adbc1dabb511
Bug 1259655 - part 1 Rename WidgetEventTime::time to WidgetEventTime::mTime r=masayuki
https://hg.mozilla.org/integration/mozilla-inbound/rev/720933fc00b99d6ec11d8be54b710cdf493f18eb
Bug 1259655 - part 2 Rename WidgetEventTime::timeStamp to WidgetEventTime::mTimeStamp r=masayuki

Comment 13

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b7d97d1311d7
https://hg.mozilla.org/mozilla-central/rev/720933fc00b9
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox48: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.