Closed
Bug 1259655
Opened 8 years ago
Closed 8 years ago
Clean up WidgetEventTime
Categories
(Core :: Widget, defect)
Core
Widget
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: masayuki, Assigned: Arata, Mentored)
References
Details
(Whiteboard: [good first bug][for Gecko Inside #7 in Mozilla Japan])
Attachments
(4 files)
See bug 1259654 comment 0 for the detail.
Reporter | ||
Updated•8 years ago
|
Mentor: masayuki
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/42609/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/42609/
Attachment #8735082 -
Flags: review?(masayuki)
Attachment #8735083 -
Flags: review?(masayuki)
Assignee | ||
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/42611/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/42611/
Reporter | ||
Comment 3•8 years ago
|
||
Comment on attachment 8735082 [details] MozReview Request: Bug 1259655 - part 1 Rename WidgetEventTime::time to WidgetEventTime::mTime r?masayuki https://reviewboard.mozilla.org/r/42609/#review39089 Thank you for your great work! I'll land them if there is no problem on tryserver.
Attachment #8735082 -
Flags: review?(masayuki) → review+
Reporter | ||
Updated•8 years ago
|
Attachment #8735083 -
Flags: review?(masayuki) → review+
Reporter | ||
Comment 4•8 years ago
|
||
Comment on attachment 8735083 [details] MozReview Request: Bug 1259655 - part 2 Rename WidgetEventTime::timeStamp to WidgetEventTime::mTimeStamp r?masayuki https://reviewboard.mozilla.org/r/42611/#review39091
Reporter | ||
Comment 5•8 years ago
|
||
Comment on attachment 8735082 [details] MozReview Request: Bug 1259655 - part 1 Rename WidgetEventTime::time to WidgetEventTime::mTime r?masayuki https://reviewboard.mozilla.org/r/42609/#review39095 Unfortunately, bustage on Windows. I'll fix them, anyway, thank you for your work!
Attachment #8735082 -
Flags: review+
Reporter | ||
Comment 6•8 years ago
|
||
Comment on attachment 8735083 [details] MozReview Request: Bug 1259655 - part 2 Rename WidgetEventTime::timeStamp to WidgetEventTime::mTimeStamp r?masayuki https://reviewboard.mozilla.org/r/42611/#review39097
Attachment #8735083 -
Flags: review+
Reporter | ||
Updated•8 years ago
|
Assignee: nobody → old.river.new
Reporter | ||
Comment 7•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/42747/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/42747/
Attachment #8735367 -
Flags: review?(masayuki)
Attachment #8735368 -
Flags: review?(masayuki)
Reporter | ||
Comment 8•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/42749/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/42749/
Reporter | ||
Comment 9•8 years ago
|
||
Comment on attachment 8735367 [details] MozReview Request: Bug 1259655 - part 1 Rename WidgetEventTime::time to WidgetEventTime::mTime r?masayuki https://reviewboard.mozilla.org/r/42747/#review39177
Attachment #8735367 -
Flags: review?(masayuki) → review+
Reporter | ||
Updated•8 years ago
|
Attachment #8735368 -
Flags: review?(masayuki) → review+
Reporter | ||
Comment 10•8 years ago
|
||
Comment on attachment 8735368 [details] MozReview Request: Bug 1259655 - part 2 Rename WidgetEventTime::timeStamp to WidgetEventTime::mTimeStamp r?masayuki https://reviewboard.mozilla.org/r/42749/#review39179
Reporter | ||
Comment 11•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/b7d97d1311d71903b6421c7083a3adbc1dabb511 Bug 1259655 - part 1 Rename WidgetEventTime::time to WidgetEventTime::mTime r=masayuki
Reporter | ||
Comment 12•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/720933fc00b99d6ec11d8be54b710cdf493f18eb Bug 1259655 - part 2 Rename WidgetEventTime::timeStamp to WidgetEventTime::mTimeStamp r=masayuki
Comment 13•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b7d97d1311d7 https://hg.mozilla.org/mozilla-central/rev/720933fc00b9
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•