Clean up WidgetMouseEventBase
Categories
(Core :: Widget, defect, P4)
Tracking
()
People
(Reporter: masayuki, Assigned: srujana121, Mentored)
References
(Depends on 1 open bug)
Details
(Whiteboard: [good first bug][tpi:-][lang=c++])
Attachments
(9 files, 3 obsolete files)
1.45 KB,
patch
|
Details | Diff | Splinter Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review |
Reporter | ||
Updated•9 years ago
|
Reporter | ||
Comment 2•9 years ago
|
||
Reporter | ||
Comment 3•8 years ago
|
||
Reporter | ||
Comment 7•8 years ago
|
||
Updated•8 years ago
|
Reporter | ||
Comment 8•8 years ago
|
||
Comment 9•8 years ago
|
||
Reporter | ||
Comment 10•8 years ago
|
||
Comment 11•8 years ago
|
||
Reporter | ||
Comment 12•8 years ago
|
||
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 15•8 years ago
|
||
mozreview-review |
Comment 16•8 years ago
|
||
mozreview-review |
Updated•8 years ago
|
Comment hidden (mozreview-request) |
Updated•8 years ago
|
Comment 18•8 years ago
|
||
Reporter | ||
Comment 19•8 years ago
|
||
mozreview-review |
Reporter | ||
Comment 20•8 years ago
|
||
mozreview-review |
Reporter | ||
Comment 21•8 years ago
|
||
mozreview-review |
Comment 22•8 years ago
|
||
Updated•7 years ago
|
Comment 23•6 years ago
|
||
Comment 24•6 years ago
|
||
Reporter | ||
Comment 25•6 years ago
|
||
Reporter | ||
Updated•6 years ago
|
Reporter | ||
Updated•6 years ago
|
Reporter | ||
Updated•6 years ago
|
Reporter | ||
Comment 26•6 years ago
|
||
Reporter | ||
Comment 27•6 years ago
|
||
Comment 28•6 years ago
|
||
Reporter | ||
Comment 29•6 years ago
|
||
Reporter | ||
Comment 30•6 years ago
|
||
Comment 31•6 years ago
|
||
Comment 32•6 years ago
|
||
Comment 33•6 years ago
|
||
Reporter | ||
Comment 34•6 years ago
|
||
Reporter | ||
Comment 35•6 years ago
|
||
Comment 36•6 years ago
|
||
Comment 37•6 years ago
|
||
Comment 38•6 years ago
|
||
Reporter | ||
Comment 39•6 years ago
|
||
Comment 40•6 years ago
|
||
Can I work on this?
Assignee | ||
Comment 41•6 years ago
|
||
Hi, I want to work on this bug. this is what I have understood.
-
As of now 1 and 2 do not need to be solved. Only 3-10 should be solved.
-
Part 3 is not valid any more because there was a code change and the variable(relatedTarget) now belongs to ancestor of the class and it was renamed too(to mrelatedTarget).
-
Also we were asked to submit the bug in different changesets. Just to be clear, same patch but different changesets right?
I am applying for outreachy, I was assigned this bug. It was not allotted to me yet. Can someone allot it to me?
Assignee | ||
Comment 42•6 years ago
|
||
Also the comments said part 2 is done, but in the file MouseEvents.h , I dont see any changes. Should part 2 too is to be solved?
Assignee | ||
Comment 43•6 years ago
|
||
Also regarding part 10, am I correct in assuming that the order has to be in decreasing order of alignment size (alignof() value) to optimize the packing (but not cache because we will be working in multi processor systems) ?
Assignee | ||
Comment 45•6 years ago
|
||
Renamed all class member instances from WidgetMouseEventBase::buttons to WidgetMouseEventBase::mButtons
Assignee | ||
Comment 46•6 years ago
|
||
To reduce the instance size, reordered the member definition in the class WidgetMouseEventBase, in the decreasing order of alignment size (alignof() value) to optimize the packing.
Assignee | ||
Comment 47•6 years ago
|
||
Renamed all class member instances from WidgetMouseEventBase::button to WidgetMouseEventBase::mButton.
Assignee | ||
Comment 48•6 years ago
|
||
Renamed all class member instances from WidgetMouseEventBase::region to WidgetMouseEventBase::mRegion
Assignee | ||
Comment 49•6 years ago
|
||
Renamed all class member instances from WidgetMouseEventBase::inputSource to WidgetMouseEventBase::mInputSource
Assignee | ||
Comment 50•6 years ago
|
||
Renamed all class member instances from WidgetMouseEventBase::hitCluster to WidgetMouseEventBase::mHitCluster
Assignee | ||
Comment 51•6 years ago
|
||
Renamed all class member instances from WidgetMouseEventBase::pressure to WidgetMouseEventBase::mPressure
Assignee | ||
Comment 52•6 years ago
|
||
Moved mozilla::WidgetMosueEventBase::buttonType in MouseEvents.h to mozilla::MouseButton in EventForwards.h, and mozilla::WidgetMouseEventBase::buttonsFlag to mozilla::MouseButtonsFlag so that any referer in header files do not need to include MouseEvents.h only for referring them. Instead, they just need to include EventForwards.h. Now when MouseEvents.h is changed, the rebuild speed becomes faster.
Assignee | ||
Updated•6 years ago
|
Reporter | ||
Comment 53•6 years ago
|
||
Wait a moment until trying to build on all platforms.
Reporter | ||
Comment 54•6 years ago
|
||
Reporter | ||
Comment 55•6 years ago
|
||
build failure on macOS:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=238710570&repo=try&lineNumber=22810
build failure on Windows:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=238710565&repo=try&lineNumber=24038
build failure on Android:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=238710582&repo=try&lineNumber=24491
Looks like that you have not changed in widget/cocoa, widget/windows nor widget/android. You can look for them with:
https://searchfox.org/mozilla-central/search?q=symbol%3AF_%3CT_mozilla%3A%3AWidgetMouseEventBase%3E_button&case=false®exp=false&path=widget%2F
https://searchfox.org/mozilla-central/search?q=symbol%3AF_%3CT_mozilla%3A%3AWidgetMouseEventBase%3E_buttons&case=false®exp=false&path=widget%2F
https://searchfox.org/mozilla-central/search?q=symbol%3AF_%3CT_mozilla%3A%3AWidgetMouseEventBase%3E_pressure&case=false®exp=false&path=widget%2F
https://searchfox.org/mozilla-central/search?q=symbol%3AF_%3CT_mozilla%3A%3AWidgetMouseEventBase%3E_hitCluster&case=false®exp=false&path=widget%2F
https://searchfox.org/mozilla-central/search?q=symbol%3AF_%3CT_mozilla%3A%3AWidgetMouseEventBase%3E_inputSource&case=false®exp=false&path=widget%2F
https://searchfox.org/mozilla-central/search?q=symbol%3AE_%3CT_mozilla%3A%3AWidgetMouseEventBase%3A%3AbuttonType%3E_eLeftButton&case=false®exp=false&path=widget%2F
https://searchfox.org/mozilla-central/search?q=symbol%3AE_%3CT_mozilla%3A%3AWidgetMouseEventBase%3A%3AbuttonType%3E_eMiddleButton&case=false®exp=false&path=widget%2F
https://searchfox.org/mozilla-central/search?q=symbol%3AE_%3CT_mozilla%3A%3AWidgetMouseEventBase%3A%3AbuttonType%3E_eRightButton&case=false®exp=false&path=widget%2F
https://searchfox.org/mozilla-central/search?q=symbol%3AE_%3CT_mozilla%3A%3AWidgetMouseEventBase%3A%3AbuttonsFlag%3E_eNoButtonFlag&case=false®exp=false&path=widget%2F
https://searchfox.org/mozilla-central/search?q=symbol%3AE_%3CT_mozilla%3A%3AWidgetMouseEventBase%3A%3AbuttonsFlag%3E_eLeftButtonFlag&case=false®exp=false&path=widget%2F
https://searchfox.org/mozilla-central/search?q=symbol%3AE_%3CT_mozilla%3A%3AWidgetMouseEventBase%3A%3AbuttonsFlag%3E_eMiddleButtonFlag&case=false®exp=false&path=widget%2F
https://searchfox.org/mozilla-central/search?q=symbol%3AE_%3CT_mozilla%3A%3AWidgetMouseEventBase%3A%3AbuttonsFlag%3E_eRightButtonFlag&case=false®exp=false&path=widget%2F
https://searchfox.org/mozilla-central/search?q=symbol%3AE_%3CT_mozilla%3A%3AWidgetMouseEventBase%3A%3AbuttonsFlag%3E_e4thButtonFlag&case=false®exp=false&path=widget%2F
https://searchfox.org/mozilla-central/search?q=symbol%3AE_%3CT_mozilla%3A%3AWidgetMouseEventBase%3A%3AbuttonsFlag%3E_e5thButtonFlag&case=false®exp=false&path=widget%2F
Comment 56•6 years ago
|
||
Comment 57•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/89c2646562d4
https://hg.mozilla.org/mozilla-central/rev/912e85a1cbdf
https://hg.mozilla.org/mozilla-central/rev/cb6da071dc03
https://hg.mozilla.org/mozilla-central/rev/d0d15e6fc468
https://hg.mozilla.org/mozilla-central/rev/d4d915be6dcf
https://hg.mozilla.org/mozilla-central/rev/71f22c1e59a9
https://hg.mozilla.org/mozilla-central/rev/8c32486b90c5
https://hg.mozilla.org/mozilla-central/rev/b061de30553d
Updated•5 years ago
|
Reporter | ||
Updated•4 years ago
|
Description
•