Closed Bug 1259663 Opened 4 years ago Closed 4 years ago

Clean up WidgetMouseScrollEvent

Categories

(Core :: Widget, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: masayuki, Assigned: shundroidk, Mentored)

References

(Blocks 1 open bug)

Details

(Whiteboard: [good first bug][for Gecko Inside #7 in Mozilla Japan])

Attachments

(1 file)

Mentor: masayuki
shundroid-san:

Thank you for your work. One comment, replacing some members should be separated to each patch for easier to review. But it's okay for now because the patch is enough small.

However, could you drop "Part 1:" from the summary with using |hg histedit| since I guess you won't attach anymore patches to this bug?
Assignee: nobody → ra24483
Flags: needinfo?(ra24483)
Thank you for your reviewing!
I will fix it!

(Sorry, My English ability is not native level. Is it right..?)
Flags: needinfo?(ra24483)
Comment on attachment 8738387 [details]
MozReview Request: Bug 1259663 - Clean up WidgetMouseScrollEvent. r?masayuki

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/44489/diff/1-2/
Attachment #8738387 - Attachment description: MozReview Request: Bug 1259663 - Part 1: Clean up WidgetMouseScrollEvent. r?masayuki → MozReview Request: Bug 1259663 - Clean up WidgetMouseScrollEvent. r?masayuki
I removed "Part 1." from this commit message.
How's this?

Thank you.
(In reply to shundroid from comment #5)
> I removed "Part 1." from this commit message.
> How's this?
> 
> Thank you.

Fine. Thank you.
Comment on attachment 8738387 [details]
MozReview Request: Bug 1259663 - Clean up WidgetMouseScrollEvent. r?masayuki

https://reviewboard.mozilla.org/r/44489/#review41235

Looks good to me. Thank you for your work.

I'll land this patch if this won't fail to be built on tryserver.
Attachment #8738387 - Flags: review?(masayuki) → review+
Status: NEW → ASSIGNED
Thank you!
I'm looking forward to the results.
https://hg.mozilla.org/mozilla-central/rev/5448e34dc116
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.