Closed Bug 1259664 Opened 4 years ago Closed 4 years ago

Clean up WidgetWheelEvent

Categories

(Core :: Widget, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

(Blocks 1 open bug)

Details

Attachments

(13 files)

58 bytes, text/x-review-board-request
smaug
: review+
Details
58 bytes, text/x-review-board-request
smaug
: review+
Details
58 bytes, text/x-review-board-request
smaug
: review+
Details
58 bytes, text/x-review-board-request
smaug
: review+
Details
58 bytes, text/x-review-board-request
smaug
: review+
Details
58 bytes, text/x-review-board-request
smaug
: review+
Details
58 bytes, text/x-review-board-request
smaug
: review+
Details
58 bytes, text/x-review-board-request
smaug
: review+
Details
58 bytes, text/x-review-board-request
smaug
: review+
Details
58 bytes, text/x-review-board-request
smaug
: review+
Details
58 bytes, text/x-review-board-request
smaug
: review+
Details
58 bytes, text/x-review-board-request
smaug
: review+
Details
58 bytes, text/x-review-board-request
smaug
: review+
Details
Assignee: nobody → masayuki
Mentor: masayuki
Status: NEW → ASSIGNED
Whiteboard: [good first bug][for Gecko Inside #7 in Mozilla Japan]
Review commit: https://reviewboard.mozilla.org/r/43743/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43743/
Attachment #8737090 - Flags: review?(bugs)
Attachment #8737091 - Flags: review?(bugs)
Attachment #8737092 - Flags: review?(bugs)
Attachment #8737093 - Flags: review?(bugs)
Attachment #8737094 - Flags: review?(bugs)
Attachment #8737095 - Flags: review?(bugs)
Attachment #8737096 - Flags: review?(bugs)
Attachment #8737097 - Flags: review?(bugs)
Attachment #8737098 - Flags: review?(bugs)
Attachment #8737099 - Flags: review?(bugs)
Attachment #8737100 - Flags: review?(bugs)
Attachment #8737101 - Flags: review?(bugs)
Attachment #8737102 - Flags: review?(bugs)
Comment on attachment 8737090 [details]
MozReview Request: Bug 1259664 part.1 Rename WidgetWheelEvent::deltaX to WidgetWheelEvent::mDeltaX r?smaug

https://reviewboard.mozilla.org/r/43743/#review40313
Attachment #8737090 - Flags: review?(bugs) → review+
Comment on attachment 8737091 [details]
MozReview Request: Bug 1259664 part.2 Rename WidgetWheelEvent::deltaY to WidgetWheelEvent::mDeltaY r?smaug

https://reviewboard.mozilla.org/r/43745/#review40315
Attachment #8737091 - Flags: review?(bugs) → review+
Attachment #8737092 - Flags: review?(bugs) → review+
Comment on attachment 8737092 [details]
MozReview Request: Bug 1259664 part.3 Rename WidgetWheelEvent::deltaZ to WidgetWheelEvent::mDeltaZ r?smaug

https://reviewboard.mozilla.org/r/43747/#review40317
Attachment #8737093 - Flags: review?(bugs) → review+
Comment on attachment 8737093 [details]
MozReview Request: Bug 1259664 part.4 Rename WidgetWheelEvent::deltaMode to WidgetWheelEvent::mDeltaMode r?smaug

https://reviewboard.mozilla.org/r/43749/#review40335
Comment on attachment 8737094 [details]
MozReview Request: Bug 1259664 part.5 Rename WidgetWheelEvent::customizedByUserPrefs to WidgetWheelEvent::mCustomizedByUserPrefs r?smaug

https://reviewboard.mozilla.org/r/43751/#review40337
Attachment #8737094 - Flags: review?(bugs) → review+
Attachment #8737095 - Flags: review?(bugs) → review+
Comment on attachment 8737095 [details]
MozReview Request: Bug 1259664 part.6 Rename WidgetWheelEvent::mayHaveMomentum to WidgetWheelEvent::mMayHaveMomentum r?smaug

https://reviewboard.mozilla.org/r/43753/#review40339
Comment on attachment 8737096 [details]
MozReview Request: Bug 1259664 part.7 Rename WidgetWheelEvent::isMomentum to WidgetWheelEvent::mIsMomentum r?smaug

https://reviewboard.mozilla.org/r/43755/#review40341
Attachment #8737096 - Flags: review?(bugs) → review+
Comment on attachment 8737097 [details]
MozReview Request: Bug 1259664 part.8 Rename WidgetWheelEvent::scrollType to WidgetWheelEvent::mScrollType r?smaug

https://reviewboard.mozilla.org/r/43757/#review40345
Attachment #8737097 - Flags: review?(bugs) → review+
Attachment #8737098 - Flags: review?(bugs) → review+
Comment on attachment 8737098 [details]
MozReview Request: Bug 1259664 part.9 Rename WidgetWheelEvent::lineOrPageDeltaX to WidgetWheelEvent::mLineOrPageDeltaX r?smaug

https://reviewboard.mozilla.org/r/43759/#review40349

::: dom/plugins/base/nsPluginInstanceOwner.cpp:2435
(Diff revision 1)
>                  charsPerWheelDelta = 3;
>                }
>                if (!charsPerWheelDelta) {
>                  break;
>                }
> -              delta =
> +              delta = WHEEL_DELTA / charsPerWheelDelta;

I wouldn't have split the calculation to two assignments, but fine.
Comment on attachment 8737099 [details]
MozReview Request: Bug 1259664 part.10 Rename WidgetWheelEvent::lineOrPageDeltaY to WidgetWheelEvent::mLineOrPageDeltaY r?smaug

https://reviewboard.mozilla.org/r/43761/#review40363
Attachment #8737099 - Flags: review?(bugs) → review+
Comment on attachment 8737100 [details]
MozReview Request: Bug 1259664 part.11 Rename WidgetWheelEvent::overflowDeltaX to WidgetWheelEvent::mOverflowDeltaX r?smaug

https://reviewboard.mozilla.org/r/43763/#review40365
Attachment #8737100 - Flags: review?(bugs) → review+
Attachment #8737101 - Flags: review?(bugs) → review+
Comment on attachment 8737101 [details]
MozReview Request: Bug 1259664 part.12 Rename WidgetWheelEvent::overflowDeltaY to WidgetWheelEvent::mOverflowDeltaY r?smaug

https://reviewboard.mozilla.org/r/43765/#review40367
Comment on attachment 8737102 [details]
MozReview Request: Bug 1259664 part.13 Reorder the definition of members of WidgetWheelEvent r?smaug

https://reviewboard.mozilla.org/r/43767/#review40371
Attachment #8737102 - Flags: review?(bugs) → review+
You need to log in before you can comment on or make changes to this bug.