Closed
Bug 1259664
Opened 8 years ago
Closed 8 years ago
Clean up WidgetWheelEvent
Categories
(Core :: Widget, defect)
Core
Widget
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
Attachments
(13 files)
58 bytes,
text/x-review-board-request
|
smaug
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
smaug
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
smaug
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
smaug
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
smaug
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
smaug
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
smaug
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
smaug
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
smaug
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
smaug
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
smaug
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
smaug
:
review+
|
Details |
MozReview Request: Bug 1259664 part.13 Reorder the definition of members of WidgetWheelEvent r?smaug
58 bytes,
text/x-review-board-request
|
smaug
:
review+
|
Details |
See bug 1259654 comment 0 for the detail.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → masayuki
Mentor: masayuki
Status: NEW → ASSIGNED
Whiteboard: [good first bug][for Gecko Inside #7 in Mozilla Japan]
Assignee | ||
Comment 1•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d683cc62430
Assignee | ||
Comment 2•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e7adc4a81fe2
Assignee | ||
Comment 3•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/43743/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/43743/
Attachment #8737090 -
Flags: review?(bugs)
Attachment #8737091 -
Flags: review?(bugs)
Attachment #8737092 -
Flags: review?(bugs)
Attachment #8737093 -
Flags: review?(bugs)
Attachment #8737094 -
Flags: review?(bugs)
Attachment #8737095 -
Flags: review?(bugs)
Attachment #8737096 -
Flags: review?(bugs)
Attachment #8737097 -
Flags: review?(bugs)
Attachment #8737098 -
Flags: review?(bugs)
Attachment #8737099 -
Flags: review?(bugs)
Attachment #8737100 -
Flags: review?(bugs)
Attachment #8737101 -
Flags: review?(bugs)
Attachment #8737102 -
Flags: review?(bugs)
Assignee | ||
Comment 4•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/43745/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/43745/
Assignee | ||
Comment 5•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/43747/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/43747/
Assignee | ||
Comment 6•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/43749/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/43749/
Assignee | ||
Comment 7•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/43751/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/43751/
Assignee | ||
Comment 8•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/43753/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/43753/
Assignee | ||
Comment 9•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/43755/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/43755/
Assignee | ||
Comment 10•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/43757/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/43757/
Assignee | ||
Comment 11•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/43759/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/43759/
Assignee | ||
Comment 12•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/43761/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/43761/
Assignee | ||
Comment 13•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/43763/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/43763/
Assignee | ||
Comment 14•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/43765/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/43765/
Assignee | ||
Comment 15•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/43767/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/43767/
Comment 16•8 years ago
|
||
Comment on attachment 8737090 [details] MozReview Request: Bug 1259664 part.1 Rename WidgetWheelEvent::deltaX to WidgetWheelEvent::mDeltaX r?smaug https://reviewboard.mozilla.org/r/43743/#review40313
Attachment #8737090 -
Flags: review?(bugs) → review+
Comment 17•8 years ago
|
||
Comment on attachment 8737091 [details] MozReview Request: Bug 1259664 part.2 Rename WidgetWheelEvent::deltaY to WidgetWheelEvent::mDeltaY r?smaug https://reviewboard.mozilla.org/r/43745/#review40315
Attachment #8737091 -
Flags: review?(bugs) → review+
Updated•8 years ago
|
Attachment #8737092 -
Flags: review?(bugs) → review+
Comment 18•8 years ago
|
||
Comment on attachment 8737092 [details] MozReview Request: Bug 1259664 part.3 Rename WidgetWheelEvent::deltaZ to WidgetWheelEvent::mDeltaZ r?smaug https://reviewboard.mozilla.org/r/43747/#review40317
Updated•8 years ago
|
Attachment #8737093 -
Flags: review?(bugs) → review+
Comment 19•8 years ago
|
||
Comment on attachment 8737093 [details] MozReview Request: Bug 1259664 part.4 Rename WidgetWheelEvent::deltaMode to WidgetWheelEvent::mDeltaMode r?smaug https://reviewboard.mozilla.org/r/43749/#review40335
Comment 20•8 years ago
|
||
Comment on attachment 8737094 [details] MozReview Request: Bug 1259664 part.5 Rename WidgetWheelEvent::customizedByUserPrefs to WidgetWheelEvent::mCustomizedByUserPrefs r?smaug https://reviewboard.mozilla.org/r/43751/#review40337
Attachment #8737094 -
Flags: review?(bugs) → review+
Updated•8 years ago
|
Attachment #8737095 -
Flags: review?(bugs) → review+
Comment 21•8 years ago
|
||
Comment on attachment 8737095 [details] MozReview Request: Bug 1259664 part.6 Rename WidgetWheelEvent::mayHaveMomentum to WidgetWheelEvent::mMayHaveMomentum r?smaug https://reviewboard.mozilla.org/r/43753/#review40339
Comment 22•8 years ago
|
||
Comment on attachment 8737096 [details] MozReview Request: Bug 1259664 part.7 Rename WidgetWheelEvent::isMomentum to WidgetWheelEvent::mIsMomentum r?smaug https://reviewboard.mozilla.org/r/43755/#review40341
Attachment #8737096 -
Flags: review?(bugs) → review+
Comment 23•8 years ago
|
||
Comment on attachment 8737097 [details] MozReview Request: Bug 1259664 part.8 Rename WidgetWheelEvent::scrollType to WidgetWheelEvent::mScrollType r?smaug https://reviewboard.mozilla.org/r/43757/#review40345
Attachment #8737097 -
Flags: review?(bugs) → review+
Updated•8 years ago
|
Attachment #8737098 -
Flags: review?(bugs) → review+
Comment 24•8 years ago
|
||
Comment on attachment 8737098 [details] MozReview Request: Bug 1259664 part.9 Rename WidgetWheelEvent::lineOrPageDeltaX to WidgetWheelEvent::mLineOrPageDeltaX r?smaug https://reviewboard.mozilla.org/r/43759/#review40349 ::: dom/plugins/base/nsPluginInstanceOwner.cpp:2435 (Diff revision 1) > charsPerWheelDelta = 3; > } > if (!charsPerWheelDelta) { > break; > } > - delta = > + delta = WHEEL_DELTA / charsPerWheelDelta; I wouldn't have split the calculation to two assignments, but fine.
Comment 25•8 years ago
|
||
Comment on attachment 8737099 [details] MozReview Request: Bug 1259664 part.10 Rename WidgetWheelEvent::lineOrPageDeltaY to WidgetWheelEvent::mLineOrPageDeltaY r?smaug https://reviewboard.mozilla.org/r/43761/#review40363
Attachment #8737099 -
Flags: review?(bugs) → review+
Comment 26•8 years ago
|
||
Comment on attachment 8737100 [details] MozReview Request: Bug 1259664 part.11 Rename WidgetWheelEvent::overflowDeltaX to WidgetWheelEvent::mOverflowDeltaX r?smaug https://reviewboard.mozilla.org/r/43763/#review40365
Attachment #8737100 -
Flags: review?(bugs) → review+
Updated•8 years ago
|
Attachment #8737101 -
Flags: review?(bugs) → review+
Comment 27•8 years ago
|
||
Comment on attachment 8737101 [details] MozReview Request: Bug 1259664 part.12 Rename WidgetWheelEvent::overflowDeltaY to WidgetWheelEvent::mOverflowDeltaY r?smaug https://reviewboard.mozilla.org/r/43765/#review40367
Comment 28•8 years ago
|
||
Comment on attachment 8737102 [details] MozReview Request: Bug 1259664 part.13 Reorder the definition of members of WidgetWheelEvent r?smaug https://reviewboard.mozilla.org/r/43767/#review40371
Attachment #8737102 -
Flags: review?(bugs) → review+
Comment 29•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/7a58737fdf65 https://hg.mozilla.org/integration/mozilla-inbound/rev/b0338e680f6c https://hg.mozilla.org/integration/mozilla-inbound/rev/f5574720a35c https://hg.mozilla.org/integration/mozilla-inbound/rev/c04459ba2bbf https://hg.mozilla.org/integration/mozilla-inbound/rev/e8b552fe0c25 https://hg.mozilla.org/integration/mozilla-inbound/rev/fe393b8ba9e0 https://hg.mozilla.org/integration/mozilla-inbound/rev/2b9491eac8e7 https://hg.mozilla.org/integration/mozilla-inbound/rev/420e1377e6fe https://hg.mozilla.org/integration/mozilla-inbound/rev/10edfec862b8 https://hg.mozilla.org/integration/mozilla-inbound/rev/32a1b458e8d8 https://hg.mozilla.org/integration/mozilla-inbound/rev/c74f3d40659c https://hg.mozilla.org/integration/mozilla-inbound/rev/1cbdd0ffeee4 https://hg.mozilla.org/integration/mozilla-inbound/rev/31898058e49e
Comment 30•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7a58737fdf65 https://hg.mozilla.org/mozilla-central/rev/b0338e680f6c https://hg.mozilla.org/mozilla-central/rev/f5574720a35c https://hg.mozilla.org/mozilla-central/rev/c04459ba2bbf https://hg.mozilla.org/mozilla-central/rev/e8b552fe0c25 https://hg.mozilla.org/mozilla-central/rev/fe393b8ba9e0 https://hg.mozilla.org/mozilla-central/rev/2b9491eac8e7 https://hg.mozilla.org/mozilla-central/rev/420e1377e6fe https://hg.mozilla.org/mozilla-central/rev/10edfec862b8 https://hg.mozilla.org/mozilla-central/rev/32a1b458e8d8 https://hg.mozilla.org/mozilla-central/rev/c74f3d40659c https://hg.mozilla.org/mozilla-central/rev/1cbdd0ffeee4 https://hg.mozilla.org/mozilla-central/rev/31898058e49e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•