Closed
Bug 1259665
Opened 8 years ago
Closed 8 years ago
Clean up WidgetPointerEvent
Categories
(Core :: Widget, defect, P5)
Core
Widget
Tracking
()
RESOLVED
FIXED
mozilla51
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
(Whiteboard: [for Gecko Inside #7 in Mozilla Japan][tpi:+])
Attachments
(3 files, 1 obsolete file)
See bug 1259654 comment 0 for the detail.
|
||
Comment 1•8 years ago
|
||
patch for 1259665
|
||
Updated•8 years ago
|
Priority: -- → P5
Whiteboard: [good first bug][for Gecko Inside #7 in Mozilla Japan] → [good first bug][for Gecko Inside #7 in Mozilla Japan][tpi:+]
|
Assignee | |
Comment 3•8 years ago
|
||
Not requested review for long time and he hasn't replied for long time in another bug. I'll take this too for finishing the fix.
Assignee: nobody → masayuki
Mentor: masayuki
Status: NEW → ASSIGNED
Whiteboard: [good first bug][for Gecko Inside #7 in Mozilla Japan][tpi:+] → [for Gecko Inside #7 in Mozilla Japan][tpi:+]
|
|
Assignee | |
Comment 4•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=50e1c364e794
|
|
Assignee | |
Comment 5•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/68870/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/68870/
Attachment #8777275 -
Flags: review?(bugs)
Attachment #8777276 -
Flags: review?(bugs)
Attachment #8777277 -
Flags: review?(bugs)
|
|
Assignee | |
Comment 6•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/68872/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/68872/
|
|
Assignee | |
Comment 7•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/68874/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/68874/
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8735073 -
Attachment is obsolete: true
|
||
Comment 8•8 years ago
|
||
Comment on attachment 8777275 [details] Bug 1259665 part.1 Rename WidgetPointerEvent::width to mWidth https://reviewboard.mozilla.org/r/68870/#review65940
Attachment #8777275 -
Flags: review?(bugs) → review+
|
|
||
Updated•8 years ago
|
Attachment #8777276 -
Flags: review?(bugs) → review+
|
|
||
Comment 9•8 years ago
|
||
Comment on attachment 8777276 [details] Bug 1259665 part.2 Rename WidgetPointerEvent::height to mHeight https://reviewboard.mozilla.org/r/68872/#review65942
|
|
||
Comment 10•8 years ago
|
||
Comment on attachment 8777277 [details] Bug 1259665 part.3 Rename WidgetPointerEvent::isPrimary to mIsPrimary https://reviewboard.mozilla.org/r/68874/#review65944
Attachment #8777277 -
Flags: review?(bugs) → review+
|
||
Comment 11•8 years ago
|
||
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/9e70575bfe31 part.1 Rename WidgetPointerEvent::width to mWidth r=smaug https://hg.mozilla.org/integration/autoland/rev/af975c87031b part.2 Rename WidgetPointerEvent::height to mHeight r=smaug https://hg.mozilla.org/integration/autoland/rev/a9cc7c343752 part.3 Rename WidgetPointerEvent::isPrimary to mIsPrimary r=smaug
|
||
Comment 12•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9e70575bfe31 https://hg.mozilla.org/mozilla-central/rev/af975c87031b https://hg.mozilla.org/mozilla-central/rev/a9cc7c343752
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
|
||
Comment 13•8 years ago
|
||
I guess this can ride the trains.
You need to log in
before you can comment on or make changes to this bug.
Description
•