Closed
Bug 1259671
Opened 8 years ago
Closed 8 years ago
Clean up InternalScrollPortEvent
Categories
(Core :: Widget, defect)
Core
Widget
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
Attachments
(5 files)
58 bytes,
text/x-review-board-request
|
smaug
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
smaug
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
smaug
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
smaug
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
smaug
:
review+
|
Details |
See bug 1259654 comment 0 for the detail.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → masayuki
Mentor: masayuki
Status: NEW → ASSIGNED
Whiteboard: [good first bug][for Gecko Inside #7 in Mozilla Japan]
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/43419/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/43419/
Attachment #8736582 -
Flags: review?(bugs)
Attachment #8736583 -
Flags: review?(bugs)
Attachment #8736584 -
Flags: review?(bugs)
Attachment #8736585 -
Flags: review?(bugs)
Attachment #8736586 -
Flags: review?(bugs)
Assignee | ||
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/43421/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/43421/
Assignee | ||
Comment 3•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/43423/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/43423/
Assignee | ||
Comment 4•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/43425/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/43425/
Assignee | ||
Comment 5•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/43427/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/43427/
Updated•8 years ago
|
Attachment #8736582 -
Flags: review?(bugs) → review+
Comment 6•8 years ago
|
||
Comment on attachment 8736582 [details] MozReview Request: Bug 1259671 part.1 Rename InternalScrollPortEvent::orientType to InternalScrollPortEvent::OrientType r?smaug https://reviewboard.mozilla.org/r/43419/#review40029
Updated•8 years ago
|
Attachment #8736583 -
Flags: review?(bugs) → review+
Comment 7•8 years ago
|
||
Comment on attachment 8736583 [details] MozReview Request: Bug 1259671 part.2 Rename InternalScrollPortEvent::vertical to InternalScrollPortEvent::eVertical r?smaug https://reviewboard.mozilla.org/r/43421/#review40031
Updated•8 years ago
|
Attachment #8736584 -
Flags: review?(bugs) → review+
Comment 8•8 years ago
|
||
Comment on attachment 8736584 [details] MozReview Request: Bug 1259671 part.3 Rename InternalScrollPortEvent::horizontal to InternalScrollPortEvent::eHorizontal r?smaug https://reviewboard.mozilla.org/r/43423/#review40033
Comment 9•8 years ago
|
||
Comment on attachment 8736585 [details] MozReview Request: Bug 1259671 part.4 Rename InternalScrollPortEvent::both to InternalScrollPortEvent::eBoth r?smaug https://reviewboard.mozilla.org/r/43425/#review40035
Attachment #8736585 -
Flags: review?(bugs) → review+
Comment 10•8 years ago
|
||
Comment on attachment 8736586 [details] MozReview Request: Bug 1259671 part.5 Rename InternalScrollPortEvent::orient to InternalScrollPortEvent::mOrient r?smaug https://reviewboard.mozilla.org/r/43427/#review40037
Attachment #8736586 -
Flags: review?(bugs) → review+
Comment 11•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/b73ce1b4482c https://hg.mozilla.org/integration/mozilla-inbound/rev/e7bc2f2b3f4b https://hg.mozilla.org/integration/mozilla-inbound/rev/2f906943b572 https://hg.mozilla.org/integration/mozilla-inbound/rev/dd54d4836c8e https://hg.mozilla.org/integration/mozilla-inbound/rev/dfa1afae978e
Comment 12•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b73ce1b4482c https://hg.mozilla.org/mozilla-central/rev/e7bc2f2b3f4b https://hg.mozilla.org/mozilla-central/rev/2f906943b572 https://hg.mozilla.org/mozilla-central/rev/dd54d4836c8e https://hg.mozilla.org/mozilla-central/rev/dfa1afae978e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•