Closed
Bug 1259673
Opened 8 years ago
Closed 8 years ago
Clean up InternalClipboardEvent
Categories
(Core :: Widget, defect)
Core
Widget
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: masayuki, Assigned: tetsuharu, Mentored)
References
Details
(Whiteboard: [good first bug][for Gecko Inside #7 in Mozilla Japan])
Attachments
(1 file)
See bug 1259654 comment 0 for the detail.
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/42583/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/42583/
Attachment #8735074 -
Flags: review?(masayuki)
Assignee | ||
Comment 2•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=603d2d360d78
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → saneyuki.s.snyk
Reporter | ||
Comment 3•8 years ago
|
||
Comment on attachment 8735074 [details] MozReview Request: Bug 1259673 rename from InternalClipboardEvent.clipboardData to InternalClipboardEvent.mClipboardData. r?masayuki https://reviewboard.mozilla.org/r/42583/#review39069 r+ if there is no bustage. Thank you for your work!
Attachment #8735074 -
Flags: review?(masayuki) → review+
Reporter | ||
Updated•8 years ago
|
Attachment #8735074 -
Flags: review+
Reporter | ||
Comment 4•8 years ago
|
||
Comment on attachment 8735074 [details] MozReview Request: Bug 1259673 rename from InternalClipboardEvent.clipboardData to InternalClipboardEvent.mClipboardData. r?masayuki https://reviewboard.mozilla.org/r/42583/#review39083 Hey, failed to be built on tryserver!
Assignee | ||
Comment 5•8 years ago
|
||
Comment on attachment 8735074 [details] MozReview Request: Bug 1259673 rename from InternalClipboardEvent.clipboardData to InternalClipboardEvent.mClipboardData. r?masayuki Review request updated; see interdiff: https://reviewboard.mozilla.org/r/42583/diff/1-2/
Attachment #8735074 -
Flags: review?(masayuki)
Assignee | ||
Comment 6•8 years ago
|
||
@(In reply to Masayuki Nakano [:masayuki] (Mozilla Japan) from comment #4) > Hey, failed to be built on tryserver! Oops!
Assignee | ||
Comment 7•8 years ago
|
||
I resend the fixed patch: https://reviewboard.mozilla.org/r/42583/diff/1-2/ Could you review this?
Assignee | ||
Comment 8•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5ad0fe7de331
Reporter | ||
Updated•8 years ago
|
Attachment #8735074 -
Flags: review?(masayuki) → review+
Reporter | ||
Comment 9•8 years ago
|
||
Comment on attachment 8735074 [details] MozReview Request: Bug 1259673 rename from InternalClipboardEvent.clipboardData to InternalClipboardEvent.mClipboardData. r?masayuki https://reviewboard.mozilla.org/r/42583/#review39107
Comment 11•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/605b1a8fa215
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•