Closed
Bug 1259674
Opened 8 years ago
Closed 8 years ago
Clean up InternalFocusEvent
Categories
(Core :: Widget, defect)
Core
Widget
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: masayuki, Assigned: takenspc, Mentored)
References
Details
(Whiteboard: [good first bug][for Gecko Inside #7 in Mozilla Japan])
Attachments
(3 files)
See bug 1259654 comment 0 for the detail.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → taken.spc
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/42659/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/42659/
Attachment #8735207 -
Flags: review?(masayuki)
Attachment #8735208 -
Flags: review?(masayuki)
Attachment #8735209 -
Flags: review?(masayuki)
Assignee | ||
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/42661/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/42661/
Assignee | ||
Comment 3•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/42663/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/42663/
Reporter | ||
Updated•8 years ago
|
Attachment #8735207 -
Flags: review?(masayuki) → review+
Reporter | ||
Comment 4•8 years ago
|
||
Comment on attachment 8735207 [details] MozReview Request: Bug 1259674 Part 1 rename InternalFocusEvent::fromRaise to InternalFocusEvent::mFrameRaise r?masayuki https://reviewboard.mozilla.org/r/42659/#review39155 Looks good to me if this won't cause any troble on tryserver.
Reporter | ||
Comment 5•8 years ago
|
||
Comment on attachment 8735208 [details] MozReview Request: Bug 1259674 Part 2 rename InternalFocusEvent::isRefocus to InternalFocusEvent::mIsRefocus r?masayuki https://reviewboard.mozilla.org/r/42661/#review39157
Attachment #8735208 -
Flags: review?(masayuki) → review+
Reporter | ||
Comment 6•8 years ago
|
||
Comment on attachment 8735209 [details] MozReview Request: Bug 1259674 Part 3 rename InternalFocusEvent::relatedTarget to InternalFocusEvent::mRelatedTarget r?masayuki https://reviewboard.mozilla.org/r/42663/#review39159
Attachment #8735209 -
Flags: review?(masayuki) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/9ea30db3cc3a https://hg.mozilla.org/integration/mozilla-inbound/rev/945ae999da2d https://hg.mozilla.org/integration/mozilla-inbound/rev/abdfb47efd9a
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9ea30db3cc3a https://hg.mozilla.org/mozilla-central/rev/945ae999da2d https://hg.mozilla.org/mozilla-central/rev/abdfb47efd9a
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•