Clean up InternalFocusEvent

RESOLVED FIXED in Firefox 48

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: masayuki, Assigned: taken.spc, Mentored)

Tracking

(Blocks: 1 bug)

Trunk
mozilla48
Points:
---

Firefox Tracking Flags

(firefox48 fixed)

Details

(Whiteboard: [good first bug][for Gecko Inside #7 in Mozilla Japan])

Attachments

(3 attachments)

See bug 1259654 comment 0 for the detail.
(Assignee)

Updated

3 years ago
Assignee: nobody → taken.spc
(Assignee)

Comment 1

3 years ago
Created attachment 8735207 [details]
MozReview Request: Bug 1259674 Part 1 rename InternalFocusEvent::fromRaise to InternalFocusEvent::mFrameRaise r?masayuki

Review commit: https://reviewboard.mozilla.org/r/42659/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/42659/
Attachment #8735207 - Flags: review?(masayuki)
Attachment #8735208 - Flags: review?(masayuki)
Attachment #8735209 - Flags: review?(masayuki)
(Assignee)

Comment 2

3 years ago
Created attachment 8735208 [details]
MozReview Request: Bug 1259674 Part 2 rename InternalFocusEvent::isRefocus to InternalFocusEvent::mIsRefocus r?masayuki

Review commit: https://reviewboard.mozilla.org/r/42661/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/42661/
(Assignee)

Comment 3

3 years ago
Created attachment 8735209 [details]
MozReview Request: Bug 1259674 Part 3 rename InternalFocusEvent::relatedTarget to InternalFocusEvent::mRelatedTarget r?masayuki

Review commit: https://reviewboard.mozilla.org/r/42663/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/42663/
Attachment #8735207 - Flags: review?(masayuki) → review+
Comment on attachment 8735207 [details]
MozReview Request: Bug 1259674 Part 1 rename InternalFocusEvent::fromRaise to InternalFocusEvent::mFrameRaise r?masayuki

https://reviewboard.mozilla.org/r/42659/#review39155

Looks good to me if this won't cause any troble on tryserver.
Comment on attachment 8735208 [details]
MozReview Request: Bug 1259674 Part 2 rename InternalFocusEvent::isRefocus to InternalFocusEvent::mIsRefocus r?masayuki

https://reviewboard.mozilla.org/r/42661/#review39157
Attachment #8735208 - Flags: review?(masayuki) → review+
Comment on attachment 8735209 [details]
MozReview Request: Bug 1259674 Part 3 rename InternalFocusEvent::relatedTarget to InternalFocusEvent::mRelatedTarget r?masayuki

https://reviewboard.mozilla.org/r/42663/#review39159
Attachment #8735209 - Flags: review?(masayuki) → review+

Comment 8

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9ea30db3cc3a
https://hg.mozilla.org/mozilla-central/rev/945ae999da2d
https://hg.mozilla.org/mozilla-central/rev/abdfb47efd9a
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox48: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.