1259675 - Clean up InternalTransitionEvent

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(PTO: 9/19-9/27)]

See bug 1259654 comment 0 for the detail.

Comment 1

[Makoto Kato [:m_kato]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=afd8f162cb42

Comment 2

[tyamaguchi.gentoo]

Attachment: MozReview Request: Bug 1259675 - Clean up InternalTransitionEvent r?masayuki

Review commit: https://reviewboard.mozilla.org/r/42587/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/42587/

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(PTO: 9/19-9/27)]

Comment on attachment 8735076 [details]
MozReview Request: Bug 1259675 - Clean up InternalTransitionEvent r?masayuki

https://reviewboard.mozilla.org/r/42587/#review39075

::: widget/ContentEvents.h:261
(Diff revision 1)
> -  nsString propertyName;
> -  float elapsedTime;
> -  nsString pseudoElement;
> +  nsString mPropertyName;
> +  float mElapsedTime;
> +  nsString mPseudoElement;

Could you reorder the members as:

nsString mPropertyName;
nsString mPseudoElement;
float mElapsedTime;

?

I'd be happey if you separated the changes per each member but it's okay for this bug. (Replaceing only one member per hack makes review easier)

Comment 4

[tyamaguchi.gentoo]

Comment on attachment 8735076 [details]
MozReview Request: Bug 1259675 - Clean up InternalTransitionEvent r?masayuki

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/42587/diff/1-2/

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(PTO: 9/19-9/27)]

Comment on attachment 8735076 [details]
MozReview Request: Bug 1259675 - Clean up InternalTransitionEvent r?masayuki

https://reviewboard.mozilla.org/r/42587/#review39079

Thank your for your quick fix! I'll land this after checking the result on tryserver.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cdf83aa2b0ba

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/cdf83aa2b0ba