Closed Bug 1259675 Opened 5 years ago Closed 5 years ago

Clean up InternalTransitionEvent

Categories

(Core :: Widget, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: masayuki, Assigned: tyamaguchi.gentoo, Mentored)

References

Details

(Whiteboard: [good first bug][for Gecko Inside #7 in Mozilla Japan])

Attachments

(1 file)

Comment on attachment 8735076 [details]
MozReview Request: Bug 1259675 - Clean up InternalTransitionEvent r?masayuki

https://reviewboard.mozilla.org/r/42587/#review39075

::: widget/ContentEvents.h:261
(Diff revision 1)
> -  nsString propertyName;
> -  float elapsedTime;
> -  nsString pseudoElement;
> +  nsString mPropertyName;
> +  float mElapsedTime;
> +  nsString mPseudoElement;

Could you reorder the members as:

nsString mPropertyName;
nsString mPseudoElement;
float mElapsedTime;

?

I'd be happey if you separated the changes per each member but it's okay for this bug. (Replaceing only one member per hack makes review easier)
Attachment #8735076 - Flags: review?(masayuki)
Assignee: nobody → tyamaguchi.gentoo
Comment on attachment 8735076 [details]
MozReview Request: Bug 1259675 - Clean up InternalTransitionEvent r?masayuki

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/42587/diff/1-2/
Attachment #8735076 - Flags: review?(masayuki)
Comment on attachment 8735076 [details]
MozReview Request: Bug 1259675 - Clean up InternalTransitionEvent r?masayuki

https://reviewboard.mozilla.org/r/42587/#review39079

Thank your for your quick fix! I'll land this after checking the result on tryserver.
Attachment #8735076 - Flags: review?(masayuki) → review+
https://hg.mozilla.org/mozilla-central/rev/cdf83aa2b0ba
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.