Closed
Bug 1259675
Opened 8 years ago
Closed 8 years ago
Clean up InternalTransitionEvent
Categories
(Core :: Widget, defect)
Core
Widget
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: masayuki, Assigned: tyamaguchi.gentoo, Mentored)
References
Details
(Whiteboard: [good first bug][for Gecko Inside #7 in Mozilla Japan])
Attachments
(1 file)
See bug 1259654 comment 0 for the detail.
Assignee | ||
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/42587/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/42587/
Attachment #8735076 -
Flags: review?(masayuki)
Reporter | ||
Comment 3•8 years ago
|
||
Comment on attachment 8735076 [details] MozReview Request: Bug 1259675 - Clean up InternalTransitionEvent r?masayuki https://reviewboard.mozilla.org/r/42587/#review39075 ::: widget/ContentEvents.h:261 (Diff revision 1) > - nsString propertyName; > - float elapsedTime; > - nsString pseudoElement; > + nsString mPropertyName; > + float mElapsedTime; > + nsString mPseudoElement; Could you reorder the members as: nsString mPropertyName; nsString mPseudoElement; float mElapsedTime; ? I'd be happey if you separated the changes per each member but it's okay for this bug. (Replaceing only one member per hack makes review easier)
Attachment #8735076 -
Flags: review?(masayuki)
Reporter | ||
Updated•8 years ago
|
Assignee: nobody → tyamaguchi.gentoo
Assignee | ||
Comment 4•8 years ago
|
||
Comment on attachment 8735076 [details] MozReview Request: Bug 1259675 - Clean up InternalTransitionEvent r?masayuki Review request updated; see interdiff: https://reviewboard.mozilla.org/r/42587/diff/1-2/
Attachment #8735076 -
Flags: review?(masayuki)
Reporter | ||
Comment 5•8 years ago
|
||
Comment on attachment 8735076 [details] MozReview Request: Bug 1259675 - Clean up InternalTransitionEvent r?masayuki https://reviewboard.mozilla.org/r/42587/#review39079 Thank your for your quick fix! I'll land this after checking the result on tryserver.
Attachment #8735076 -
Flags: review?(masayuki) → review+
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/cdf83aa2b0ba
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•