Closed Bug 1259676 Opened 4 years ago Closed 4 years ago

Clean up InternalAnimationEvent

Categories

(Core :: Widget, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: masayuki, Assigned: tetsuharu, Mentored)

References

(Blocks 1 open bug)

Details

(Whiteboard: [good first bug][for Gecko Inside #7 in Mozilla Japan])

Attachments

(4 files)

Assignee: nobody → saneyuki.s.snyk
Comment on attachment 8735059 [details]
MozReview Request: Bug 1259676 - part1: rename from 'InternalAnimationEvent.animationName' to 'InternalAnimationEvent.mAnimationName'. r?masayuki

https://reviewboard.mozilla.org/r/42545/#review39055
Attachment #8735059 - Flags: review?(masayuki) → review+
Comment on attachment 8735060 [details]
MozReview Request: Bug 1259676 - part2: rename from 'InternalAnimationEvent.elapsedTime' to 'InternalAnimationEvent.mElapsedTime'.  r?masayuki

https://reviewboard.mozilla.org/r/42547/#review39057
Attachment #8735060 - Flags: review?(masayuki) → review+
Comment on attachment 8735061 [details]
MozReview Request: Bug 1259676 - part3: rename from 'InternalAnimationEvent.pseudoElement' to 'InternalAnimationEvent.mPseudoElement'. r?masayuki

https://reviewboard.mozilla.org/r/42549/#review39059
Comment on attachment 8735062 [details]
MozReview Request: Bug 1259676 - part4: reorder InternalAnimationEvent's members. r?masayuki

https://reviewboard.mozilla.org/r/42551/#review39061

Thank you very much! I'll land them after I confirm them all green on tryserver.
Attachment #8735062 - Flags: review?(masayuki) → review+
You need to log in before you can comment on or make changes to this bug.