Clean up InternalAnimationEvent

RESOLVED FIXED in Firefox 48

Status

()

Core
Widget
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: masayuki, Assigned: tetsuharu, Mentored)

Tracking

(Blocks: 1 bug)

Trunk
mozilla48
Points:
---

Firefox Tracking Flags

(firefox48 fixed)

Details

(Whiteboard: [good first bug][for Gecko Inside #7 in Mozilla Japan])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(4 attachments)

See bug 1259654 comment 0 for the detail.
Created attachment 8735059 [details]
MozReview Request: Bug 1259676 - part1: rename from 'InternalAnimationEvent.animationName' to 'InternalAnimationEvent.mAnimationName'. r?masayuki

Review commit: https://reviewboard.mozilla.org/r/42545/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/42545/
Attachment #8735059 - Flags: review?(masayuki)
Attachment #8735060 - Flags: review?(masayuki)
Attachment #8735061 - Flags: review?(masayuki)
Attachment #8735062 - Flags: review?(masayuki)
Created attachment 8735060 [details]
MozReview Request: Bug 1259676 - part2: rename from 'InternalAnimationEvent.elapsedTime' to 'InternalAnimationEvent.mElapsedTime'.  r?masayuki

Review commit: https://reviewboard.mozilla.org/r/42547/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/42547/
Created attachment 8735061 [details]
MozReview Request: Bug 1259676 - part3: rename from 'InternalAnimationEvent.pseudoElement' to 'InternalAnimationEvent.mPseudoElement'. r?masayuki

Review commit: https://reviewboard.mozilla.org/r/42549/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/42549/
Created attachment 8735062 [details]
MozReview Request: Bug 1259676 - part4: reorder InternalAnimationEvent's members. r?masayuki

Review commit: https://reviewboard.mozilla.org/r/42551/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/42551/
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a2a139a8733c
(Assignee)

Updated

2 years ago
Assignee: nobody → saneyuki.s.snyk
Comment on attachment 8735059 [details]
MozReview Request: Bug 1259676 - part1: rename from 'InternalAnimationEvent.animationName' to 'InternalAnimationEvent.mAnimationName'. r?masayuki

https://reviewboard.mozilla.org/r/42545/#review39055
Attachment #8735059 - Flags: review?(masayuki) → review+
Comment on attachment 8735060 [details]
MozReview Request: Bug 1259676 - part2: rename from 'InternalAnimationEvent.elapsedTime' to 'InternalAnimationEvent.mElapsedTime'.  r?masayuki

https://reviewboard.mozilla.org/r/42547/#review39057
Attachment #8735060 - Flags: review?(masayuki) → review+
Attachment #8735061 - Flags: review?(masayuki) → review+
Comment on attachment 8735061 [details]
MozReview Request: Bug 1259676 - part3: rename from 'InternalAnimationEvent.pseudoElement' to 'InternalAnimationEvent.mPseudoElement'. r?masayuki

https://reviewboard.mozilla.org/r/42549/#review39059
Comment on attachment 8735062 [details]
MozReview Request: Bug 1259676 - part4: reorder InternalAnimationEvent's members. r?masayuki

https://reviewboard.mozilla.org/r/42551/#review39061

Thank you very much! I'll land them after I confirm them all green on tryserver.
Attachment #8735062 - Flags: review?(masayuki) → review+

Comment 10

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/1bfc39d87c3e
https://hg.mozilla.org/integration/mozilla-inbound/rev/4c4d2c688430
https://hg.mozilla.org/integration/mozilla-inbound/rev/98a3326050d8
https://hg.mozilla.org/integration/mozilla-inbound/rev/2db5ba70aa1e

Comment 11

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1bfc39d87c3e
https://hg.mozilla.org/mozilla-central/rev/4c4d2c688430
https://hg.mozilla.org/mozilla-central/rev/98a3326050d8
https://hg.mozilla.org/mozilla-central/rev/2db5ba70aa1e
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox48: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.