Closed
Bug 1259676
Opened 8 years ago
Closed 8 years ago
Clean up InternalAnimationEvent
Categories
(Core :: Widget, defect)
Core
Widget
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: masayuki, Assigned: tetsuharu, Mentored)
References
Details
(Whiteboard: [good first bug][for Gecko Inside #7 in Mozilla Japan])
Attachments
(4 files)
See bug 1259654 comment 0 for the detail.
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/42545/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/42545/
Attachment #8735059 -
Flags: review?(masayuki)
Attachment #8735060 -
Flags: review?(masayuki)
Attachment #8735061 -
Flags: review?(masayuki)
Attachment #8735062 -
Flags: review?(masayuki)
Assignee | ||
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/42547/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/42547/
Assignee | ||
Comment 3•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/42549/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/42549/
Assignee | ||
Comment 4•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/42551/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/42551/
Assignee | ||
Comment 5•8 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a2a139a8733c
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → saneyuki.s.snyk
Reporter | ||
Comment 6•8 years ago
|
||
Comment on attachment 8735059 [details] MozReview Request: Bug 1259676 - part1: rename from 'InternalAnimationEvent.animationName' to 'InternalAnimationEvent.mAnimationName'. r?masayuki https://reviewboard.mozilla.org/r/42545/#review39055
Attachment #8735059 -
Flags: review?(masayuki) → review+
Reporter | ||
Comment 7•8 years ago
|
||
Comment on attachment 8735060 [details] MozReview Request: Bug 1259676 - part2: rename from 'InternalAnimationEvent.elapsedTime' to 'InternalAnimationEvent.mElapsedTime'. r?masayuki https://reviewboard.mozilla.org/r/42547/#review39057
Attachment #8735060 -
Flags: review?(masayuki) → review+
Reporter | ||
Updated•8 years ago
|
Attachment #8735061 -
Flags: review?(masayuki) → review+
Reporter | ||
Comment 8•8 years ago
|
||
Comment on attachment 8735061 [details] MozReview Request: Bug 1259676 - part3: rename from 'InternalAnimationEvent.pseudoElement' to 'InternalAnimationEvent.mPseudoElement'. r?masayuki https://reviewboard.mozilla.org/r/42549/#review39059
Reporter | ||
Comment 9•8 years ago
|
||
Comment on attachment 8735062 [details] MozReview Request: Bug 1259676 - part4: reorder InternalAnimationEvent's members. r?masayuki https://reviewboard.mozilla.org/r/42551/#review39061 Thank you very much! I'll land them after I confirm them all green on tryserver.
Attachment #8735062 -
Flags: review?(masayuki) → review+
Comment 10•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1bfc39d87c3e https://hg.mozilla.org/integration/mozilla-inbound/rev/4c4d2c688430 https://hg.mozilla.org/integration/mozilla-inbound/rev/98a3326050d8 https://hg.mozilla.org/integration/mozilla-inbound/rev/2db5ba70aa1e
Comment 11•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1bfc39d87c3e https://hg.mozilla.org/mozilla-central/rev/4c4d2c688430 https://hg.mozilla.org/mozilla-central/rev/98a3326050d8 https://hg.mozilla.org/mozilla-central/rev/2db5ba70aa1e
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•