Physical space key causes scroll even if the key is assigned to Tab key or something

RESOLVED FIXED in Firefox 48

Status

()

Core
Event Handling
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: masayuki, Assigned: Arata, Mentored)

Tracking

({regression})

Trunk
mozilla48
regression
Points:
---

Firefox Tracking Flags

(firefox48 fixed)

Details

(Whiteboard: [key hell][good first bug][for Gecko Inside #7 in Mozilla Japan])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

I've found a regression report on twitter, but I forgot to report it to bugzilla, sorry.
https://twitter.com/Nymphium/status/509603095857201152

This is a regression of bug 479942. In bug 479942, we always set ' ' (U+20) to shortcut key candidate if the key event is caused by space bar.

However, some users may assign other function key to space bar. In such case, we shouldn't scroll up/down the page.

We should check WidgetKeyboardEvent::mKayNameIndex if it's value is KEY_NAME_INDEX_USE_STRING. If it's not so, that means the space bar is assigned to a function key.
(Assignee)

Comment 1

2 years ago
Created attachment 8735066 [details]
MozReview Request: Bug 1259679 - Space key shouldn't work as a space key if it's assigned to a function key. r?masayuki

Even if space key is pressed but it's assigned to a non-printable key, it shouldn't work as a space key because some users may assign Enter key or something to the space key.

Review commit: https://reviewboard.mozilla.org/r/42563/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/42563/
Attachment #8735066 - Flags: review?(masayuki)
Assignee: nobody → old.river.new
Comment on attachment 8735066 [details]
MozReview Request: Bug 1259679 - Space key shouldn't work as a space key if it's assigned to a function key. r?masayuki

https://reviewboard.mozilla.org/r/42563/#review39073

r+ if tryserve detects no error. Thank you for your work!
Attachment #8735066 - Flags: review?(masayuki) → review+

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/cdf61a196be8
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox48: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.