Closed
Bug 1259684
Opened 8 years ago
Closed 8 years ago
|mach try| does not recognize many valid try syntax flags
Categories
(Testing :: General, defect)
Tracking
(firefox48 fixed)
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: sjakthol, Assigned: gbrown)
Details
Attachments
(1 file)
3.23 KB,
patch
|
chmanchester
:
review+
|
Details | Diff | Splinter Review |
Things I've noticed so far: * longer versions of -b -p -u -t (--build --platform --unittest --talos) that are accepted by the try_parser (I think) [1] * email options: -f or --failure-emails or -e or --all-emails [2] For example, the following command fails because of unrecognized -f argument: > ./mach try -b do -f -p linux,linux64,macosx64,win32,win64 -u mochitest-dt,mochitest-e10s-devtools-chrome -t none As an occasional contributor, the -f option something I really miss because it gives an immediate notification when something fails and I don't have to keep an eye on my try pushes all the time. [1] http://hg.mozilla.org/build/buildbotcustom/file/tip/try_parser.py#l300 [2] http://hg.mozilla.org/build/buildbotcustom/file/tip/bin/try_mailer.py#l190
Assignee | ||
Comment 1•8 years ago
|
||
Adds --build, --platform, --unittests, --talos, --failure-emails, --all-emails, -f, -e. I cannot think of any other missing options. An example: ./mach try -b do -f -p linux,linux64,macosx64,win32,win64 -u mochitest-dt,mochitest-e10s-devtools-chrome -t none --> https://treeherder.mozilla.org/#/jobs?repo=try&revision=6beef76e8d4a --> "try: -b do -p win32,win64,linux64,linux,macosx64 -u mochitest-dt,mochitest-e10s-devtools-chrome -t none --failure-emails" Another: ./mach try --build do --platform android-api-15-frontend --unittests none --talos none --failure-emails --> https://treeherder.mozilla.org/#/jobs?repo=try&revision=5c9f83e152d5 --> "try: -b do -p android-api-15-frontend -u none -t none --failure-emails"
Assignee: nobody → gbrown
Attachment #8736885 -
Flags: review?(cmanchester)
Comment 2•8 years ago
|
||
Comment on attachment 8736885 [details] [diff] [review] allow more options to 'mach try' Review of attachment 8736885 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for the patch! ::: testing/tools/autotry/autotry.py @@ +26,2 @@ > help='Test suites to run in their entirety.') > + parser.add_argument('-t', '--talos', dest="talos", action="append", This upholds the existing inconsistency between single and double quotes. Since you're touching these lines, consider making them all single quotes before landing.
Attachment #8736885 -
Flags: review?(cmanchester) → review+
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/562a23b80b8c
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•