Closed Bug 1259692 Opened 8 years ago Closed 6 years ago

[TSF] TSFTextStore should send keyboard events to TextEventDispatcher during composition

Categories

(Core :: Widget: Win32, defect, P4)

All
Windows
defect

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

(Keywords: inputmethod, Whiteboard: tpi:+)

Attachments

(1 file)

Currently, TSFTextStore receives WM_KEYDOWN, WM_KEYUP, WM_SYSKEYDOWN and WM_SYSKEYUP in TSFTextStore::ProcessRawKeyMessage().  However, different from IMM, if IME (TIP) consumes the key message, the messages won't be sent to the windowproc.  Therefore, we cannot dispatch keyboard events which are consumed by IME only in TSF mode.

For example, you don't see a keydown event before compositionstart.

I think that TSFTextStore should store current key message into a static variable. And if windowproc isn't called, it should dispatch key event(s) with the stored message.
See Also: → 887695
Summary: [TSF] TSFTextStore should send keyboard events during composition to TextEventDispatcher → [TSF] TSFTextStore should send keyboard events to TextEventDispatcher during composition
Priority: -- → P4
Whiteboard: tpi+
Whiteboard: tpi+ → tpi:+
Assignee: nobody → masayuki
Status: NEW → ASSIGNED
Comment on attachment 8956335 [details]
Bug 1259692 - Make TSFTextStore dispatch eKeyDown or eKeyUp event when TIP processes a WM_KEYDOWN or WM_KEYUP message

https://reviewboard.mozilla.org/r/225198/#review231260
Attachment #8956335 - Flags: review?(m_kato) → review+
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/19de31537925
Make TSFTextStore dispatch eKeyDown or eKeyUp event when TIP processes a WM_KEYDOWN or WM_KEYUP message r=m_kato
https://hg.mozilla.org/mozilla-central/rev/19de31537925
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: