12597 - [dogfood] Reflow when text decoration changes between none and underline

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[David Hyatt]

It looks like a reflow is happening when the text decoration changes between
none and underline (and vice versa).  It seems like this doesn't need to cause a
reflow, since the size of the font is the same with or without an underline (at
least i think that's true).

Here's the relevant function... it just does a comparison of the fonts without
checking to see if only the decoration changes (and that it only changes from
none to underline or vice versa).

PRInt32 StyleFontImpl::CalcDifference(const StyleFontImpl& aOther) const
{
  if (mFont.Equals(aOther.mFont) && mFixedFont.Equals(aOther.mFixedFont) &&
      (mFlags == aOther.mFlags)) {
    return NS_STYLE_HINT_NONE;
  }
  return NS_STYLE_HINT_REFLOW;
}

Comment 1

[Christine Hoffman]

Using a local test case, cannot see problem. Verifying bug fixed.