[dogfood] Reflow when text decoration changes between none and underline

VERIFIED FIXED

Status

()

Core
CSS Parsing and Computation
P3
normal
VERIFIED FIXED
19 years ago
19 years ago

People

(Reporter: David Hyatt, Assigned: Peter Linss)

Tracking

Trunk
x86
Other
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

19 years ago
It looks like a reflow is happening when the text decoration changes between
none and underline (and vice versa).  It seems like this doesn't need to cause a
reflow, since the size of the font is the same with or without an underline (at
least i think that's true).

Here's the relevant function... it just does a comparison of the fonts without
checking to see if only the decoration changes (and that it only changes from
none to underline or vice versa).

PRInt32 StyleFontImpl::CalcDifference(const StyleFontImpl& aOther) const
{
  if (mFont.Equals(aOther.mFont) && mFixedFont.Equals(aOther.mFixedFont) &&
      (mFlags == aOther.mFlags)) {
    return NS_STYLE_HINT_NONE;
  }
  return NS_STYLE_HINT_REFLOW;
}
(Assignee)

Updated

19 years ago
Status: NEW → RESOLVED
Last Resolved: 19 years ago
Resolution: --- → FIXED

Updated

19 years ago
Status: RESOLVED → VERIFIED

Comment 1

19 years ago
Using a local test case, cannot see problem. Verifying bug fixed.
You need to log in before you can comment on or make changes to this bug.