Closed
Bug 1259753
Opened 7 years ago
Closed 7 years ago
Fix some CPP_UNIT_TESTS to use ScopedXPCOM
Categories
(Testing :: General, defect)
Tracking
(firefox48 fixed)
RESOLVED
FIXED
mozilla48
| Tracking | Status | |
|---|---|---|
| firefox48 | --- | fixed |
People
(Reporter: ted, Assigned: ted)
References
Details
Attachments
(1 file)
bug 1239083 makes XPCOM initialization set the ICU data directory to the GRE directory, which contains the ICU data file. This works fine in all cases except for three CPP_UNIT_TESTS which call InitXPCOM directly and don't pass in a directory. The ScopedXPCOM class from TestHarness.h uses an environment variable it gets from the Python test harness to do the right thing here, so changing the tests to use that fixes it.
|
Assignee | |
Comment 1•7 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/42479/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/42479/
Attachment #8734764 -
Flags: review?(Ms2ger)
|
||
Updated•7 years ago
|
Attachment #8734764 -
Flags: review?(Ms2ger) → review+
|
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8734764 [details] MozReview Request: bug 1259753 - fix some C++ unittests to use ScopedXPCOM to init XPCOM. r?ms2ger https://reviewboard.mozilla.org/r/42479/#review38939
|
|
Assignee | |
Comment 3•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/58c9a586754efb3c052edef401daaed2dba14e88 bug 1259753 - fix some C++ unittests to use ScopedXPCOM to init XPCOM. r=ms2ger
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/58c9a586754e
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•