Closed Bug 1259753 Opened 4 years ago Closed 4 years ago

Fix some CPP_UNIT_TESTS to use ScopedXPCOM

Categories

(Testing :: General, defect)

Version 3
defect
Not set

Tracking

(firefox48 fixed)

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: ted, Assigned: ted)

References

Details

Attachments

(1 file)

bug 1239083 makes XPCOM initialization set the ICU data directory to the GRE directory, which contains the ICU data file. This works fine in all cases except for three CPP_UNIT_TESTS which call InitXPCOM directly and don't pass in a directory. The ScopedXPCOM class from TestHarness.h uses an environment variable it gets from the Python test harness to do the right thing here, so changing the tests to use that fixes it.
Attachment #8734764 - Flags: review?(Ms2ger) → review+
Comment on attachment 8734764 [details]
MozReview Request: bug 1259753 - fix some C++ unittests to use ScopedXPCOM to init XPCOM. r?ms2ger

https://reviewboard.mozilla.org/r/42479/#review38939
https://hg.mozilla.org/mozilla-central/rev/58c9a586754e
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.