DOMUtils is (lazy) loaded but not used in css-angle.js

RESOLVED FIXED in Firefox 48

Status

()

Firefox
Developer Tools
P2
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: pbro, Assigned: nchevobbe)

Tracking

unspecified
Firefox 48
Points:
---

Firefox Tracking Flags

(firefox48 fixed)

Details

(Whiteboard: [btpp-fix-later])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
In the file devtools/shared/css-angle.js, there's a lazy getter at the bottom that access DOMUtils, but DOMUtils isn't used anywhere in the file.
(Assignee)

Comment 1

2 years ago
Created attachment 8734799 [details]
MozReview Request: Bug 1259777 - Remove unnecessary DOMUtils lazy load in css-angle.js . r=pbro

Review commit: https://reviewboard.mozilla.org/r/42487/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/42487/
Attachment #8734799 - Flags: review?(pbrosset)
(Reporter)

Comment 2

2 years ago
Comment on attachment 8734799 [details]
MozReview Request: Bug 1259777 - Remove unnecessary DOMUtils lazy load in css-angle.js . r=pbro

https://reviewboard.mozilla.org/r/42487/#review38963

Thanks for the quick fix.
Attachment #8734799 - Flags: review?(pbrosset) → review+
(Reporter)

Updated

2 years ago
Assignee: nobody → chevobbe.nicolas
Status: NEW → ASSIGNED

Comment 3

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/3e41c15a76b5

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3e41c15a76b5
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
You need to log in before you can comment on or make changes to this bug.