Add a test that would catch reporting exceptions in the callback's compartment, not the unwrapped callback's compartment

RESOLVED FIXED in Firefox 48

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Tracking

Trunk
mozilla48
Points:
---

Firefox Tracking Flags

(firefox48 fixed)

Details

(Whiteboard: btpp-active)

Attachments

(1 attachment)

I tried breaking this and running the wpt tests in testing/web-platform/tests/html/webappapis/scripting/processing-model-2/ and none of them failed.  This is not helpful.
Created attachment 8734806 [details] [diff] [review]
Add some web platform tests that ensure that error events are fired on the window an event listener comes from, even if it's attached to an event target in a different window, and no matter how it got there
Attachment #8734806 - Flags: review?(Ms2ger)
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Whiteboard: btpp-active
Comment on attachment 8734806 [details] [diff] [review]
Add some web platform tests that ensure that error events are fired on the window an event listener comes from, even if it's attached to an event target in a different window, and no matter how it got there

Review of attachment 8734806 [details] [diff] [review]:
-----------------------------------------------------------------

I think this is fine.

::: testing/web-platform/meta/MANIFEST.json
@@ +34858,5 @@
>            }
>          ]
>        },
>        "testharness": {
> +        "html/webappapis/scripting/processing-model-2/window-onerror-with-cross-frame-event-listeners-1.html": [

Note that this conflicts with bug 785941.

::: testing/web-platform/tests/html/webappapis/scripting/processing-model-2/window-onerror-with-cross-frame-event-listeners-1.html
@@ +1,3 @@
> +<!doctype html>
> +<meta charset=utf-8>
> +<title></title>

Titles for all of those would be nice.
Attachment #8734806 - Flags: review?(Ms2ger) → review+
> Note that this conflicts with bug 785941.

Yeah, adding new wpt tests in our setup slightly sucks like that.  I'll deal with the merge.

I'll try to add meaningful titles other than just "enumerating all combinations, 1 of 4" or something.

Comment 5

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d5486d4fde02
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox48: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.