1259962 - 'delete' and some other C++ keywords are not shown in bold

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Excerpt from https://reviewboard.mozilla.org/r/42575/diff/1#2 :
> bool mGenerateTimestamps;
>  SourceBufferAttributes& operator=(const SourceBufferAttributes& aOther) = default;
> private:
>   SourceBufferAttributes() = delete;

'bool', 'const', and ' default' (and other C++ keywords elsewhere) are displayed in bold characters, but 'delete' and 'private' are not.

I'm guessing RB has a list of words to write in bold, it should probably be checked against a complete list of C++ keywords (e.g. http://en.cppreference.com/w/cpp/keyword )
I'm voting for 'final' and 'override' to always be bold as well, as they would rarely be used as identifiers.

Comment 1

[Mark Côté [:mcote]]

My guess is that this is pygments treating .h files as C instead of C++.  Perhaps we can use the work in bug 1255876 to override this, although we'd probably have to do this in all cases.  Gerald, do you think it's acceptable to treat all .h files as C++?

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Yes I think it would be acceptable:
- Most of the code we review is C++,
- It's only a syntax highlighter in a review tool, so no real danger if things go wrong,
- In the worst case, a pure-C header that uses C++ keywords as identifiers would see them incorrectly bolded.

Comment 3

[:glob ✱]

i've configured pygments to feed all .h files into the C++ lexer.
due to caching this is unlikely to update any existing files.

Comment 4

[:glob ✱]

i see 'private' in bold now in .h files, resolving.