Closed
Bug 1259985
Opened 8 years ago
Closed 8 years ago
Potentially invalid fix in bug 1258410
Categories
(Core :: Audio/Video: Playback, defect)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
firefox47 | --- | fixed |
firefox48 | --- | unaffected |
People
(Reporter: jya, Assigned: mozbugz)
Details
Attachments
(1 file)
58 bytes,
text/x-review-board-request
|
jya
:
review+
lizzard
:
approval-mozilla-aurora+
lizzard
:
approval-mozilla-beta+
|
Details |
In bug 1258410, special exception was added to abort early should a member be null. However, the fix was invalid as it didn't return ! bug 1258410 contained two fixes. I believe the 2nd fix https://hg.mozilla.org/releases/mozilla-beta/rev/baa3826260a0 prevent the problems from ever occurring, but better be safe than sorry. the issue won't occur in nightly as the code was removed in bug 1259274
Reporter | ||
Updated•8 years ago
|
status-firefox46:
--- → affected
status-firefox47:
--- → affected
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → gsquelart
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/42667/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/42667/
Attachment #8735224 -
Flags: review?(jyavenard)
Reporter | ||
Updated•8 years ago
|
Attachment #8735224 -
Flags: review?(jyavenard) → review+
Reporter | ||
Comment 2•8 years ago
|
||
Comment on attachment 8735224 [details] MozReview Request: Bug 1259985 - Add missing return after null-check - r?jya https://reviewboard.mozilla.org/r/42667/#review39125
Reporter | ||
Comment 4•8 years ago
|
||
https://crash-stats.mozilla.com/search/?product=Firefox&signature=%3Dmp4_demuxer%3A%3AMP4Metadata%3A%3AGetNumberTracks&build_id=%3E%3D20160325000000&_facets=signature&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#crash-reports shows that the signature didn't show after the 25, which means that bug 1258410 may be sufficient
Assignee | ||
Comment 5•8 years ago
|
||
Comment on attachment 8735224 [details] MozReview Request: Bug 1259985 - Add missing return after null-check - r?jya Approval Request Comment [Feature/regressing bug #]: bug 1258410 [User impact if declined]: Potential crashes due to null dereference [Describe test coverage new/current, TreeHerder]: Lots of media mochitests, Aurora try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2c15f18f244d , Beta try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1afdeaf94173 [Risks and why]: No risks that I can see, as it's just adding an early "return;", and there are other early returns in the same method. [String/UUID change made/needed]: None.
Attachment #8735224 -
Flags: approval-mozilla-beta?
Attachment #8735224 -
Flags: approval-mozilla-aurora?
Comment 6•8 years ago
|
||
Comment on attachment 8735224 [details] MozReview Request: Bug 1259985 - Add missing return after null-check - r?jya Prevent potential crashes, please uplift to aurora and beta.
Attachment #8735224 -
Flags: approval-mozilla-beta?
Attachment #8735224 -
Flags: approval-mozilla-beta+
Attachment #8735224 -
Flags: approval-mozilla-aurora?
Attachment #8735224 -
Flags: approval-mozilla-aurora+
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b6fc58671a60
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Comment 8•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/f0bcd999646e
Comment 9•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/9200077814f6
You need to log in
before you can comment on or make changes to this bug.
Description
•