Closed Bug 1259985 Opened 5 years ago Closed 5 years ago

Potentially invalid fix in bug 1258410

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox46 --- fixed
firefox47 --- fixed
firefox48 --- unaffected

People

(Reporter: jya, Assigned: gerald)

Details

Attachments

(1 file)

In bug 1258410, special exception was added to abort early should a member be null.

However, the fix was invalid as it didn't return !

bug 1258410 contained two fixes. I believe the 2nd fix https://hg.mozilla.org/releases/mozilla-beta/rev/baa3826260a0 prevent the problems from ever occurring, but better be safe than sorry.

the issue won't occur in nightly as the code was removed in bug 1259274
Assignee: nobody → gsquelart
Attachment #8735224 - Flags: review?(jyavenard) → review+
Comment on attachment 8735224 [details]
MozReview Request: Bug 1259985 - Add missing return after null-check - r?jya

https://reviewboard.mozilla.org/r/42667/#review39125
Comment on attachment 8735224 [details]
MozReview Request: Bug 1259985 - Add missing return after null-check - r?jya

Approval Request Comment
[Feature/regressing bug #]: bug 1258410
[User impact if declined]: Potential crashes due to null dereference
[Describe test coverage new/current, TreeHerder]: Lots of media mochitests, Aurora try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2c15f18f244d , Beta try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1afdeaf94173
[Risks and why]: No risks that I can see, as it's just adding an early "return;", and there are other early returns in the same method.
[String/UUID change made/needed]: None.
Attachment #8735224 - Flags: approval-mozilla-beta?
Attachment #8735224 - Flags: approval-mozilla-aurora?
Comment on attachment 8735224 [details]
MozReview Request: Bug 1259985 - Add missing return after null-check - r?jya

Prevent potential crashes, please uplift to aurora and beta.
Attachment #8735224 - Flags: approval-mozilla-beta?
Attachment #8735224 - Flags: approval-mozilla-beta+
Attachment #8735224 - Flags: approval-mozilla-aurora?
Attachment #8735224 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/b6fc58671a60
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.