1259986 - firefox hello is showing blank dropdown in firefox version 45.0.1 and language marathi.

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P2)

Description

[Rohit]

Attachment: Bug 2.png

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:45.0) Gecko/20100101 Firefox/45.0
Build ID: 20160315153207

Steps to reproduce:

I clicked on firefox hello button in menubar.


Actual results:

Nothing shown in dropdown.


Expected results:

It should show something.

Comment 1

[Chandrakant Dhutadmal]

Kindly elaborate on this bug.

Comment 2

[Mark Banner (:standard8)]

Rohit: A couple of questions... 

Which language are you using?

Also,  if you startup Firefox, go to the menu and find the Web developer option, then select "Browser Console". Then go back and click the Hello button, do you get any errors displayed?

Comment 3

[Rohit]

I am using marathi language for firefox,  I tried console , but console dont show any error there.

Comment 4

[Rohit]

Attachment: Bug ID 1259986 console output reference.png

This image shows how I tried browser console and what happened after I clicked on Firefox Hello

Comment 5

[Ed Lee :Mardak]

The add-on doesn't have a "mr" locale, but the version in release is using this file anyway:

http://hg.mozilla.org/releases/l10n/mozilla-release/mr/file/tip/browser/chrome/browser/loop/loop.properties

कम्पोनंट ऑब्जेक्टचा वापर होत नाही. त्याला लवकरच काढून टाकले जाईल. utils.js:9:15
points to
chrome://loop/content/shared/js/utils.js:
var inChrome = typeof Components != "undefined" && "utils" in Components;

TypeError: kPluralFunctions[gL10nDetails.pluralRule] is undefined l10n.js:213:9
points to
chrome://loop/content/panels/vendor/l10n.js
gPluralFunc = kPluralFunctions[gL10nDetails.pluralRule][1];

Comment 6

[Ed Lee :Mardak]

(In reply to Ed Lee :Mardak from comment #5)
> कम्पोनंट ऑब्जेक्टचा वापर होत नाही. त्याला लवकरच काढून टाकले जाईल.
> utils.js:9:15
> points to
> chrome://loop/content/shared/js/utils.js:
> var inChrome = typeof Components != "undefined" && "utils" in Components;
FYI, this is:

 ComponentsWarning=The Components object is deprecated. It will soon be removed.

Comment 7

[Ian Bicking (:ianbicking)]

It seems like we should clean up the mr locale from mozilla-central, since it's from before we had an add-on localization process.  We should also check that there aren't more localizations like this.  There's also presumably a bug where the locale confusion causes some fatal error, while it should fall back to English.

(Is something trying to localize the Components warning?)

Comment 8

[Mark Banner (:standard8)]

The Components isn't the issue here - that's just a standard warning that we can't do anything about.

The real issue will be the TypeError for the plural rule.

Comment 9

[Mark Banner (:standard8)]

Ok, I figured it, if you watch the console there's actually two things, although the first one isn't an error:

PluralForm.jsm: Invalid rule number: NaN -- defaulting to 0
TypeError: kPluralFunctions[gL10nDetails.pluralRule] is undefined l10n.js:213:9

The first one points us to the fact (tracing through code) that Firefox has an invalid number for the plural form - looking in the intl.properties for `mr` shows that the pluralRule is a localised character rather than an ascii digit.

Firefox doesn't explode because it defaults to zero in the case the rule is out-of-bounds.

I've raised bug 1260526 to get that fixed.


I think to prevent this happening to us, we should change our code to also fallback to the form zero.

This would also protect us in the case a rule is added for a new locale and we don't notice.

I've checked the other locales, and there's no others that are setting incorrect values for the plural form.

Comment 10

[GitHub Autolander Bot]

Attachment: [loop] Standard8:bug-1259986-intl > mozilla:master

Comment 11

[Mark Banner (:standard8)]

https://github.com/mozilla/loop/commit/d852d29f6fd8b174f861e6b5615e37387b74176b