1260010 - Show downstream/reassigned alert in graphs when downstream or reassigned

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

looking at an fx-team alert, I see it happened originally on mozilla-inbound:
https://treeherder.mozilla.org/perf.html#/graphs?series=%5Bfx-team,9645b2e484a87de019caac3cd849c7bcf9049da8,1%5D&series=%5Bmozilla-inbound,9645b2e484a87de019caac3cd849c7bcf9049da8,1%5D&series=%5Bmozilla-central,9645b2e484a87de019caac3cd849c7bcf9049da8,0%5D&zoom=1458784201932.9412,1458887361676.4707,364.71003762851416,390&selected=%5Bmozilla-inbound,9645b2e484a87de019caac3cd849c7bcf9049da8,29082,24547444%5D

Given that, I hover over the inbound alert and I see it is:
https://treeherder.mozilla.org/perf.html#/alerts?id=599

but that was reassigned to 600, this should be slightly clearer in the graph interface.  In fact I normally see reassigned/downstream instead of 'investigating'.

Comment 1

[William Lachance (:wlach)]

I think we should update the display to say "Alert #123 (downstream to alert #321)" or "Alert #123 (reassigned to alert #321)" when the alert has such a status. ShrutiJ, do you want to take this on?

Here's an updated link which demonstrates the issue:

https://treeherder.mozilla.org/perf.html#/graphs?timerange=31536000&series=%5Bmozilla-inbound,9645b2e484a87de019caac3cd849c7bcf9049da8,1,1%5D&series=%5Bmozilla-central,9645b2e484a87de019caac3cd849c7bcf9049da8,1,1%5D&series=%5Bfx-team,9645b2e484a87de019caac3cd849c7bcf9049da8,1,1%5D&zoom=1458708776742.9617,1458973381058.404,360.2873689066298,391.988146950051&selected=%5Bmozilla-central,9645b2e484a87de019caac3cd849c7bcf9049da8,5590,3545338,1%5D

The code you need to modify is here:

https://github.com/mozilla/treeherder/blob/master/ui/partials/perf/graphsctrl.html#L81

You should be able to (mostly) just borrow the type of logic here to get the right behaviour:

https://github.com/mozilla/treeherder/blob/master/ui/partials/perf/alertsctrl.html#L115

Comment 2

[Shruti Jasoria [:ShrutiJ]]

I have a doubt:

While I was going through the link which demonstrates the issue in comment 1, I came across Alert#636:

https://treeherder.mozilla.org/perf.html#/alerts?id=636

The two tests have been down streamed to separate alerts. So in the modifications which I have to make, should they display all the alerts to which an alert has been reassigned/downstream?

Comment 3

[William Lachance (:wlach)]

(In reply to Shruti Jasoria [:ShrutiJ] from comment #2)
> The two tests have been down streamed to separate alerts. So in the
> modifications which I have to make, should they display all the alerts to
> which an alert has been reassigned/downstream?

At present, a specific alert can only be marked reassigned or downstream to *one* other alert. It is true that a summary might have alerts reassigned/downstreamed to different summaries, but in the case of specific alerts there should be no ambiguity.

Perhaps looking at the alertsummary endpoint might clarify some of this:

https://treeherder.mozilla.org/api/performance/alertsummary/636/

You want to use the value of 'related_summary_id' for the specific alert to redirect to the appropriate summary.

Comment 4

[GitHub Autolander Bot]

Attachment: [treeherder] SJasoria:Bug_1260010 > mozilla:master

Comment 5

[Shruti Jasoria [:ShrutiJ]]

Attachment: Changes made to graphsctrl.html

I have made the changes which you had asked for in graphsctrl.html. Please take a look and let me know if anything has to be changed.

Comment 6

[William Lachance (:wlach)]

Comment on attachment 8768029 [details] [review]
Changes made to graphsctrl.html

This is awesome. Some minor fixes and we'll be good to land. :) Please set r? on the existing attachment when you've updated the pull request.

Comment 7

[Shruti Jasoria [:ShrutiJ]]

Comment on attachment 8768029 [details] [review]
Changes made to graphsctrl.html

I have made the changes which you had asked for in PR. 
Take a look, and let me know if any more changes are required :)

Comment 8

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/bde0c5cdb1545e13d10ce4375db9fbdc5940f7d4
Bug 1260010 - Show downstream/reassigned alert in graphs when downstream or reassigned

Comment 9

[William Lachance (:wlach)]

Comment on attachment 8768029 [details] [review]
Changes made to graphsctrl.html

This is good. There were some minor whitespace issues, which I fixed myself just to reduce churn. Thank you for the patch!