Open the testcase, click the link. Expected results: Opens in top frame. Actual: Opens in full window.
wfm on Linux / Build 2002021308
Well, it doesn't work in 2002021203... Adrian: Are you sure you have browser.target_new_blocked switched on?
Uuuppss.. sorry.. i didn't read the summary field carefully enough! With: all.js:pref("browser.target_new_blocked", true); It _doesn't_ work on linux build 2002021308
Keywords: patch, review
OS: Windows 2000 → All
Hardware: PC → All
<offtopic> Bz: Just out of curiosity, why did you add the 'patch' keyword? According to http://bugzilla.mozilla.org/describekeywords.cgi, it tracks patches "by individuals without direct code check in privileges", but you do have a CVS account (don't you?), so why the keyword? </offtopic>
<offtopic> Habit from when I didn't have a CVS account. :) </offtopic>
Looks reasonable to me ... Boris, did you want to take this bug back? You can have r=akkana on it.
Assignee: akkana → bzbarsky
Status: NEW → ASSIGNED
Priority: -- → P2
Summary: target="_self" becomes target="_top" with browser.target_new_blocked → [FIX]target="_self" becomes target="_top" with browser.target_new_blocked
Target Milestone: --- → mozilla1.0
Comment on attachment 69963 [details] [diff] [review] Proposed patch email@example.com
Attachment #69963 - Flags: superreview+
browser.target_new_blocked has been renamed to browser.block.target_new_window. Updating summary. Boris: Now that this pref is exposed to the public (bug 78037), do you think it might be worth to try to get this into 0.9.9?
Summary: [FIX]target="_self" becomes target="_top" with browser.target_new_blocked → [FIX]target="_self" becomes target="_top" with browser.block.target_new_window
Frankly, no. Not that many places use target="_self" and 0.9.9 is pretty much locked down at this point...
Comment on attachment 69963 [details] [diff] [review] Proposed patch Boris came to his senses and asked for approval of this. a=shaver for 0.9.9. (Also recording r=akkaka with the patch manager.)
Priority: P2 → P1
Target Milestone: mozilla1.0 → mozilla0.9.9
checked in for 0.9.9 (pre-branch).
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
Verified on build 2002030913 from 0.9.9 branch.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.