Closed Bug 1260035 Opened 4 years ago Closed 4 years ago
Disable text encoding menu when no message displayed
See: Bug 1235294 - Text Encoding menu disabled when charset not supported Bug 1244430 - View->Text encoding produces exception with nsIStringBundle.GetStringFromName https://hg.mozilla.org/comm-central/rev/2a6797a9c8aa https://hg.mozilla.org/comm-central/rev/d468c5939d66
patch without whitespace cleanup
patch with whitespace cleanup. If too much I will open another bug for the ws parts.
Tested on Windows 7 en-US build VS2015 x64 User agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:48.0) Gecko/20100101 Firefox/48.0 SeaMonkey/2.45a1
Assignee: nobody → frgrahl
Revised patch. Further proof that you can bungle a one liner.
Comment on attachment 8735308 [details] [diff] [review] 1260035-text-encoding-disable-V2.patch r=me
Attachment #8735308 - Flags: review?(philip.chee) → review+
Comment on attachment 8735308 [details] [diff] [review] 1260035-text-encoding-disable-V2.patch [Approval Request Comment] Regression caused by (bug #): N/A User impact if declined: Users cannot change text encoding if character set of mail message is icorrext. Testing completed (on m-c, etc.): Tested on c-c, SeaMonkey Risk to taking this patch (and alternatives if risky): no risk. String changes made by this patch: none.
You need to log in before you can comment on or make changes to this bug.