Closed
Bug 1260035
Opened 8 years ago
Closed 8 years ago
Disable text encoding menu when no message displayed.
Categories
(SeaMonkey :: MailNews: General, defect)
SeaMonkey
MailNews: General
Tracking
(seamonkey2.42 fixed, seamonkey2.43 fixed, seamonkey2.44 fixed, seamonkey2.46 fixed)
RESOLVED
FIXED
seamonkey2.45
People
(Reporter: philip.chee, Assigned: frg)
References
Details
(Keywords: regression, Whiteboard: [leave open for branches])
Attachments
(1 file, 2 obsolete files)
|
1.21 KB,
patch
|
philip.chee
:
review+
philip.chee
:
approval-comm-aurora+
philip.chee
:
approval-comm-beta+
philip.chee
:
approval-comm-release+
|
Details | Diff | Splinter Review |
See: Bug 1235294 - Text Encoding menu disabled when charset not supported Bug 1244430 - View->Text encoding produces exception with nsIStringBundle.GetStringFromName https://hg.mozilla.org/comm-central/rev/2a6797a9c8aa https://hg.mozilla.org/comm-central/rev/d468c5939d66
|
Assignee | |
Comment 1•8 years ago
|
||
patch without whitespace cleanup
Attachment #8735296 -
Flags: review?(philip.chee)
|
|
Assignee | |
Comment 2•8 years ago
|
||
patch with whitespace cleanup. If too much I will open another bug for the ws parts.
Attachment #8735297 -
Flags: review?(philip.chee)
|
|
Assignee | |
Comment 3•8 years ago
|
||
Tested on Windows 7 en-US build VS2015 x64 User agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:48.0) Gecko/20100101 Firefox/48.0 SeaMonkey/2.45a1
Assignee: nobody → frgrahl
|
|
Assignee | |
Comment 4•8 years ago
|
||
Revised patch. Further proof that you can bungle a one liner.
Attachment #8735296 -
Attachment is obsolete: true
Attachment #8735297 -
Attachment is obsolete: true
Attachment #8735296 -
Flags: review?(philip.chee)
Attachment #8735297 -
Flags: review?(philip.chee)
Attachment #8735308 -
Flags: review?(philip.chee)
|
|
Reporter | |
Comment 5•8 years ago
|
||
Comment on attachment 8735308 [details] [diff] [review] 1260035-text-encoding-disable-V2.patch r=me
Attachment #8735308 -
Flags: review?(philip.chee) → review+
|
|
Reporter | |
Updated•8 years ago
|
Keywords: checkin-needed
|
|
Reporter | |
Comment 6•8 years ago
|
||
http://hg.mozilla.org/comm-central/rev/9499eb58d87c
Status: NEW → ASSIGNED
Keywords: checkin-needed
Whiteboard: [leave open for branches]
Target Milestone: --- → seamonkey2.45
|
|
Reporter | |
Comment 7•8 years ago
|
||
Comment on attachment 8735308 [details] [diff] [review] 1260035-text-encoding-disable-V2.patch [Approval Request Comment] Regression caused by (bug #): N/A User impact if declined: Users cannot change text encoding if character set of mail message is icorrext. Testing completed (on m-c, etc.): Tested on c-c, SeaMonkey Risk to taking this patch (and alternatives if risky): no risk. String changes made by this patch: none.
Attachment #8735308 -
Flags: approval-comm-release+
Attachment #8735308 -
Flags: approval-comm-beta+
Attachment #8735308 -
Flags: approval-comm-aurora+
|
|
Reporter | |
Comment 8•8 years ago
|
||
http://hg.mozilla.org/releases/comm-aurora/rev/ae5edf4e0802 http://hg.mozilla.org/releases/comm-beta/rev/2ea47b3b21d2 http://hg.mozilla.org/releases/comm-release/rev/72ba61653924 http://hg.mozilla.org/releases/comm-esr45/rev/4a19fd3933c6
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•