1260071 - Horizontal scrollbar in console not completely fixed by bug 1248301

Status: VERIFIED FIXED

(DevTools :: Console, defect, P2)

Description

[Oriol Brufau [:Oriol]]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:48.0) Gecko/20100101 Firefox/48.0
Build ID: 20160326030430

Steps to reproduce:

1. Open Web Console
2. Clear it
3. Keep pressing spacebar+enter until the console is filled vertically and a vertical scrollbar appears
4. Press Ctrl+F (or focus "Filter output" at the top right)
5. Write something like 123456789 in that search field
6. Now the console should be empty because there is no match
5. Enter something like 123 in the console
6. Clear the search field


Actual results:

A horizontal scrollbar appears in the console.


Expected results:

There shouldn't be any horizontal scrollbar.
Just resizing the console removes the scrollbar.

Culprit: https://hg.mozilla.org/integration/fx-team/rev/1aed451f1502

Comment 1

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Tracked for 47+ as it's a recent regression, though seems minor to me.

Comment 2

[Liz Henry (:lizzard) (relman/hg->git project)]

Recent regression, but it is late in beta (heading into beta 7) to fix this in 46. 
Michelle can your team reproduce and confirm this?

Comment 3

[Brian Grinstead [:bgrins]]

I'll take a look at it

Comment 4

[Brian Grinstead [:bgrins]]

Attachment: MozReview Request: Bug 1260071 - Call resize() when searching happens on frontend to reset width;r=vporof

Review commit: https://reviewboard.mozilla.org/r/43065/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43065/

Comment 5

[Michelle Funches - QA]

Yes, I have confirmed the horizontal scroll-bar appears in Nightly
Seen in Web Console (Ctrl Shift K) and can also be seen Browser Console (Ctrl Shift J)
Version 	48.0a1
Build ID 	20160329030246
User Agent 	Mozilla/5.0 (Windows NT 10.0; WOW64; rv:48.0) Gecko/20100101 Firefox/48.0

Comment 6

[Victor Porof [:vporof][:vp]]

Comment on attachment 8736060 [details]
MozReview Request: Bug 1260071 - Call resize() when searching happens on frontend to reset width;r=vporof

https://reviewboard.mozilla.org/r/43065/#review39709

Comment 7

[Brian Grinstead [:bgrins]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f74ddd526b06

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/77bdb92ae149

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/77bdb92ae149

Comment 10

[Michelle Funches - QA]

Web Console & Browser Console  Verified Fixed when applying https://hg.mozilla.org/mozilla-central/rev/77bdb92ae149

Comment 11

[Liz Henry (:lizzard) (relman/hg->git project)]

Too late for 46 for a minor regression. We could still take an uplift in aurora though.

Comment 12

[Brian Grinstead [:bgrins]]

Comment on attachment 8736060 [details]
MozReview Request: Bug 1260071 - Call resize() when searching happens on frontend to reset width;r=vporof

Approval Request Comment
[Feature/regressing bug #]: 1237368
[User impact if declined]: Horizontal scrollbar can show up in console after searching
[Describe test coverage new/current, TreeHerder]: None
[Risks and why]: Low risk, doing one extra resize calculation after a search happens (same function that's called after a new message is added)
[String/UUID change made/needed]:

Comment 13

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8736060 [details]
MozReview Request: Bug 1260071 - Call resize() when searching happens on frontend to reset width;r=vporof

Low risk regression fix that was verified on Nightly, Aurora47+

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/387085c9cca4