Closed Bug 1260071 Opened 4 years ago Closed 4 years ago

Horizontal scrollbar in console not completely fixed by bug 1248301

Categories

(DevTools :: Console, defect, P2)

46 Branch
defect

Tracking

(firefox45 unaffected, firefox46- wontfix, firefox47+ fixed, firefox48+ fixed)

VERIFIED FIXED
Firefox 48
Tracking Status
firefox45 --- unaffected
firefox46 - wontfix
firefox47 + fixed
firefox48 + fixed

People

(Reporter: Oriol, Assigned: bgrins)

References

Details

(Keywords: regression, Whiteboard: [btpp-fix-later])

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:48.0) Gecko/20100101 Firefox/48.0
Build ID: 20160326030430

Steps to reproduce:

1. Open Web Console
2. Clear it
3. Keep pressing spacebar+enter until the console is filled vertically and a vertical scrollbar appears
4. Press Ctrl+F (or focus "Filter output" at the top right)
5. Write something like 123456789 in that search field
6. Now the console should be empty because there is no match
5. Enter something like 123 in the console
6. Clear the search field


Actual results:

A horizontal scrollbar appears in the console.


Expected results:

There shouldn't be any horizontal scrollbar.
Just resizing the console removes the scrollbar.

Culprit: https://hg.mozilla.org/integration/fx-team/rev/1aed451f1502
Blocks: 1237368
Component: Untriaged → Developer Tools: Console
Keywords: regression
See Also: → 1248301
Version: 48 Branch → 46 Branch
Has STR: --- → yes
Flags: needinfo?(bgrinstead)
Tracked for 47+ as it's a recent regression, though seems minor to me.
Recent regression, but it is late in beta (heading into beta 7) to fix this in 46. 
Michelle can your team reproduce and confirm this?
Flags: needinfo?(mfunches)
I'll take a look at it
Flags: needinfo?(bgrinstead)
Priority: -- → P2
Whiteboard: [btpp-fix-later]
Yes, I have confirmed the horizontal scroll-bar appears in Nightly
Seen in Web Console (Ctrl Shift K) and can also be seen Browser Console (Ctrl Shift J)
Version 	48.0a1
Build ID 	20160329030246
User Agent 	Mozilla/5.0 (Windows NT 10.0; WOW64; rv:48.0) Gecko/20100101 Firefox/48.0
Assignee: nobody → bgrinstead
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Comment on attachment 8736060 [details]
MozReview Request: Bug 1260071 - Call resize() when searching happens on frontend to reset width;r=vporof

https://reviewboard.mozilla.org/r/43065/#review39709
Attachment #8736060 - Flags: review?(vporof) → review+
https://hg.mozilla.org/mozilla-central/rev/77bdb92ae149
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Web Console & Browser Console  Verified Fixed when applying https://hg.mozilla.org/mozilla-central/rev/77bdb92ae149
Status: RESOLVED → VERIFIED
Flags: needinfo?(mfunches)
Too late for 46 for a minor regression. We could still take an uplift in aurora though.
See Also: → 1261533
Comment on attachment 8736060 [details]
MozReview Request: Bug 1260071 - Call resize() when searching happens on frontend to reset width;r=vporof

Approval Request Comment
[Feature/regressing bug #]: 1237368
[User impact if declined]: Horizontal scrollbar can show up in console after searching
[Describe test coverage new/current, TreeHerder]: None
[Risks and why]: Low risk, doing one extra resize calculation after a search happens (same function that's called after a new message is added)
[String/UUID change made/needed]:
Attachment #8736060 - Flags: approval-mozilla-aurora?
Comment on attachment 8736060 [details]
MozReview Request: Bug 1260071 - Call resize() when searching happens on frontend to reset width;r=vporof

Low risk regression fix that was verified on Nightly, Aurora47+
Attachment #8736060 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.